mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-16 04:18:50 +00:00
gdb_is_target_native uses "maint print target-stack", which is unnecessary when checking whether gdb_protocol is empty would do. Checking gdb_protocol is more efficient, and can be done before starting GDB and running to main, unlike gdb_is_target_native. This adds a new gdb_protocol_is_native procedure, and uses it in place of gdb_is_target_native. At first, I thought that we'd end up with a few testcases needing to use gdb_is_target_native still, especially multi-target tests that connect to targets different from the default board target, but no, actually all uses of gdb_is_target_native could be converted. gdb_is_target_native will be eliminated in a following patch. In some spots, we no longer need to defer the check until after starting GDB, so the patch adjusts accordingly. Change-Id: Ia706232dbffac70f9d9740bcb89c609dbee5cee3 Approved-By: Tom Tromey <tom@tromey.com>
62 lines
2.1 KiB
Plaintext
62 lines
2.1 KiB
Plaintext
# Copyright 2023-2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test that after an exec of a non-leader thread, we don't leave the
|
|
# non-leader thread listed in internal thread lists, causing problems.
|
|
|
|
standard_testfile .c
|
|
|
|
proc do_test { } {
|
|
if [prepare_for_testing "failed to prepare" $::testfile $::srcfile {debug pthreads}] {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] {
|
|
return
|
|
}
|
|
|
|
gdb_test "catch exec" "Catchpoint $::decimal \\(exec\\)"
|
|
|
|
gdb_test "continue" "Catchpoint $::decimal .*" "continue until exec"
|
|
|
|
# Confirm we only have one thread in the thread list.
|
|
gdb_test "p \$_inferior_thread_count" " = 1"
|
|
|
|
# Get the post-exec thread number. Due to PR gdb/31069 ("Zombie
|
|
# leader detection racy") this isn't always thread 1.1.
|
|
set cur_thr [get_integer_valueof "\$_thread" 0]
|
|
|
|
if {[istarget *-*-linux*] && [gdb_protocol_is_native]} {
|
|
# Confirm there's only one LWP in the list as well, and that
|
|
# it is bound to the existing GDB thread.
|
|
set inf_pid [get_inferior_pid]
|
|
gdb_test_multiple "maint info linux-lwps" "" {
|
|
-wrap -re "Thread ID *\r\n$inf_pid\.$inf_pid\.0\[ \t\]+1\.$cur_thr *" {
|
|
pass $gdb_test_name
|
|
}
|
|
}
|
|
}
|
|
|
|
# Test that GDB is able to kill the inferior. This used to crash
|
|
# on native Linux as GDB did not dispose of the pre-exec LWP for
|
|
# the non-leader (and that LWP did not have a matching thread in
|
|
# the core thread list).
|
|
gdb_test "with confirm off -- kill" \
|
|
"\\\[Inferior 1 (.*) killed\\\]" \
|
|
"kill inferior"
|
|
}
|
|
|
|
do_test
|