mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-06 07:33:08 +00:00
8480a37e14
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
118 lines
4.0 KiB
C
118 lines
4.0 KiB
C
/* Target-dependent code for Solaris.
|
|
|
|
Copyright (C) 2006-2024 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "frame.h"
|
|
#include "symtab.h"
|
|
#include "inferior.h"
|
|
#include "objfiles.h"
|
|
|
|
#include "sol2-tdep.h"
|
|
|
|
/* The Solaris signal trampolines reside in libc. For normal signals,
|
|
the function `sigacthandler' is used. This signal trampoline will
|
|
call the signal handler using the System V calling convention,
|
|
where the third argument is a pointer to an instance of
|
|
`ucontext_t', which has a member `uc_mcontext' that contains the
|
|
saved registers. Incidentally, the kernel passes the `ucontext_t'
|
|
pointer as the third argument of the signal trampoline too, and
|
|
`sigacthandler' simply passes it on. However, if you link your
|
|
program with "-L/usr/ucblib -R/usr/ucblib -lucb", the function
|
|
`ucbsigvechandler' will be used, which invokes the using the BSD
|
|
convention, where the third argument is a pointer to an instance of
|
|
`struct sigcontext'. It is the `ucbsigvechandler' function that
|
|
converts the `ucontext_t' to a `sigcontext', and back. Unless the
|
|
signal handler modifies the `struct sigcontext' we can safely
|
|
ignore this. */
|
|
|
|
static int
|
|
sol2_pc_in_sigtramp (CORE_ADDR pc, const char *name)
|
|
{
|
|
return (name && (strcmp (name, "sigacthandler") == 0
|
|
|| strcmp (name, "ucbsigvechandler") == 0
|
|
|| strcmp (name, "__sighndlr") == 0));
|
|
}
|
|
|
|
/* Return whether THIS_FRAME corresponds to a Solaris sigtramp routine. */
|
|
|
|
int
|
|
sol2_sigtramp_p (const frame_info_ptr &this_frame)
|
|
{
|
|
CORE_ADDR pc = get_frame_pc (this_frame);
|
|
const char *name;
|
|
|
|
find_pc_partial_function (pc, &name, NULL, NULL);
|
|
return sol2_pc_in_sigtramp (pc, name);
|
|
}
|
|
|
|
static CORE_ADDR
|
|
sol2_skip_solib_resolver (struct gdbarch *gdbarch, CORE_ADDR pc)
|
|
{
|
|
struct bound_minimal_symbol msym;
|
|
|
|
msym = lookup_minimal_symbol("elf_bndr", NULL, NULL);
|
|
if (msym.minsym && msym.value_address () == pc)
|
|
return frame_unwind_caller_pc (get_current_frame ());
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* This is how we want PTIDs from Solaris core files to be printed. */
|
|
|
|
static std::string
|
|
sol2_core_pid_to_str (struct gdbarch *gdbarch, ptid_t ptid)
|
|
{
|
|
struct inferior *inf;
|
|
int pid;
|
|
|
|
/* Check whether we're printing an LWP (gdb thread) or a process. */
|
|
pid = ptid.lwp ();
|
|
if (pid != 0)
|
|
{
|
|
/* A thread. */
|
|
return string_printf ("LWP %ld", ptid.lwp ());
|
|
}
|
|
|
|
/* GDB didn't use to put a NT_PSTATUS note in Solaris cores. If
|
|
that's missing, then we're dealing with a fake PID corelow.c made up. */
|
|
inf = find_inferior_ptid (current_inferior ()->process_target (), ptid);
|
|
if (inf == NULL || inf->fake_pid_p)
|
|
return "<core>";
|
|
|
|
/* Not fake; print as usual. */
|
|
return normal_pid_to_str (ptid);
|
|
}
|
|
|
|
/* To be called from GDB_OSABI_SOLARIS handlers. */
|
|
|
|
void
|
|
sol2_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
/* The Sun compilers (Sun ONE Studio, Forte Developer, Sun WorkShop, SunPRO)
|
|
compiler puts out 0 instead of the address in N_SO stabs. Starting with
|
|
SunPRO 3.0, the compiler does this for N_FUN stabs too. */
|
|
set_gdbarch_sofun_address_maybe_missing (gdbarch, 1);
|
|
|
|
/* Solaris uses SVR4-style shared libraries. */
|
|
set_gdbarch_skip_solib_resolver (gdbarch, sol2_skip_solib_resolver);
|
|
|
|
/* How to print LWP PTIDs from core files. */
|
|
set_gdbarch_core_pid_to_str (gdbarch, sol2_core_pid_to_str);
|
|
}
|