mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-26 09:08:59 +00:00
1d5f884e50
I spotted this while reviewing a patch adding a new gdbarch_software_single_step implementation. I find the name "software_single_step" a bit misleading or unclear. It makes it sounds as if the function executed a single step. In reality, this function returns the possible next PCs for current instructions. We have a similar concept in GDBserver: linux_process_target::low_get_next_pcs. I like that name, it's clear and straight to the point. Rename gdbarch_software_single_step to gdbarch_get_next_pcs. I find this name more indicative of what happens. There is some code for ARM shared between GDB and GDBserver to implement both sides, also called "get next pcs", so I think it all fits well together. Tested by rebuilding. Change-Id: Ide74011a5034ba11117b7e7c865a093ef0b1dece Approved-by: Kevin Buettner <kevinb@redhat.com> Acked-by: Luis Machado <luis.machado.foss@gmail.com>
84 lines
2.7 KiB
C
84 lines
2.7 KiB
C
/* Copyright (C) 2016-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "objfiles.h"
|
|
#include "arm-tdep.h"
|
|
#include "osabi.h"
|
|
|
|
/* The gdbarch_register_osabi handler for ARM PikeOS; it performs
|
|
the gdbarch initialization for that platform. */
|
|
|
|
static void
|
|
arm_pikeos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
/* Single stepping. */
|
|
set_gdbarch_get_next_pcs (gdbarch, arm_software_single_step);
|
|
}
|
|
|
|
/* The ARM PikeOS OSABI sniffer (see gdbarch_register_osabi_sniffer).
|
|
Returns GDB_OSABI_PIKEOS if the given BFD is a PikeOS binary,
|
|
GDB_OSABI_UNKNOWN otherwise. */
|
|
|
|
static enum gdb_osabi
|
|
arm_pikeos_osabi_sniffer (bfd *abfd)
|
|
{
|
|
int pikeos_stack_found = 0;
|
|
int pikeos_stack_size_found = 0;
|
|
|
|
/* The BFD target of PikeOS is really just standard elf, so we
|
|
cannot use it to detect this variant. The only common thing that
|
|
may be found in PikeOS modules are symbols _vm_stack/__p4_stack and
|
|
_vm_stack_size/__p4_stack_end. They are used to specify the stack
|
|
location and size; and defined by the default linker script.
|
|
|
|
OS ABI sniffers are called before the minimal symtabs are
|
|
created. So inspect the symbol table using BFD. */
|
|
|
|
gdb::array_view<asymbol *> symbol_table
|
|
= gdb_bfd_canonicalize_symtab (abfd, false);
|
|
|
|
if (symbol_table.empty ())
|
|
return GDB_OSABI_UNKNOWN;
|
|
|
|
for (const asymbol *sym : symbol_table)
|
|
{
|
|
const char *name = bfd_asymbol_name (sym);
|
|
|
|
if (strcmp (name, "_vm_stack") == 0
|
|
|| strcmp (name, "__p4_stack") == 0)
|
|
pikeos_stack_found = 1;
|
|
|
|
if (strcmp (name, "_vm_stack_size") == 0
|
|
|| strcmp (name, "__p4_stack_end") == 0)
|
|
pikeos_stack_size_found = 1;
|
|
}
|
|
|
|
if (pikeos_stack_found && pikeos_stack_size_found)
|
|
return GDB_OSABI_PIKEOS;
|
|
else
|
|
return GDB_OSABI_UNKNOWN;
|
|
}
|
|
|
|
INIT_GDB_FILE (arm_pikeos_tdep)
|
|
{
|
|
/* Register the sniffer for the PikeOS targets. */
|
|
gdbarch_register_osabi_sniffer (bfd_arch_arm, bfd_target_elf_flavour,
|
|
arm_pikeos_osabi_sniffer);
|
|
gdbarch_register_osabi (bfd_arch_arm, 0, GDB_OSABI_PIKEOS,
|
|
arm_pikeos_init_abi);
|
|
}
|