Files
binutils-gdb/gdb/testsuite/gdb.rust/methods.exp
Tom Tromey 6e7eef7216 Use rust_demangle to fix a crash
PR rust/30211 points out a crash caused by a particular completion.
This turns out to happen because a Rust minsym winds up in a
C++-specific path in strncmp_iw_with_mode, which ultimately causes the
completer to pass invalid arguments to string::append.

This patch fixes the bug by reordering the language constants so that
Rust comes before C++, and then using rust_demangle.  This ensures
that minsyms are correctly marked as "Rust", avoiding this code and
thus the crash.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=20367
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30211
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
2023-03-20 07:47:15 -06:00

65 lines
2.1 KiB
Plaintext

# Copyright (C) 2016-2023 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Test method calls.
load_lib rust-support.exp
require allow_rust_tests
standard_testfile .rs
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
return -1
}
set line [gdb_get_line_number "set breakpoint 1 here"]
if {![runto ${srcfile}:$line]} {
untested "could not run to breakpoint"
return -1
}
gdb_test "print x" " = methods::HasMethods \\{value: 0\\}"
gdb_test "print methods::HasMethods{value: 73}" \
" = methods::HasMethods \\{value: 73\\}"
gdb_test "print methods::HasMethods{..x}" \
" = methods::HasMethods \\{value: 0\\}"
gdb_test "print methods::HasMethods{value:19, ..x}" \
" = methods::HasMethods \\{value: 19\\}"
gdb_test "print x.take()" " = methods::HasMethods \\{value: 0\\}"
gdb_test "print *(x.incr())" " = methods::HasMethods \\{value: 1\\}"
gdb_test "print *((&mut x).incr())" " = methods::HasMethods \\{value: 2\\}"
gdb_test "print a.value()" " = 23"
gdb_test "print (&mut a).value()" " = 23"
# gdb_test "print a.take_value().0" " = 23"
gdb_test "print b.value()" " = 24"
gdb_test "print c.value()" " = 452"
set line [gdb_get_line_number "set breakpoint 2 here"]
gdb_breakpoint ${srcfile}:$line
gdb_continue_to_breakpoint "second breakpoint"
gdb_test "print *self" " = 23"
gdb_test "info functions HasMethods::new" \
"fn methods::HasMethods::new\\(\\) -> methods::HasMethods;"
# Regression test for PR rust/20367 and PR rust/30211. This used to
# crash.
gdb_test_no_output "complete break what"