Files
binutils-gdb/gdb/nat/linux-ptrace.c
Andrew Burgess 5b582f86bd gdb/linux: consider ptrace_scope when building attach error message
On GNU/Linux, if an attach fails, then we end up calling
linux_ptrace_attach_fail_reason, which returns a string describing why
the attach might have failed.

This commit extends linux_ptrace_attach_fail_reason to check the
current /proc/sys/kernel/yama/ptrace_scope setting.  When this is set
to a value greater than 0 attaching can be restricted in some cases.

If I first set ptrace_scope to 1, like this:

  $ echo 1 | sudo tee /proc/sys/kernel/yama/ptrace_scope

Then use current master GDB to attach to a process, I see this:

  (gdb) attach 2476518
  Attaching to process 2476518
  ptrace: Operation not permitted.
  (gdb)

With this patch applied the output becomes:

  (gdb) attach 2476518
  Attaching to process 2476518
  warning: the /proc/sys/kernel/yama/ptrace_scope setting of 1 might prevent attaching, see 'man 2 ptrace'
  ptrace: Operation not permitted.
  (gdb)

In my (limited) experience, not every user is familiar with the
ptrace_scope setting.  Finding that attach just doesn't work often
leads users to believe that the only way to have GDB attach to another
process is to run GDB as root.

Though that is a solution to the problem, my hope is that, by giving
the users more information, they can make a more informed choice about
which solution is right for them (e.g. run as root, change the
setting, start the inferior directly under GDB, etc).

This change also works for gdbserver.  For example:

  (gdb) target extended-remote :54321
  Remote debugging using :54321
  (gdb) attach 2475389
  Attaching to process 2475389
  Attaching to process 2475389 failed: Cannot attach to process 2475389: \
     Operation not permitted (1), the /proc/sys/kernel/yama/ptrace_scope \
     setting of 1 might prevent attaching, see 'man 2 ptrace'
  (gdb)

There's no test for this as testing would require adjusting a system
wide setting.

I've linked to a semi-related bug.  It is discussing the same issue at
least.  This patch doesn't try to "fix" anything that the bug is
talking about, it just makes it (I think) slightly clearer when the
issue does arise.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31520

Approved-By: Pedro Alves <pedro@palves.net>
Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
2025-09-24 13:17:03 +01:00

493 lines
14 KiB
C

/* Linux-specific ptrace manipulation routines.
Copyright (C) 2012-2025 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "linux-ptrace.h"
#include "linux-procfs.h"
#include "linux-waitpid.h"
#ifdef HAVE_SYS_PROCFS_H
#include <sys/procfs.h>
#endif
#include "gdbsupport/eintr.h"
#include "gdbsupport/signals-state-save-restore.h"
#include "gdbsupport/gdb_file.h"
/* Stores the ptrace options supported by the running kernel.
A value of -1 means we did not check for features yet. A value
of 0 means there are no supported features. */
static int supported_ptrace_options = -1;
/* The file from which the kernel.yama.ptrace_scope setting is read. */
static constexpr char ptrace_scope_filename[]
= "/proc/sys/kernel/yama/ptrace_scope";
/* Reads the yama ptrace_scope value from /proc. Returns the integer value
of ptrace_scope (0, 1, 2, or 3) or -1 if the file cannot be read (e.g.,
yama is not enabled). */
static int
get_ptrace_scope ()
{
int ptrace_scope = -1;
/* The /proc file that contains the system-wide ptrace scope setting. */
gdb_file_up fp (fopen (ptrace_scope_filename, "r"));
if (fp != nullptr)
{
if (fscanf (fp.get (), "%d", &ptrace_scope) != 1)
{
/* If fscanf fails then we couldn't parse the number. But just
to be safe, set the scope back to -1 to indicate no value is
available. */
ptrace_scope = -1;
}
}
/* If fp is NULL, it's likely because the yama security module is not
active. In this case, we return -1 to indicate that the scope is
unknown or not applicable. */
return ptrace_scope;
}
/* Find all possible reasons we could fail to attach PID and return these
as a string. An empty string is returned if we didn't find any reason. */
std::string
linux_ptrace_attach_fail_reason (pid_t pid)
{
pid_t tracerpid = linux_proc_get_tracerpid_nowarn (pid);
std::string result;
if (tracerpid > 0)
string_appendf (result,
_("process %d is already traced by process %d"),
(int) pid, (int) tracerpid);
int ptrace_scope = get_ptrace_scope ();
if (ptrace_scope > 0)
string_appendf (result,
_("the %s setting of %d might prevent attaching, "
"see 'man 2 ptrace'"),
ptrace_scope_filename, ptrace_scope);
if (linux_proc_pid_is_zombie_nowarn (pid))
string_appendf (result,
_("process %d is a zombie - the process has already "
"terminated"),
(int) pid);
return result;
}
/* See linux-ptrace.h. */
std::string
linux_ptrace_attach_fail_reason_string (ptid_t ptid, int err)
{
long lwpid = ptid.lwp ();
std::string reason = linux_ptrace_attach_fail_reason (lwpid);
if (!reason.empty ())
return string_printf ("%s (%d), %s", safe_strerror (err), err,
reason.c_str ());
else
return string_printf ("%s (%d)", safe_strerror (err), err);
}
#if defined __i386__ || defined __x86_64__
/* Address of the 'ret' instruction in asm code block below. */
extern "C" void linux_ptrace_test_ret_to_nx_instr (void);
#include <sys/reg.h>
#include <sys/mman.h>
#include <signal.h>
#endif /* defined __i386__ || defined __x86_64__ */
/* Kill CHILD. WHO is used to report warnings. */
static void
kill_child (pid_t child, const char *who)
{
pid_t got_pid;
int kill_status;
if (kill (child, SIGKILL) != 0)
{
warning (_("%s: failed to kill child pid %ld %s"),
who, (long) child, safe_strerror (errno));
return;
}
errno = 0;
got_pid = my_waitpid (child, &kill_status, 0);
if (got_pid != child)
{
warning (_("%s: "
"kill waitpid returned %ld: %s"),
who, (long) got_pid, safe_strerror (errno));
return;
}
if (!WIFSIGNALED (kill_status))
{
warning (_("%s: "
"kill status %d is not WIFSIGNALED!"),
who, kill_status);
return;
}
}
/* Test broken off-trunk Linux kernel patchset for NX support on i386. It was
removed in Fedora kernel 88fa1f0332d188795ed73d7ac2b1564e11a0b4cd.
Test also x86_64 arch for PaX support. */
static void
linux_ptrace_test_ret_to_nx (void)
{
#if defined __i386__ || defined __x86_64__
pid_t child, got_pid;
gdb_byte *return_address, *pc;
long l;
int status;
elf_gregset_t regs;
return_address
= (gdb_byte *) mmap (NULL, 2, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
if (return_address == MAP_FAILED)
{
warning (_("linux_ptrace_test_ret_to_nx: Cannot mmap: %s"),
safe_strerror (errno));
return;
}
/* Put there 'int3'. */
*return_address = 0xcc;
child = fork ();
switch (child)
{
case -1:
warning (_("linux_ptrace_test_ret_to_nx: Cannot fork: %s"),
safe_strerror (errno));
return;
case 0:
/* Set signal handlers to their default because it doesn't make sense
to call GDB-specific handlers any more in the child process. */
restore_original_signals_state ();
l = ptrace (PTRACE_TRACEME, 0, (PTRACE_TYPE_ARG3) NULL,
(PTRACE_TYPE_ARG4) NULL);
if (l != 0)
warning (_("linux_ptrace_test_ret_to_nx: Cannot PTRACE_TRACEME: %s"),
safe_strerror (errno));
else
{
#if defined __i386__
asm volatile ("pushl %0;"
".globl linux_ptrace_test_ret_to_nx_instr;"
"linux_ptrace_test_ret_to_nx_instr:"
"ret"
: : "r" (return_address) : "memory");
#elif defined __x86_64__
asm volatile ("pushq %0;"
".globl linux_ptrace_test_ret_to_nx_instr;"
"linux_ptrace_test_ret_to_nx_instr:"
"ret"
: : "r" ((uint64_t) (uintptr_t) return_address)
: "memory");
#else
# error "!__i386__ && !__x86_64__"
#endif
gdb_assert_not_reached ("asm block did not terminate");
}
_exit (1);
}
errno = 0;
got_pid = gdb::waitpid (child, &status, 0);
if (got_pid != child)
{
warning (_("linux_ptrace_test_ret_to_nx: waitpid returned %ld: %s"),
(long) got_pid, safe_strerror (errno));
return;
}
if (WIFSIGNALED (status))
{
if (WTERMSIG (status) != SIGKILL)
warning (_("linux_ptrace_test_ret_to_nx: WTERMSIG %d is not SIGKILL!"),
(int) WTERMSIG (status));
else
warning (_("Cannot call inferior functions, Linux kernel PaX "
"protection forbids return to non-executable pages!"));
return;
}
if (!WIFSTOPPED (status))
{
warning (_("linux_ptrace_test_ret_to_nx: status %d is not WIFSTOPPED!"),
status);
kill_child (child, "linux_ptrace_test_ret_to_nx");
return;
}
/* We may get SIGSEGV due to missing PROT_EXEC of the return_address. */
if (WSTOPSIG (status) != SIGTRAP && WSTOPSIG (status) != SIGSEGV)
{
warning (_("linux_ptrace_test_ret_to_nx: "
"WSTOPSIG %d is neither SIGTRAP nor SIGSEGV!"),
(int) WSTOPSIG (status));
kill_child (child, "linux_ptrace_test_ret_to_nx");
return;
}
if (ptrace (PTRACE_GETREGS, child, (PTRACE_TYPE_ARG3) 0,
(PTRACE_TYPE_ARG4) &regs) < 0)
{
warning (_("linux_ptrace_test_ret_to_nx: Cannot PTRACE_GETREGS: %s"),
safe_strerror (errno));
}
#if defined __i386__
pc = (gdb_byte *) (uintptr_t) regs[EIP];
#elif defined __x86_64__
pc = (gdb_byte *) (uintptr_t) regs[RIP];
#else
# error "!__i386__ && !__x86_64__"
#endif
kill_child (child, "linux_ptrace_test_ret_to_nx");
/* + 1 is there as x86* stops after the 'int3' instruction. */
if (WSTOPSIG (status) == SIGTRAP && pc == return_address + 1)
{
/* PASS */
return;
}
/* We may get SIGSEGV due to missing PROT_EXEC of the RETURN_ADDRESS page. */
if (WSTOPSIG (status) == SIGSEGV && pc == return_address)
{
/* PASS */
return;
}
if ((void (*) (void)) pc != &linux_ptrace_test_ret_to_nx_instr)
warning (_("linux_ptrace_test_ret_to_nx: PC %p is neither near return "
"address %p nor is the return instruction %p!"),
pc, return_address, &linux_ptrace_test_ret_to_nx_instr);
else
warning (_("Cannot call inferior functions on this system - "
"Linux kernel with broken i386 NX (non-executable pages) "
"support detected!"));
#endif /* defined __i386__ || defined __x86_64__ */
}
/* Helper function to fork a process and make the child process call
the function FUNCTION, passing CHILD_STACK as parameter.
For MMU-less targets, clone is used instead of fork, and
CHILD_STACK is used as stack space for the cloned child. If NULL,
stack space is allocated via malloc (and subsequently passed to
FUNCTION). For MMU targets, CHILD_STACK is ignored. */
static int
linux_fork_to_function (gdb_byte *child_stack, int (*function) (void *))
{
int child_pid;
/* Sanity check the function pointer. */
gdb_assert (function != NULL);
#if defined(__UCLIBC__) && defined(HAS_NOMMU)
#define STACK_SIZE 4096
if (child_stack == NULL)
child_stack = (gdb_byte *) xmalloc (STACK_SIZE * 4);
/* Use CLONE_VM instead of fork, to support uClinux (no MMU). */
#ifdef __ia64__
child_pid = __clone2 (function, child_stack, STACK_SIZE,
CLONE_VM | SIGCHLD, child_stack + STACK_SIZE * 2);
#else /* !__ia64__ */
child_pid = clone (function, child_stack + STACK_SIZE,
CLONE_VM | SIGCHLD, child_stack + STACK_SIZE * 2);
#endif /* !__ia64__ */
#else /* !defined(__UCLIBC) && defined(HAS_NOMMU) */
child_pid = fork ();
if (child_pid == 0)
function (NULL);
#endif /* defined(__UCLIBC) && defined(HAS_NOMMU) */
if (child_pid == -1)
perror_with_name (("fork"));
return child_pid;
}
/* A helper function for linux_check_ptrace_features, called after
the parent process forks a child. The child allows itself to
be traced by its parent. */
static int
linux_child_function (void *child_stack)
{
ptrace (PTRACE_TRACEME, 0, (PTRACE_TYPE_ARG3) 0, (PTRACE_TYPE_ARG4) 0);
kill (getpid (), SIGSTOP);
/* This code is only reachable by the child (grandchild's parent)
process. */
_exit (0);
}
static void linux_test_for_exitkill (int child_pid);
/* Determine ptrace features available on this target. */
void
linux_check_ptrace_features (void)
{
int child_pid, ret, status;
/* Initialize the options. We consider that these options are always
supported. */
supported_ptrace_options
= (PTRACE_O_TRACESYSGOOD
| PTRACE_O_TRACECLONE
| PTRACE_O_TRACEFORK
| PTRACE_O_TRACEVFORK
| PTRACE_O_TRACEVFORKDONE
| PTRACE_O_TRACEEXEC);
/* Fork a child so we can do some testing. The child will call
linux_child_function and will get traced. The child will
eventually fork a grandchild so we can test fork event
reporting. */
child_pid = linux_fork_to_function (NULL, linux_child_function);
ret = my_waitpid (child_pid, &status, 0);
if (ret == -1)
perror_with_name (("waitpid"));
else if (ret != child_pid)
error (_("linux_check_ptrace_features: waitpid: unexpected result %d."),
ret);
if (! WIFSTOPPED (status))
error (_("linux_check_ptrace_features: waitpid: unexpected status %d."),
status);
linux_test_for_exitkill (child_pid);
/* Kill child_pid. */
kill_child (child_pid, "linux_check_ptrace_features");
}
/* Determine if PTRACE_O_EXITKILL can be used. */
static void
linux_test_for_exitkill (int child_pid)
{
int ret;
ret = ptrace (PTRACE_SETOPTIONS, child_pid, (PTRACE_TYPE_ARG3) 0,
(PTRACE_TYPE_ARG4) PTRACE_O_EXITKILL);
if (ret == 0)
supported_ptrace_options |= PTRACE_O_EXITKILL;
}
/* Enable reporting of all currently supported ptrace events.
OPTIONS is a bit mask of extended features we want enabled,
if supported by the kernel. PTRACE_O_TRACECLONE is always
enabled, if supported. */
void
linux_enable_event_reporting (pid_t pid, int options)
{
/* Check if we have initialized the ptrace features for this
target. If not, do it now. */
if (supported_ptrace_options == -1)
linux_check_ptrace_features ();
/* We always want clone events. */
options |= PTRACE_O_TRACECLONE;
/* Filter out unsupported options. */
options &= supported_ptrace_options;
/* Set the options. */
ptrace (PTRACE_SETOPTIONS, pid, (PTRACE_TYPE_ARG3) 0,
(PTRACE_TYPE_ARG4) (uintptr_t) options);
}
/* Disable reporting of all currently supported ptrace events. */
void
linux_disable_event_reporting (pid_t pid)
{
/* Set the options. */
ptrace (PTRACE_SETOPTIONS, pid, (PTRACE_TYPE_ARG3) 0, 0);
}
/* Display possible problems on this system. Display them only once per GDB
execution. */
void
linux_ptrace_init_warnings (void)
{
static int warned = 0;
if (warned)
return;
warned = 1;
linux_ptrace_test_ret_to_nx ();
}
/* Extract extended ptrace event from wait status. */
int
linux_ptrace_get_extended_event (int wstat)
{
return (wstat >> 16);
}
/* Determine whether wait status denotes an extended event. */
int
linux_is_extended_waitstatus (int wstat)
{
return (linux_ptrace_get_extended_event (wstat) != 0);
}
/* Return true if the event in LP may be caused by breakpoint. */
int
linux_wstatus_maybe_breakpoint (int wstat)
{
return (WIFSTOPPED (wstat)
&& (WSTOPSIG (wstat) == SIGTRAP
/* SIGILL and SIGSEGV are also treated as traps in case a
breakpoint is inserted at the current PC. */
|| WSTOPSIG (wstat) == SIGILL
|| WSTOPSIG (wstat) == SIGSEGV));
}