mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-11-16 12:34:43 +00:00
bd036f034b
This is a refactoring commit. When passing inferior arguments to gdbserver we have two actions that need to be performed, splitting and joining. On the GDB side, we take the inferior arguments, a single string, and split the string into a list of individual arguments. These are then sent to gdbserver over the remote protocol. On the gdbserver side we receive the list of individual arguments and join these back together into a single inferior argument string. In the next commit I plan to add some unit testing for this remote argument passing process. Ideally, for unit testing, we need the code being tested to be located in some easily callable function, rather than being inline at the site of use. So in this commit I propose to move the splitting and joining logic out into a separate file, we can then use this within GDB and gdbserver when passing arguments between GDB and gdbserver, but we can also call the same functions for some unit testing. In this commit I'm not adding the unit tests, they will be added next, so for now there should be no user visible changes after this commit. Tested-By: Guinevere Larsen <guinevere@redhat.com>
44 lines
1.3 KiB
C++
44 lines
1.3 KiB
C++
/* Copyright (C) 2023-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "gdbsupport/common-defs.h"
|
|
#include "gdbsupport/remote-args.h"
|
|
#include "gdbsupport/common-inferior.h"
|
|
#include "gdbsupport/buildargv.h"
|
|
|
|
/* See remote-args.h. */
|
|
|
|
std::vector<std::string>
|
|
gdb::remote_args::split (const std::string &args)
|
|
{
|
|
std::vector<std::string> results;
|
|
|
|
gdb_argv argv (args.c_str ());
|
|
for (int i = 0; argv[i] != nullptr; i++)
|
|
results.emplace_back (argv[i]);
|
|
|
|
return results;
|
|
}
|
|
|
|
/* See remote-args.h. */
|
|
|
|
std::string
|
|
gdb::remote_args::join (const std::vector<char *> &args)
|
|
{
|
|
return construct_inferior_arguments (args, true);
|
|
}
|