Files
binutils-gdb/gdbsupport
Philippe Waroquiers c801f8f138 fix leak in gdb_environ
valgrind reports a leak when assigning a gdb_environ to another gdb_environ.
The memory allocated for the target gdb_environ env variables is not released.
The gdb_environ selftest reproduces the leak (see below).
Fix the leak by clearing the target gdb_environ before std::move-ing the
members.

Tested natively and re-running all tests under valgrind.

==3261873== 4,842 bytes in 69 blocks are definitely lost in loss record 6,772 of 6,839
==3261873==    at 0x483979B: malloc (vg_replace_malloc.c:393)
==3261873==    by 0x25A454: xmalloc (alloc.c:57)
==3261873==    by 0x7D1E4E: xstrdup (xstrdup.c:34)
==3261873==    by 0x7E2A51: gdb_environ::from_host_environ() (environ.cc:56)
==3261873==    by 0x66F1C8: test_reinit_from_host_environ (environ-selftests.c:78)
==3261873==    by 0x66F1C8: selftests::gdb_environ_tests::run_tests() (environ-selftests.c:285)
==3261873==    by 0x7EFC43: operator() (std_function.h:622)
=

Approved-By: Simon Marchi <simon.marchi@efficios.com>
2022-11-27 21:08:24 +01:00
..
2022-01-18 10:14:42 -07:00
2022-08-05 08:09:57 +02:00
2022-10-09 21:27:37 -04:00
2022-11-27 21:08:24 +01:00
2022-11-13 14:46:20 +00:00
2022-11-13 14:46:20 +00:00
2022-03-03 13:06:50 -08:00
2022-01-18 10:14:43 -07:00
2022-05-10 08:15:40 -06:00
2022-05-10 08:15:40 -06:00

This is a helper library that is used by gdb and gdbserver.

To send patches, follow the gdb patch submission instructions in
../gdb/CONTRIBUTE.  For maintainers, see ../gdb/MAINTAINERS.