mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-27 09:38:57 +00:00
46cd7e0dc8
Automatically choosing "plugin" for the archive target when plugins are enabled can result in making archives as specified by the plugin target vec, ie. COFF style archives (also used by most ELF binutils targets). This is wrong for aix, hpux, vms, aout, macho and possibly other targets, if compatibility with target system archives matters. This patch removes archive support entirely from the plugin target. That means an archive will never get past bfd_check_format with a target of plugin_vec, even if it is opened using "plugin". Instead, archives will have their elements opened using the plugin target selected is such a way that the plugin target will be tried first in bfd_check_format and then continue to try other targets if that fails. The patch tries to avoid opening archives using "plugin" because that is guaranteed to fail the first target check in bfd_check_format, but mm.c still does so, and nested archives will also be opened using "plugin". The patch also fixes poor arsup.c plugin support. bfd/ * plugin.c (plugin_vec): Remove archive support. * configure.ac: Remove plugin archive warning, and don't disable plugins by default on anything but aout targets. * configure: Regenerate. binutils/ * bucomm.h (set_plugin_target): New inline function. * ar.c: Remove unneeded forward declarations. (open_inarch): Don't use "plugin" if defaulting target when opening an archive, use "plugin" when opening elements. (replace_members): Use "plugin" when opening replacement or additional elements. * arsup.c: Remove unneeded forward declarations. (plugin_target): New. (ar_open): Don't open archives using "plugin", use it when opening elements. (ar_addmod): Use plugin_target. (ar_replace): Use plugin_target when opening replacement or additional elements. (ar_extract): Don't bfd_openr. * nm.c (display_archive): Open archive elements using the "plugin" target.
104 lines
3.0 KiB
C
104 lines
3.0 KiB
C
/* bucomm.h -- binutils common include file.
|
||
Copyright (C) 1991-2025 Free Software Foundation, Inc.
|
||
|
||
This file is part of GNU Binutils.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program; if not, write to the Free Software
|
||
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
||
MA 02110-1301, USA. */
|
||
|
||
#ifndef _BUCOMM_H
|
||
#define _BUCOMM_H
|
||
|
||
/* In bucomm.c. */
|
||
|
||
/* Return the filename in a static buffer. */
|
||
const char *bfd_get_archive_filename (const bfd *);
|
||
|
||
void bfd_nonfatal (const char *);
|
||
|
||
void bfd_nonfatal_message (const char *, const bfd *, const asection *,
|
||
const char *, ...);
|
||
|
||
void bfd_fatal (const char *) ATTRIBUTE_NORETURN;
|
||
|
||
void report (const char *, va_list) ATTRIBUTE_PRINTF(1,0);
|
||
|
||
void fatal (const char *, ...) ATTRIBUTE_PRINTF_1 ATTRIBUTE_NORETURN;
|
||
|
||
void non_fatal (const char *, ...) ATTRIBUTE_PRINTF_1;
|
||
|
||
void *bfd_xalloc (bfd *, size_t);
|
||
|
||
void set_default_bfd_target (void);
|
||
|
||
void list_matching_formats (char **);
|
||
|
||
void list_supported_targets (const char *, FILE *);
|
||
|
||
void list_supported_architectures (const char *, FILE *);
|
||
|
||
int display_info (void);
|
||
|
||
void print_arelt_descr (FILE *, bfd *, bool, bool);
|
||
|
||
char *make_tempname (const char *, int *);
|
||
char *make_tempdir (const char *);
|
||
|
||
bfd_vma parse_vma (const char *, const char *);
|
||
|
||
off_t get_file_size (const char *);
|
||
|
||
bool is_valid_archive_path (char const *);
|
||
|
||
extern char *program_name;
|
||
|
||
/* In filemode.c. */
|
||
void mode_string (unsigned long, char *);
|
||
|
||
/* In version.c. */
|
||
extern void print_version (const char *);
|
||
|
||
/* In rename.c. */
|
||
extern void set_times (const char *, const struct stat *);
|
||
|
||
extern int smart_rename (const char *, const char *, int,
|
||
struct stat *, bool);
|
||
|
||
#if __GNUC__ >= 7
|
||
#define _mul_overflow(a, b, res) __builtin_mul_overflow (a, b, res)
|
||
#else
|
||
/* Assumes unsigned values. Careful! Args evaluated multiple times. */
|
||
#define _mul_overflow(a, b, res) \
|
||
((*res) = (a), (*res) *= (b), (b) != 0 && (*res) / (b) != (a))
|
||
#endif
|
||
|
||
/* Change ABFD target vector to TARG. ABFD is an archive element.
|
||
TARG is plugin_vec, or NULL if plugins are not supported. */
|
||
static inline void
|
||
set_plugin_target (bfd *abfd, const struct bfd_target *targ)
|
||
{
|
||
/* Don't change the target for archives like pdb that handle
|
||
elements specially, as detected by my_archive being NULL. */
|
||
if (abfd->my_archive && targ)
|
||
{
|
||
abfd->xvec = targ;
|
||
/* Arrange for the plugin target to be tried first in
|
||
bfd_check_format. */
|
||
abfd->target_defaulted = false;
|
||
}
|
||
}
|
||
|
||
#endif /* _BUCOMM_H */
|