Files
binutils-gdb/gdb/sh-linux-tdep.c
Simon Marchi a2e3cce344 gdb/solib: C++ify solib_ops
Convert solib_ops into an abstract base class (with abstract methods,
some of them with default implementations) and convert all the existing
solib_ops instances to solib_ops derived classes / implementations.

Prior to this patch, solib_ops is a structure holding function pointers,
of which there are only a handful of global instances (in the
`solib-*.c` files).  When passing an `solib_ops *` around, it's a
pointer to one of these instances.  After this patch, there are no more
global solib_ops instances.  Instances are created as needed and stored
in struct program_space.  These instances could eventually be made to
contain the program space-specific data, which is currently kept in
per-program space registries (I have some pending patches for that).

Prior to this patch, `gdbarch_so_ops` is a gdbarch method that returns a
pointer to the appropriate solib_ops implementation for the gdbarch.
This is replaced with the `gdbarch_make_solib_ops` method, which returns
a new instance of the appropriate solib_ops implementation for this
gdbarch.  This requires introducing some factory functions for the
various solib_ops implementation, to be used as `gdbarch_make_solib_ops`
callbacks.  For instance:

    solib_ops_up
    make_linux_ilp32_svr4_solib_ops ()
    {
      return std::make_unique<linux_ilp32_svr4_solib_ops> ();
    }

The previous code is full of cases of tdep files copying some base
solib_ops implementation, and overriding one or more function pointer
(see ppc_linux_init_abi, for instance).  I tried to convert all of this
is a class hierarchy.  I like that it's now possible to get a good
static view of all the existing solib_ops variants.  The hierarchy looks
like this:

    solib_ops
    ├── aix_solib_ops
    ├── darwin_solib_ops
    ├── dsbt_solib_ops
    ├── frv_solib_ops
    ├── rocm_solib_ops
    ├── svr4_solib_ops
    │   ├── ilp32_svr4_solib_ops
    │   ├── lp64_svr4_solib_ops
    │   ├── linux_ilp32_svr4_solib_ops
    │   │   ├── mips_linux_ilp32_svr4_solib_ops
    │   │   └── ppc_linux_ilp32_svr4_solib_ops
    │   ├── linux_lp64_svr4_solib_ops
    │   │   └── mips_linux_lp64_svr4_solib_ops
    │   ├── mips_nbsd_ilp32_svr4_solib_ops
    │   ├── mips_nbsd_lp64_svr4_solib_ops
    │   ├── mips_fbsd_ilp32_svr4_solib_ops
    │   └── mips_fbsd_lp64_svr4_solib_ops
    └── target_solib_ops
        └── windows_solib_ops

The solib-svr4 code has per-arch specialization to provide a
link_map_offsets, containing the offsets of the interesting fields in
`struct link_map` on that particular architecture.  Prior to this patch,
arches would set a callback returning the appropriate link_map_offsets
by calling `set_solib_svr4_fetch_link_map_offsets`, which also happened
to set the gdbarch's so_ops to `&svr_so_ops`.  I converted this to an
abstract virtual method of `struct svr4_solib_ops`, meaning that all
classes deriving from svr4_solib_ops must provide a method returning the
appropriate link_map_offsets for the architecture.  I renamed
`set_solib_svr4_fetch_link_map_offsets` to `set_solib_svr4_ops`.  This
function is still necessary because it also calls
set_gdbarch_iterate_over_objfiles_in_search_order, but if it was not for
that, we could get rid of it.

There is an instance of CRTP in mips-linux-tdep.c, because both
mips_linux_ilp32_svr4_solib_ops and mips_linux_lp64_svr4_solib_ops need
to derive from different SVR4 base classes (linux_ilp32_svr4_solib_ops
and linux_lp64_svr4_solib_ops), but they both want to override the
in_dynsym_resolve_code method with the same implementation.

The solib_ops::supports_namespaces method is new: the support for
namespaces was previously predicated by the presence or absence of a
find_solib_ns method.  It now needs to be explicit.

There is a new progspace::release_solib_ops method, which is only needed
for rocm_solib_ops.  For the moment, rocm_solib_ops replaces and wraps
the existing svr4_solib_ops instance, in order to combine the results of
the two.  The plan is to have a subsequent patch to allow program spaces to have
multiple solib_ops, removing the need for release_solib_ops.

Speaking of rocm_solib_ops: it previously overrode only a few methods by
copying svr4_solib_ops and overwriting some function pointers.  Now, it
needs to implement all the methods that svr4_solib_ops implements, in
order to forward the call.  Otherwise, the default solib_ops method
would be called, hiding the svr4_solib_ops implementation.  Again, this
can be removed once we have support for multiple solib_ops in a
program_space.

There is also a small change in how rocm_solib_ops is activated.  Prior
to this patch, it's done at the end of rocm_update_solib_list.  Since it
overrides the function pointer in the static svr4_solib_ops, and then
overwrites the host gdbarch, so_ops field, it's something that happens
only once.  After the patch though, we need to set rocm_solib_ops in all
the program spaces that appear.  We do this in
rocm_solib_target_inferior_created and in the new
rocm_solib_target_inferior_execd.  After this, I will explore doing a
change where rocm_solib_ops is only set when we detect the ROCm runtime
is loaded.

Change-Id: I5896b5bcbf8bdb024d67980380feba1ffefaa4c9
Approved-By: Pedro Alves <pedro@palves.net>
2025-06-26 14:08:31 -04:00

214 lines
6.3 KiB
C

/* Target-dependent code for GNU/Linux Super-H.
Copyright (C) 2005-2025 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "osabi.h"
#include "solib-svr4.h"
#include "symtab.h"
#include "trad-frame.h"
#include "tramp-frame.h"
#include "glibc-tdep.h"
#include "sh-tdep.h"
#include "linux-tdep.h"
#include "solib-svr4-linux.h"
#include "gdbarch.h"
#define REGSx16(base) \
{(base), 0}, \
{(base) + 1, 4}, \
{(base) + 2, 8}, \
{(base) + 3, 12}, \
{(base) + 4, 16}, \
{(base) + 5, 20}, \
{(base) + 6, 24}, \
{(base) + 7, 28}, \
{(base) + 8, 32}, \
{(base) + 9, 36}, \
{(base) + 10, 40}, \
{(base) + 11, 44}, \
{(base) + 12, 48}, \
{(base) + 13, 52}, \
{(base) + 14, 56}, \
{(base) + 15, 60}
/* Describe the contents of the .reg section of the core file. */
static const struct sh_corefile_regmap gregs_table[] =
{
REGSx16 (R0_REGNUM),
{PC_REGNUM, 64},
{PR_REGNUM, 68},
{SR_REGNUM, 72},
{GBR_REGNUM, 76},
{MACH_REGNUM, 80},
{MACL_REGNUM, 84},
{-1 /* Terminator. */, 0}
};
/* Describe the contents of the .reg2 section of the core file. */
static const struct sh_corefile_regmap fpregs_table[] =
{
REGSx16 (FR0_REGNUM),
/* REGSx16 xfp_regs omitted. */
{FPSCR_REGNUM, 128},
{FPUL_REGNUM, 132},
{-1 /* Terminator. */, 0}
};
/* SH signal handler frame support. */
static void
sh_linux_sigtramp_cache (const frame_info_ptr &this_frame,
struct trad_frame_cache *this_cache,
CORE_ADDR func, int regs_offset)
{
int i;
struct gdbarch *gdbarch = get_frame_arch (this_frame);
CORE_ADDR base = get_frame_register_unsigned (this_frame,
gdbarch_sp_regnum (gdbarch));
CORE_ADDR regs = base + regs_offset;
for (i = 0; i < 18; i++)
trad_frame_set_reg_addr (this_cache, i, regs + i * 4);
trad_frame_set_reg_addr (this_cache, SR_REGNUM, regs + 18 * 4);
trad_frame_set_reg_addr (this_cache, GBR_REGNUM, regs + 19 * 4);
trad_frame_set_reg_addr (this_cache, MACH_REGNUM, regs + 20 * 4);
trad_frame_set_reg_addr (this_cache, MACL_REGNUM, regs + 21 * 4);
/* Restore FP state if we have an FPU. */
if (gdbarch_fp0_regnum (gdbarch) != -1)
{
CORE_ADDR fpregs = regs + 22 * 4;
for (i = FR0_REGNUM; i <= FP_LAST_REGNUM; i++)
trad_frame_set_reg_addr (this_cache, i, fpregs + i * 4);
trad_frame_set_reg_addr (this_cache, FPSCR_REGNUM, fpregs + 32 * 4);
trad_frame_set_reg_addr (this_cache, FPUL_REGNUM, fpregs + 33 * 4);
}
/* Save a frame ID. */
trad_frame_set_id (this_cache, frame_id_build (base, func));
}
/* Implement struct tramp_frame "init" callbacks for signal
trampolines on 32-bit SH. */
static void
sh_linux_sigreturn_init (const struct tramp_frame *self,
const frame_info_ptr &this_frame,
struct trad_frame_cache *this_cache,
CORE_ADDR func)
{
/* SH 32-bit sigframe: sigcontext at start of sigframe,
registers start after a single 'oldmask' word. */
sh_linux_sigtramp_cache (this_frame, this_cache, func, 4);
}
static void
sh_linux_rt_sigreturn_init (const struct tramp_frame *self,
const frame_info_ptr &this_frame,
struct trad_frame_cache *this_cache,
CORE_ADDR func)
{
/* SH 32-bit rt_sigframe: starts with a siginfo (128 bytes), then
we can find sigcontext embedded within a ucontext (offset 20 bytes).
Then registers start after a single 'oldmask' word. */
sh_linux_sigtramp_cache (this_frame, this_cache, func,
128 /* sizeof (struct siginfo) */
+ 20 /* offsetof (struct ucontext, uc_mcontext) */
+ 4 /* oldmask word at start of sigcontext */);
}
/* Instruction patterns. */
#define SH_MOVW 0x9305
#define SH_TRAP 0xc300
#define SH_OR_R0_R0 0x200b
/* SH sigreturn syscall numbers. */
#define SH_NR_SIGRETURN 0x0077
#define SH_NR_RT_SIGRETURN 0x00ad
static struct tramp_frame sh_linux_sigreturn_tramp_frame = {
SIGTRAMP_FRAME,
2,
{
{ SH_MOVW, 0xffff },
{ SH_TRAP, 0xff00 }, /* #imm argument part filtered out. */
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_NR_SIGRETURN, 0xffff },
{ TRAMP_SENTINEL_INSN }
},
sh_linux_sigreturn_init
};
static struct tramp_frame sh_linux_rt_sigreturn_tramp_frame = {
SIGTRAMP_FRAME,
2,
{
{ SH_MOVW, 0xffff },
{ SH_TRAP, 0xff00 }, /* #imm argument part filtered out. */
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_OR_R0_R0, 0xffff },
{ SH_NR_RT_SIGRETURN, 0xffff },
{ TRAMP_SENTINEL_INSN }
},
sh_linux_rt_sigreturn_init
};
static void
sh_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
linux_init_abi (info, gdbarch, 0);
/* GNU/Linux uses SVR4-style shared libraries. */
set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
set_solib_svr4_ops (gdbarch, make_linux_ilp32_svr4_solib_ops);
set_gdbarch_skip_solib_resolver (gdbarch, glibc_skip_solib_resolver);
set_gdbarch_fetch_tls_load_module_address (gdbarch,
svr4_fetch_objfile_link_map);
sh_gdbarch_tdep *tdep = gdbarch_tdep<sh_gdbarch_tdep> (gdbarch);
/* Remember regset characteristics. The sizes should match
elf_gregset_t and elf_fpregset_t from Linux. */
tdep->core_gregmap = (struct sh_corefile_regmap *) gregs_table;
tdep->sizeof_gregset = 92;
tdep->core_fpregmap = (struct sh_corefile_regmap *) fpregs_table;
tdep->sizeof_fpregset = 136;
tramp_frame_prepend_unwinder (gdbarch, &sh_linux_sigreturn_tramp_frame);
tramp_frame_prepend_unwinder (gdbarch, &sh_linux_rt_sigreturn_tramp_frame);
}
INIT_GDB_FILE (sh_linux_tdep)
{
gdbarch_register_osabi (bfd_arch_sh, 0, GDB_OSABI_LINUX, sh_linux_init_abi);
}