mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-05 15:15:42 +00:00
At the beginning of a session, gdb may attempt to download debuginfo for all shared libraries associated with the process or core file being debugged. This can be a waste of time and storage space when much of the debuginfo ends up not being used during the session. To reduce the gdb's startup latency and to download only the debuginfo that is really needed, this patch adds on-demand, a.k.a lazy, downloading. When 'set debuginfo enabled lazy' is on, gdb will attempt to download a .gdb_index for each shared library instead of its full debuginfo. Each debuginfo download will be deferred until gdb needs to expand symtabs associated with the debuginfo's index. Additionally, all separate debug objfiles are placed in objfiles_list after their parent, instead of before. This ensures that any deferred debuginfo downloaded during iteration over objfiles_list aren't skipped by the loop. I also modified objfiles_safe so that it returns a safe reverse iterator. Reverse iteration prevents iterator invalidation by ensuring that separate debug objfiles are deleted before their parent objfile.
64 lines
2.0 KiB
C++
64 lines
2.0 KiB
C++
/* A range adapter that wraps begin / end iterators.
|
|
Copyright (C) 2021-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDBSUPPORT_ITERATOR_RANGE_H
|
|
#define GDBSUPPORT_ITERATOR_RANGE_H
|
|
|
|
/* A wrapper that allows using ranged for-loops on a range described by two
|
|
iterators. */
|
|
|
|
template <typename IteratorType>
|
|
struct iterator_range
|
|
{
|
|
using iterator = IteratorType;
|
|
|
|
/* Create an iterator_range using BEGIN as the begin iterator.
|
|
|
|
Assume that the end iterator can be default-constructed. */
|
|
template <typename... Args>
|
|
iterator_range (Args &&...args)
|
|
: m_begin (std::forward<Args> (args)...)
|
|
{}
|
|
|
|
/* Create an iterator range using explicit BEGIN and END iterators. */
|
|
template <typename... Args>
|
|
iterator_range (IteratorType begin, IteratorType end)
|
|
: m_begin (std::move (begin)), m_end (std::move (end))
|
|
{}
|
|
|
|
/* Need these as the variadic constructor would be a better match
|
|
otherwise. */
|
|
iterator_range (iterator_range &) = default;
|
|
iterator_range (const iterator_range &) = default;
|
|
iterator_range (iterator_range &&) = default;
|
|
|
|
IteratorType begin () const
|
|
{ return m_begin; }
|
|
|
|
IteratorType end () const
|
|
{ return m_end; }
|
|
|
|
/* The number of items in this iterator_range. */
|
|
std::size_t size () const
|
|
{ return std::distance (m_begin, m_end); }
|
|
|
|
private:
|
|
IteratorType m_begin, m_end;
|
|
};
|
|
#endif /* GDBSUPPORT_ITERATOR_RANGE_H */
|