mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-05 15:15:42 +00:00
3719472095
PR ada/33217 points out that gdb incorrectly calls the <ctype.h>
functions. In particular, gdb feels free to pass a 'char' like:
char *str = ...;
... isdigit (*str)
This is incorrect as isdigit only accepts EOF and values that can be
represented as 'unsigned char' -- that is, a cast is needed here to
avoid undefined behavior when 'char' is signed and a character in the
string might be sign-extended. (As an aside, I think this API seems
obviously bad, but unfortunately this is what the standard says, and
some systems check this.)
Rather than adding casts everywhere, this changes all the code in gdb
that uses any <ctype.h> API to instead call the corresponding c-ctype
function.
Now, c-ctype has some limitations compared to <ctype.h>. It works as
if the C locale is in effect, so in theory some non-ASCII characters
may be misclassified. This would only affect a subset of character
sets, though, and in most places I think ASCII is sufficient -- for
example the many places in gdb that check for whitespace.
Furthermore, in practice most users are using UTF-8-based locales,
where these functions aren't really informative for non-ASCII
characters anyway; see the existing workarounds in gdb/c-support.h.
Note that safe-ctype.h cannot be used because it causes conflicts with
readline.h. And, we canot poison the <ctype.h> identifiers as this
provokes errors from some libstdc++ headers.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33217
Approved-By: Simon Marchi <simon.marchi@efficios.com>
70 lines
1.8 KiB
C
70 lines
1.8 KiB
C
/* Things needed for both reading and writing DWARF indices.
|
|
|
|
Copyright (C) 1994-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "dwarf2/index-common.h"
|
|
|
|
/* See dwarf-index-common.h. */
|
|
|
|
hashval_t
|
|
mapped_index_string_hash (int index_version, const void *p)
|
|
{
|
|
const unsigned char *str = (const unsigned char *) p;
|
|
hashval_t r = 0;
|
|
unsigned char c;
|
|
|
|
while ((c = *str++) != 0)
|
|
{
|
|
if (index_version >= 5)
|
|
c = c_tolower (c);
|
|
r = r * 67 + c - 113;
|
|
}
|
|
|
|
return r;
|
|
}
|
|
|
|
/* See dwarf-index-common.h. */
|
|
|
|
uint32_t
|
|
dwarf5_djb_hash (const char *str_)
|
|
{
|
|
const unsigned char *str = (const unsigned char *) str_;
|
|
|
|
/* Note: c_tolower here ignores UTF-8, which isn't fully compliant.
|
|
See http://dwarfstd.org/ShowIssue.php?issue=161027.1. */
|
|
|
|
uint32_t hash = 5381;
|
|
while (int c = *str++)
|
|
hash = hash * 33 + c_tolower (c);
|
|
return hash;
|
|
}
|
|
|
|
/* See dwarf-index-common.h. */
|
|
|
|
uint32_t
|
|
dwarf5_djb_hash (std::string_view str)
|
|
{
|
|
/* Note: c_tolower here ignores UTF-8, which isn't fully compliant.
|
|
See http://dwarfstd.org/ShowIssue.php?issue=161027.1. */
|
|
|
|
uint32_t hash = 5381;
|
|
for (char c : str)
|
|
hash = hash * 33 + c_tolower (c & 0xff);
|
|
return hash;
|
|
}
|