Files
binutils-gdb/gdb/nat/linux-procfs.c
Andrew Burgess 0850800ff0 gdb: only use /proc/PID/exe for local f/s with no sysroot
This commit works around a problem introduced by commit:

  commit e58beedf2c
  Date:   Tue Jan 23 16:00:59 2024 +0000

      gdb: attach to a process when the executable has been deleted

The above commit extended GDB for Linux, so that, of the executable
for a process had been deleted, GDB would instead try to use
/proc/PID/exe as the executable.

This worked by updating linux_proc_pid_to_exec_file to introduce the
/proc/PID/exe fallback.  However, the result of
linux_proc_pid_to_exec_file is then passed to exec_file_find to
actually find the executable, and exec_file_find, will take into
account the sysroot.  In addition, if GDB is attaching to a process in
a different MNT and/or PID namespace then the executable lookup is
done within that namespace.

This all means two things:

  1. Just because linux_proc_pid_to_exec_file cannot see the
     executable doesn't mean that GDB is actually going to fail to
     find the executable, and

  2. returning /proc/PID/exe isn't useful if we know GDB is then going
     to look for this within a sysroot, or within some other
     namespace (where PIDs might be different).

There was an initial attempt to fix this issue here:

  https://inbox.sourceware.org/gdb-patches/20250511141517.2455092-4-kilger@sec.in.tum.de/

This proposal addresses the issue in PR gdb/32955, which is all about
the namespace side of the problem.  The fix in this original proposal
is to check the MNT namespace inside linux_proc_pid_to_exec_file, and
for the namespace problem this is fine.  But we should also consider
the sysroot problem.

And for the sysroot problem, the fix cannot fully live inside
linux_proc_pid_to_exec_file, as linux_proc_pid_to_exec_file is shared
between GDB and gdbserver, and gdbserver has no sysroot.

And so, I propose a slightly bigger change.

Now, linux_proc_pid_to_exec_file takes a flag which indicates if
GDB (or gdbserver) will look for the inferior executable in the
local file system, where local means the same file system as GDB (or
gdbserver) is running in.

This local file system check is true if:

  1. The MNT namespace of the inferior is the same as for GDB, and

  2. for GDB only, the sysroot must either be empty, or 'target:'.

If the local file system check is false then GDB (or gdbserver) is
going to look elsewhere for the inferior executable, and so, falling
back to /proc/PID/exe should not be done, as GDB will end up looking
for this file in the sysroot, or within the alternative MNT
namespace (which in also likely to be a different PID namespace).

Now this is all a bit of a shame really.  It would be nice if
linux_proc_pid_to_exec_file could return /proc/PID/exe in such a way
that exec_file_find would know that the file should NOT be looked for
in the sysroot, or in the alternative namespace.  But fixing that
problem would be a much bigger change, so for now lets just disable
the /proc/PID/exe fallback for cases where it might not work.

For testing, the sysroot case is now tested.

I don't believe we have any alternative namespace testing.  It would
certainly be interesting to add some, but I'm not proposing any with
this patch, so the code for checking the MNT namespace has been tested
manually by me, but isn't covered by a new test I'm adding here.

Author of the original fix is listed as co-author here.  Credit for
identifying the original problem, and proposing a solution belongs to
them.

Co-Authored-By: Fabian Kilger <kilger@sec.in.tum.de>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32955
2025-06-23 14:47:27 +01:00

486 lines
12 KiB
C

/* Linux-specific PROCFS manipulation routines.
Copyright (C) 2009-2025 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "linux-procfs.h"
#include "gdbsupport/filestuff.h"
#include "gdbsupport/unordered_set.h"
#include <dirent.h>
#include <sys/stat.h>
#include <utility>
/* Return the TGID of LWPID from /proc/pid/status. Returns -1 if not
found. */
static int
linux_proc_get_int (pid_t lwpid, const char *field, int warn)
{
size_t field_len = strlen (field);
char buf[100];
int retval = -1;
snprintf (buf, sizeof (buf), "/proc/%d/status", (int) lwpid);
gdb_file_up status_file = gdb_fopen_cloexec (buf, "r");
if (status_file == NULL)
{
if (warn)
warning (_("unable to open /proc file '%s'"), buf);
return -1;
}
while (fgets (buf, sizeof (buf), status_file.get ()))
if (strncmp (buf, field, field_len) == 0 && buf[field_len] == ':')
{
retval = strtol (&buf[field_len + 1], NULL, 10);
break;
}
return retval;
}
/* Return the TGID of LWPID from /proc/pid/status. Returns -1 if not
found. */
int
linux_proc_get_tgid (pid_t lwpid)
{
return linux_proc_get_int (lwpid, "Tgid", 1);
}
/* See linux-procfs.h. */
pid_t
linux_proc_get_tracerpid_nowarn (pid_t lwpid)
{
return linux_proc_get_int (lwpid, "TracerPid", 0);
}
/* Process states as discovered in the 'State' line of
/proc/PID/status. Not all possible states are represented here,
only those that we care about. */
enum proc_state
{
/* Some state we don't handle. */
PROC_STATE_UNKNOWN,
/* Stopped on a signal. */
PROC_STATE_STOPPED,
/* Tracing stop. */
PROC_STATE_TRACING_STOP,
/* Dead. */
PROC_STATE_DEAD,
/* Zombie. */
PROC_STATE_ZOMBIE,
};
/* Parse a PROC_STATE out of STATE, a buffer with the state found in
the 'State:' line of /proc/PID/status. */
static enum proc_state
parse_proc_status_state (const char *state)
{
state = skip_spaces (state);
switch (state[0])
{
case 't':
return PROC_STATE_TRACING_STOP;
case 'T':
/* Before Linux 2.6.33, tracing stop used uppercase T. */
if (strcmp (state, "T (stopped)\n") == 0)
return PROC_STATE_STOPPED;
else /* "T (tracing stop)\n" */
return PROC_STATE_TRACING_STOP;
case 'X':
return PROC_STATE_DEAD;
case 'Z':
return PROC_STATE_ZOMBIE;
}
return PROC_STATE_UNKNOWN;
}
/* Fill in STATE, a buffer with BUFFER_SIZE bytes with the 'State'
line of /proc/PID/status. Returns -1 on failure to open the /proc
file, 1 if the line is found, and 0 if not found. If WARN, warn on
failure to open the /proc file. */
static int
linux_proc_pid_get_state (pid_t pid, int warn, enum proc_state *state)
{
int have_state;
char buffer[100];
xsnprintf (buffer, sizeof (buffer), "/proc/%d/status", (int) pid);
gdb_file_up procfile = gdb_fopen_cloexec (buffer, "r");
if (procfile == NULL)
{
if (warn)
warning (_("unable to open /proc file '%s'"), buffer);
return -1;
}
have_state = 0;
while (fgets (buffer, sizeof (buffer), procfile.get ()) != NULL)
if (startswith (buffer, "State:"))
{
have_state = 1;
*state = parse_proc_status_state (buffer + sizeof ("State:") - 1);
break;
}
return have_state;
}
/* See linux-procfs.h declaration. */
int
linux_proc_pid_is_gone (pid_t pid)
{
int have_state;
enum proc_state state;
have_state = linux_proc_pid_get_state (pid, 0, &state);
if (have_state < 0)
{
/* If we can't open the status file, assume the thread has
disappeared. */
return 1;
}
else if (have_state == 0)
{
/* No "State:" line, assume thread is alive. */
return 0;
}
else
return (state == PROC_STATE_ZOMBIE || state == PROC_STATE_DEAD);
}
/* Return non-zero if 'State' of /proc/PID/status contains STATE. If
WARN, warn on failure to open the /proc file. */
static int
linux_proc_pid_has_state (pid_t pid, enum proc_state state, int warn)
{
int have_state;
enum proc_state cur_state;
have_state = linux_proc_pid_get_state (pid, warn, &cur_state);
return (have_state > 0 && cur_state == state);
}
/* Detect `T (stopped)' in `/proc/PID/status'.
Other states including `T (tracing stop)' are reported as false. */
int
linux_proc_pid_is_stopped (pid_t pid)
{
return linux_proc_pid_has_state (pid, PROC_STATE_STOPPED, 1);
}
/* Detect `t (tracing stop)' in `/proc/PID/status'.
Other states including `T (stopped)' are reported as false. */
int
linux_proc_pid_is_trace_stopped_nowarn (pid_t pid)
{
return linux_proc_pid_has_state (pid, PROC_STATE_TRACING_STOP, 1);
}
/* Return non-zero if PID is a zombie. If WARN, warn on failure to
open the /proc file. */
static int
linux_proc_pid_is_zombie_maybe_warn (pid_t pid, int warn)
{
return linux_proc_pid_has_state (pid, PROC_STATE_ZOMBIE, warn);
}
/* See linux-procfs.h declaration. */
int
linux_proc_pid_is_zombie_nowarn (pid_t pid)
{
return linux_proc_pid_is_zombie_maybe_warn (pid, 0);
}
/* See linux-procfs.h declaration. */
int
linux_proc_pid_is_zombie (pid_t pid)
{
return linux_proc_pid_is_zombie_maybe_warn (pid, 1);
}
/* See linux-procfs.h. */
std::optional<std::string>
linux_proc_get_stat_field (ptid_t ptid, int field)
{
/* We never need to read PID from the stat file, and there's
command_from_pid to read the comm field. */
gdb_assert (field >= LINUX_PROC_STAT_STATE);
std::string filename = string_printf ("/proc/%ld/task/%ld/stat",
(long) ptid.pid (), (long) ptid.lwp ());
std::optional<std::string> content
= read_text_file_to_string (filename.c_str ());
if (!content.has_value ())
return {};
/* ps command also relies on no trailing fields ever containing ')'. */
std::string::size_type pos = content->find_last_of (')');
if (pos == std::string::npos)
return {};
/* The first field after program name is LINUX_PROC_STAT_STATE. */
for (int i = LINUX_PROC_STAT_STATE; i <= field; ++i)
{
/* Find separator. */
pos = content->find_first_of (' ', pos);
if (pos == std::string::npos)
return {};
/* Find beginning of field. */
pos = content->find_first_not_of (' ', pos);
if (pos == std::string::npos)
return {};
}
/* Find end of field. */
std::string::size_type end_pos = content->find_first_of (' ', pos);
if (end_pos == std::string::npos)
return content->substr (pos);
else
return content->substr (pos, end_pos - pos);
}
/* Get the start time of thread PTID. */
static std::optional<ULONGEST>
linux_proc_get_starttime (ptid_t ptid)
{
std::optional<std::string> field
= linux_proc_get_stat_field (ptid, LINUX_PROC_STAT_STARTTIME);
if (!field.has_value ())
return {};
errno = 0;
const char *trailer;
ULONGEST starttime = strtoulst (field->c_str (), &trailer, 10);
if (starttime == ULONGEST_MAX && errno == ERANGE)
return {};
else if (*trailer != '\0')
/* There were unexpected characters. */
return {};
return starttime;
}
/* See linux-procfs.h. */
const char *
linux_proc_tid_get_name (ptid_t ptid)
{
#define TASK_COMM_LEN 16 /* As defined in the kernel's sched.h. */
static char comm_buf[TASK_COMM_LEN];
char comm_path[100];
const char *comm_val;
pid_t pid = ptid.pid ();
pid_t tid = ptid.lwp_p () ? ptid.lwp () : ptid.pid ();
xsnprintf (comm_path, sizeof (comm_path),
"/proc/%ld/task/%ld/comm", (long) pid, (long) tid);
gdb_file_up comm_file = gdb_fopen_cloexec (comm_path, "r");
if (comm_file == NULL)
return NULL;
comm_val = fgets (comm_buf, sizeof (comm_buf), comm_file.get ());
if (comm_val != NULL)
{
int i;
/* Make sure there is no newline at the end. */
for (i = 0; i < sizeof (comm_buf); i++)
{
if (comm_buf[i] == '\n')
{
comm_buf[i] = '\0';
break;
}
}
}
return comm_val;
}
/* See linux-procfs.h. */
void
linux_proc_attach_tgid_threads (pid_t pid,
linux_proc_attach_lwp_func attach_lwp)
{
char pathname[128];
int new_threads_found;
int iterations;
if (linux_proc_get_tgid (pid) != pid)
return;
xsnprintf (pathname, sizeof (pathname), "/proc/%ld/task", (long) pid);
gdb_dir_up dir (opendir (pathname));
if (dir == NULL)
{
warning (_("Could not open %s."), pathname);
return;
}
/* Keeps track of the LWPs we have already visited in /proc,
identified by their PID and starttime to detect PID reuse. */
gdb::unordered_set<std::pair<unsigned long, ULONGEST>> visited_lwps;
/* Scan the task list for existing threads. While we go through the
threads, new threads may be spawned. Cycle through the list of
threads until we have done two iterations without finding new
threads. */
for (iterations = 0; iterations < 2; iterations++)
{
struct dirent *dp;
new_threads_found = 0;
while ((dp = readdir (dir.get ())) != NULL)
{
unsigned long lwp;
/* Fetch one lwp. */
lwp = strtoul (dp->d_name, NULL, 10);
if (lwp != 0)
{
ptid_t ptid = ptid_t (pid, lwp);
std::optional<ULONGEST> starttime
= linux_proc_get_starttime (ptid);
if (starttime.has_value ())
{
std::pair<unsigned long, ULONGEST> key (lwp, *starttime);
/* If we already visited this LWP, skip it this time. */
if (visited_lwps.find (key) != visited_lwps.cend ())
continue;
visited_lwps.insert (key);
}
if (attach_lwp (ptid))
new_threads_found = 1;
}
}
if (new_threads_found)
{
/* Start over. */
iterations = -1;
}
rewinddir (dir.get ());
}
}
/* See linux-procfs.h. */
int
linux_proc_task_list_dir_exists (pid_t pid)
{
char pathname[128];
struct stat buf;
xsnprintf (pathname, sizeof (pathname), "/proc/%ld/task", (long) pid);
return (stat (pathname, &buf) == 0);
}
/* See linux-procfs.h. */
const char *
linux_proc_pid_to_exec_file (int pid, bool is_local_fs)
{
static char buf[PATH_MAX];
char name[PATH_MAX];
ssize_t len;
xsnprintf (name, PATH_MAX, "/proc/%d/exe", pid);
len = readlink (name, buf, PATH_MAX - 1);
if (len <= 0)
strcpy (buf, name);
else
buf[len] = '\0';
/* If the inferior and GDB can see the same filesystem, and NAME
cannot be read, maybe the file has been deleted, then we can
potentially use /proc/PID/exe instead.
GDB always interprets the results of this function within the
current sysroot (which is 'target:' by default). This means
that, if we return /proc/PID/exe, GDB will try to find this file
within the sysroot.
This doesn't make sense if GDB is using a sysroot like:
'/some/random/directory/', not only is it possible that NAME
could be found within the sysroot, it is unlikely that
/proc/PID/exe will exist within the sysroot.
Similarly, if the sysroot is 'target:', but the inferior is
running within a separate MNT namespace, then it is more than
likely that the inferior will also be running in a separate PID
namespace, in this case PID is the pid on the host system,
/proc/PID/exe will not be correct within the inferiors MNT/PID
namespace.
So, we can fallback to use /proc/PID/exe only if IS_LOCAL_FS is
true, this indicates that GDB and the inferior are using the same
MNT namespace, and GDB's sysroot is either empty, or 'target:'. */
if (is_local_fs && access (buf, R_OK) != 0 && access (name, R_OK) == 0)
strcpy (buf, name);
return buf;
}
/* See linux-procfs.h. */
void
linux_proc_init_warnings ()
{
static bool warned = false;
if (warned)
return;
warned = true;
struct stat st;
if (stat ("/proc/self", &st) != 0)
warning (_("/proc is not accessible."));
}