mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-26 17:18:55 +00:00
e2f620135d
This commit makes two changes to how we match newline characters in the gdb_test proc. First, for the newline pattern between the command output and the prompt, I propose changing from '[\r\n]+' to an explicit '\r\n'. The old pattern would spot multiple newlines, and so there are a few places where, as part of this commit, I've needed to add an extra trailing '\r\n' to the pattern in the main test file, where GDB's output actually includes a blank line. But I think this is a good thing. If a command produces a blank line then we should be checking for it, the current gdb_test doesn't do that. But also, with the current gdb_test, if a blank line suddenly appears in the output, this is going to be silently ignored, and I think this is wrong, the test should fail in that case. Additionally, the existing pattern will happily match a partial newline. There are a strangely large number of tests that end with a random '.' character. Not matching a literal period, but matching any single character, this is then matching half of the trailing newline sequence, while the \[\r\n\]+ in gdb_test is matching the other half of the sequence. I can think of no reason why this would be intentional, I suspect that the expected output at one time included a period, which has since been remove, but I haven't bothered to check on this. In this commit I've removed all these unneeded trailing '.' characters. The basic rule of gdb_test after this is that the expected pattern needs to match everything up to, but not including the newline sequence immediately before the GDB prompt. This is generally how the proc is used anyway, so in almost all cases, this commit represents no significant change. Second, while I was cleaning up newline matching in gdb_test, I've also removed the '[\r\n]*' that was added to the start of the pattern passed to gdb_test_multiple. The addition of this pattern adds no value. If the user pattern matches at the start of a line then this would match against the newline sequence. But, due to the '*', if the user pattern doesn't match at the start of a line then this group doesn't care, it'll happily match nothing. As such, there's no value to it, it just adds more complexity for no gain, so I'm removing it. No tests will need updating as a consequence of this part of the patch. Reviewed-By: Tom Tromey <tom@tromey.com>
239 lines
8.8 KiB
Plaintext
239 lines
8.8 KiB
Plaintext
# Copyright 2008-2023 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the GDB testsuite.
|
|
# This test tests the restoration of various kinds of machine state
|
|
# to their original values by reverse execution. We will execute
|
|
# the program forward while it changes various types of data, and
|
|
# then execute it backward to see if their values get restored.
|
|
#
|
|
# The types of machine state (data) that are tested are:
|
|
# register variable
|
|
# auto variable
|
|
# function static variable
|
|
# module static variable
|
|
# module global variable
|
|
#
|
|
# TODO:
|
|
# various, possibly including...
|
|
# .bss variable, .data variable, ...
|
|
# shared library variable
|
|
# heap variable (pointer)...
|
|
# overlay variables...
|
|
# Test forward replay
|
|
#
|
|
|
|
require supports_reverse
|
|
|
|
standard_testfile .c ms1.c
|
|
|
|
if { [prepare_for_testing "failed to prepare" $testfile \
|
|
[list $srcfile $srcfile2]] } {
|
|
return -1
|
|
}
|
|
|
|
set newline "\[\r\n\]+"
|
|
|
|
set beginmain [gdb_get_line_number " begin main " $srcfile]
|
|
set endmain [gdb_get_line_number " end main " $srcfile]
|
|
|
|
# Test begins
|
|
|
|
runto_main
|
|
|
|
if [supports_process_record] {
|
|
# Activate process record/replay
|
|
gdb_test_no_output "record" "turn on process record"
|
|
}
|
|
|
|
# Proceed to end of main
|
|
|
|
gdb_test "break $endmain" \
|
|
"Breakpoint.* file .*$srcfile, line $endmain.*" \
|
|
"break at end of main"
|
|
gdb_continue_to_breakpoint "end of main" ".*$srcfile:$endmain.*"
|
|
|
|
###
|
|
###
|
|
###
|
|
|
|
# Now run backward to each of several points where data is changed.
|
|
#
|
|
|
|
# Module global variable, reverse
|
|
with_test_prefix "module global variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_global_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print aglobal" " = 0" "module global reverse-breakpoint"
|
|
gdb_test "step" " module global post-change .*"
|
|
gdb_test "print aglobal" " = 1" "module global forward past bp"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print aglobal" " = 0" "module global reverse-step to bp"
|
|
}
|
|
|
|
# Module static variable, reverse
|
|
with_test_prefix "module static variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print astatic" " = 0" "module static reverse-breakpoint"
|
|
gdb_test "step" " module static post-change .*"
|
|
gdb_test "print astatic" " = 1" "module static forward"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print astatic" " = 0" "module static reverse-step"
|
|
}
|
|
|
|
# Function static variable, reverse
|
|
with_test_prefix "function static variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"function_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print a" " = 0" "function static reverse-breakpoint"
|
|
gdb_test "step" " function static post-change .*"
|
|
gdb_test "print a" " = 1" "function static forward"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print a" " = 0" "function static reverse-step"
|
|
}
|
|
|
|
# Auto variable, reverse
|
|
with_test_prefix "auto variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"auto_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print a" " = 0" "auto var reverse-breakpoint"
|
|
gdb_test "step" " auto post-change .*"
|
|
gdb_test "print a" " = 1" "auto var forward"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print a" " = 0" "auto var reverse-step"
|
|
}
|
|
|
|
# Register variable, reverse
|
|
with_test_prefix "register variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"register_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print a" " = 0" "register var reverse-breakpoint"
|
|
gdb_test "step" " register post-change .*"
|
|
gdb_test "print a" " = 1" "register var step post-change"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print a" " = 0" \
|
|
"register var reverse step-to, first time"
|
|
}
|
|
|
|
# Proceed to beginning of main
|
|
|
|
gdb_test "tbreak $beginmain" "$srcfile, line $beginmain.*"
|
|
gdb_test "reverse-continue" "$srcfile:$beginmain.*" "reverse to main"
|
|
|
|
# Now repeat tests while replaying forward.
|
|
|
|
# Register variable, forward
|
|
|
|
with_test_prefix "register variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"register_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print a" " = 0" "register var forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print a" " = 0" "register var forward step-to"
|
|
gdb_test "step" " register post-change .*" "step, 2"
|
|
gdb_test "print a" " = 1" \
|
|
"register var step post-change, second time"
|
|
}
|
|
|
|
# Auto variable, forward
|
|
with_test_prefix "auto variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"auto_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print a" " = 0" "auto var forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print a" " = 0" "auto var forward step-to"
|
|
gdb_test "step" " auto post-change .*" "step, 2"
|
|
gdb_test "print a" " = 1" "auto var step post-change"
|
|
}
|
|
|
|
# Function static variable, forward
|
|
with_test_prefix "function static variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"function_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print a" " = 0" "function static forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print a" " = 0" "function static forward step-to"
|
|
gdb_test "step" " function static post-change .*" "step, 2"
|
|
gdb_test "print a" " = 1" "function static step post-change"
|
|
}
|
|
|
|
# Module static variable, forward
|
|
with_test_prefix "module static variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print astatic" " = 0" "module static forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print astatic" " = 0" "module static forward step-to"
|
|
gdb_test "step" " module static post-change .*" "step, 2"
|
|
gdb_test "print astatic" " = 1" "module static step post-change"
|
|
}
|
|
|
|
# Module global variable, forward
|
|
with_test_prefix "module global variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_global_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print aglobal" " = 0" "module global forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print aglobal" " = 0" "module global forward step-to"
|
|
gdb_test "step" " module global post-change .*" "step, 2"
|
|
gdb_test "print aglobal" " = 1" "module global step post-change"
|
|
}
|