Files
binutils-gdb/ld/libdep_plugin.c
H.J. Lu 7e432e93f8 Limit BFD_SUPPORTS_PLUGINS check to plugin.h and targets.c
Minimize the BFD_SUPPORTS_PLUGINS check to make code more readable and
maintainable by:

1. Update bfd/plugin.h to define plugin functions as static inline if
BFD_SUPPORTS_PLUGINS is 0.
2. Remove BFD_SUPPORTS_PLUGINS check from all bfd and binutils files
except plugin.h and targets.c.
3. Replace the remaining BFD_SUPPORTS_PLUGINS checks with a function so
that plugin availability is checked at run time.

bfd/

	* archive.c: Include plugin.h unconditionally.
	(_bfd_compute_and_write_armap): Remove the BFD_SUPPORTS_PLUGINS
	check.
	* bfd-in.h (bfd_plugin_enabled): New.
	* bfd-in2.h: Regenerated.
	* elflink.c: Include plugin.h unconditionally.
	(elf_link_is_defined_archive_symbol): Remove the
	BFD_SUPPORTS_PLUGINS check.
	* format.c: Include plugin.h unconditionally.
	(bfd_set_lto_type): Remove the BFD_SUPPORTS_PLUGINS check.
	(bfd_check_format_matches): Replace the BFD_SUPPORTS_PLUGINS
	check with the bfd_plugin_enabled call.  Replace plugin_vec
	with bfd_plugin_vec.  Remove the BFD_SUPPORTS_PLUGINS check.
	* plugin.c (bfd_plugin_target_p): Removed.
	* plugin.h (bfd_plugin_vec): New.
	(bfd_plugin_target_p): Likewise.
	(bfd_plugin_set_program_name): New.  Static inline
	function if BFD_SUPPORTS_PLUGINS is 0.
	(bfd_plugin_open_input): Likewise.
	(bfd_plugin_set_plugin): Likewise.
	(bfd_link_plugin_object_p): Likewise.
	(register_ld_plugin_object_p): Likewise.
	(bfd_plugin_close_file_descriptor): Likewise.
	(bfd_plugin_vec): Likewise.
	(bfd_plugin_target_p): Likewise.
	* xtensa-dynconfig.c (xtensa_load_config): Replace the
	BFD_SUPPORTS_PLUGINS check with the bfd_plugin_enabled call.

ar/

	* ar.c: Include plugin.h unconditionally.
	(plugin_target): Removed.
	(usage): Replace the BFD_SUPPORTS_PLUGINS check with the
	bfd_plugin_enabled call.
	(ranlib_usage): Likewise.
	(decode_options): Likewise.
	(ranlib_main): Likewise.
	(main): Call bfd_plugin_set_program_name unconditionally.
	* nm.c: Include plugin.h unconditionally.
	(plugin_target): Removed.
	(usage): Replace the BFD_SUPPORTS_PLUGINS check with the
	bfd_plugin_enabled call.
	(filter_symbols): Remove the BFD_SUPPORTS_PLUGINS check.
	(display_rel_file): Likewise.
	(main): Call bfd_plugin_set_program_name unconditionally.  Replace
	the BFD_SUPPORTS_PLUGINS check with the bfd_plugin_enabled call.
	* objcopy.c: Include plugin.h unconditionally.
	(strip_usage): Replace the BFD_SUPPORTS_PLUGINS check with the
	bfd_plugin_enabled call.
	(copy_archive): Remove the BFD_SUPPORTS_PLUGINS check.  Replace
	BFD_SUPPORTS_PLUGINS with the bfd_plugin_enabled call.
	(copy_file): Likewise.
	(strip_main): Likewise.

ld/

	* ldfile.c: Include plugin.h unconditionally.
	(ldfile_try_open_bfd): Remove the BFD_SUPPORTS_PLUGINS check.
	* ldlang.c: Include plugin.h unconditionally.
	(plugin_insert): Remove the BFD_SUPPORTS_PLUGINS check.
	(plugin_undefs): Likewise.
	(open_input_bfds): Likewise.
	(lang_check): Likewise.
	(lang_gc_sections): Likewise.
	(find_next_input_statement): Likewise.
	(lang_process): Likewise.
	* ldlang.h (lang_input_statement_flags): Likewise.
	* ldlex.h (option_values): Likewise.
	* ldmain.c: Include plugin.h unconditionally.
	(ld_cleanup): Remove the BFD_SUPPORTS_PLUGINS check.
	(main): Likewise.
	(add_archive_element): Likewise.
	* lexsup.c: Include plugin.h unconditionally.
	(ld_options): Remove the BFD_SUPPORTS_PLUGINS check.
	(parse_args): Replace the BFD_SUPPORTS_PLUGINS check with the
	bfd_plugin_enabled call.  Remove the BFD_SUPPORTS_PLUGINS check.
	(help): Append " (ignored)" to plugin options if bfd_plugin_enabled
	return false.
	* libdep_plugin.c: Remove the BFD_SUPPORTS_PLUGINS check.
	* plugin.c: Likewise.
	* testplug.c: Likewise.
	* testplug2.c: Likewise.
	* testplug3.c: Likewise.
	* testplug4.c: Likewise.

Co-Authored-By: Alan Modra <amodra@gmail.com>
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
2025-08-18 17:05:43 -07:00

342 lines
7.3 KiB
C

/* libdeps plugin for the GNU linker.
Copyright (C) 2020-2025 Free Software Foundation, Inc.
This file is part of the GNU Binutils.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
MA 02110-1301, USA. */
#include "sysdep.h"
#include "bfd.h"
#include "plugin-api.h"
#include <ctype.h> /* For isspace. */
extern enum ld_plugin_status onload (struct ld_plugin_tv *tv);
/* Helper for calling plugin api message function. */
#define TV_MESSAGE if (tv_message) (*tv_message)
/* Function pointers to cache hooks passed at onload time. */
static ld_plugin_register_claim_file tv_register_claim_file = 0;
static ld_plugin_register_all_symbols_read tv_register_all_symbols_read = 0;
static ld_plugin_register_cleanup tv_register_cleanup = 0;
static ld_plugin_message tv_message = 0;
static ld_plugin_add_input_library tv_add_input_library = 0;
static ld_plugin_set_extra_library_path tv_set_extra_library_path = 0;
/* Handle/record information received in a transfer vector entry. */
static enum ld_plugin_status
parse_tv_tag (struct ld_plugin_tv *tv)
{
#define SETVAR(x) x = tv->tv_u.x
switch (tv->tv_tag)
{
case LDPT_REGISTER_CLAIM_FILE_HOOK:
SETVAR(tv_register_claim_file);
break;
case LDPT_REGISTER_ALL_SYMBOLS_READ_HOOK:
SETVAR(tv_register_all_symbols_read);
break;
case LDPT_REGISTER_CLEANUP_HOOK:
SETVAR(tv_register_cleanup);
break;
case LDPT_MESSAGE:
SETVAR(tv_message);
break;
case LDPT_ADD_INPUT_LIBRARY:
SETVAR(tv_add_input_library);
break;
case LDPT_SET_EXTRA_LIBRARY_PATH:
SETVAR(tv_set_extra_library_path);
break;
default:
break;
}
#undef SETVAR
return LDPS_OK;
}
/* Defs for archive parsing. */
#define ARMAGSIZE 8
typedef struct arhdr
{
char ar_name[16];
char ar_date[12];
char ar_uid[6];
char ar_gid[6];
char ar_mode[8];
char ar_size[10];
char ar_fmag[2];
} arhdr;
typedef struct linerec
{
struct linerec *next;
char line[];
} linerec;
#define LIBDEPS "__.LIBDEP/ "
static linerec *line_head, **line_tail = &line_head;
static enum ld_plugin_status
get_libdeps (int fd)
{
arhdr ah;
int len;
unsigned long mlen;
size_t amt;
linerec *lr;
enum ld_plugin_status rc = LDPS_NO_SYMS;
lseek (fd, ARMAGSIZE, SEEK_SET);
for (;;)
{
len = read (fd, (void *) &ah, sizeof (ah));
if (len != sizeof (ah))
break;
mlen = strtoul (ah.ar_size, NULL, 10);
if (!mlen || strncmp (ah.ar_name, LIBDEPS, sizeof (LIBDEPS)-1))
{
lseek (fd, mlen, SEEK_CUR);
continue;
}
amt = mlen + sizeof (linerec);
if (amt <= mlen)
return LDPS_ERR;
lr = malloc (amt);
if (!lr)
return LDPS_ERR;
lr->next = NULL;
len = read (fd, lr->line, mlen);
lr->line[mlen-1] = '\0';
*line_tail = lr;
line_tail = &lr->next;
rc = LDPS_OK;
break;
}
return rc;
}
/* Parse arguments in-place as contiguous C-strings
and return the number of arguments. */
static int
parse_libdep (char *str)
{
char *src, *dst;
char quote;
int narg;
src = dst = str;
for (; isspace ((unsigned char) *src); ++src)
;
if (*src == '\0')
return 0;
narg = 1;
quote = 0;
while (*src)
{
if (*src == '\'' || *src == '\"')
{
if (!quote)
quote = *src++;
else if (*src == quote)
{
++src;
quote = 0;
}
else
*dst++ = *src++;
}
else if (!quote && isspace ((unsigned char) *src))
{
++narg;
++src;
*dst++ = '\0';
for (; isspace ((unsigned char) *src); ++src);
}
else
*dst++ = *src++;
}
*dst = '\0';
if (quote)
{
TV_MESSAGE (LDPL_WARNING,
"libdep syntax error: unterminated quoted string");
return 0;
}
return narg;
}
static char *prevfile;
/* Standard plugin API registerable hook. */
static enum ld_plugin_status
onclaim_file (const struct ld_plugin_input_file *file, int *claimed)
{
enum ld_plugin_status rv;
*claimed = 0;
/* If we've already seen this file, ignore it. */
if (prevfile && !strcmp (file->name, prevfile))
return LDPS_OK;
/* If it's not an archive member, ignore it. */
if (!file->offset)
return LDPS_OK;
if (prevfile)
free (prevfile);
prevfile = strdup (file->name);
if (!prevfile)
return LDPS_ERR;
/* This hook only gets called on actual object files.
We have to examine the archive ourselves, to find
our LIBDEPS member. */
rv = get_libdeps (file->fd);
if (rv == LDPS_ERR)
return rv;
if (rv == LDPS_OK)
{
linerec *lr = (linerec *)line_tail;
/* Inform the user/testsuite. */
TV_MESSAGE (LDPL_INFO, "got deps for library %s: %s",
file->name, lr->line);
fflush (NULL);
}
return LDPS_OK;
}
/* Standard plugin API registerable hook. */
static enum ld_plugin_status
onall_symbols_read (void)
{
linerec *lr;
int nargs;
char const *arg;
enum ld_plugin_status rv = LDPS_OK;
while ((lr = line_head))
{
line_head = lr->next;
nargs = parse_libdep (lr->line);
arg = lr->line;
int i;
for (i = 0; i < nargs; i++, arg = strchr (arg, '\0') + 1)
{
if (arg[0] != '-')
{
TV_MESSAGE (LDPL_WARNING, "ignoring libdep argument %s", arg);
fflush (NULL);
continue;
}
if (arg[1] == 'l')
rv = tv_add_input_library (arg + 2);
else if (arg[1] == 'L')
rv = tv_set_extra_library_path (arg + 2);
else
{
TV_MESSAGE (LDPL_WARNING, "ignoring libdep argument %s", arg);
fflush (NULL);
}
if (rv != LDPS_OK)
break;
}
free (lr);
}
line_tail = NULL;
return rv;
}
/* Standard plugin API registerable hook. */
static enum ld_plugin_status
oncleanup (void)
{
if (prevfile)
{
free (prevfile);
prevfile = NULL;
}
if (line_head)
{
linerec *lr;
while ((lr = line_head))
{
line_head = lr->next;
free (lr);
}
line_tail = NULL;
}
return LDPS_OK;
}
/* Standard plugin API entry point. */
enum ld_plugin_status
onload (struct ld_plugin_tv *tv)
{
enum ld_plugin_status rv;
/* This plugin requires a valid tv array. */
if (!tv)
return LDPS_ERR;
/* First entry should always be LDPT_MESSAGE, letting us get
hold of it easily so we can send output straight away. */
if (tv[0].tv_tag == LDPT_MESSAGE)
tv_message = tv[0].tv_u.tv_message;
do
if ((rv = parse_tv_tag (tv)) != LDPS_OK)
return rv;
while ((tv++)->tv_tag != LDPT_NULL);
/* Register hooks. */
if (tv_register_claim_file
&& tv_register_all_symbols_read
&& tv_register_cleanup)
{
(*tv_register_claim_file) (onclaim_file);
(*tv_register_all_symbols_read) (onall_symbols_read);
(*tv_register_cleanup) (oncleanup);
}
fflush (NULL);
return LDPS_OK;
}