Files
binutils-gdb/gdb/tic6x-linux-tdep.c
Simon Marchi a2e3cce344 gdb/solib: C++ify solib_ops
Convert solib_ops into an abstract base class (with abstract methods,
some of them with default implementations) and convert all the existing
solib_ops instances to solib_ops derived classes / implementations.

Prior to this patch, solib_ops is a structure holding function pointers,
of which there are only a handful of global instances (in the
`solib-*.c` files).  When passing an `solib_ops *` around, it's a
pointer to one of these instances.  After this patch, there are no more
global solib_ops instances.  Instances are created as needed and stored
in struct program_space.  These instances could eventually be made to
contain the program space-specific data, which is currently kept in
per-program space registries (I have some pending patches for that).

Prior to this patch, `gdbarch_so_ops` is a gdbarch method that returns a
pointer to the appropriate solib_ops implementation for the gdbarch.
This is replaced with the `gdbarch_make_solib_ops` method, which returns
a new instance of the appropriate solib_ops implementation for this
gdbarch.  This requires introducing some factory functions for the
various solib_ops implementation, to be used as `gdbarch_make_solib_ops`
callbacks.  For instance:

    solib_ops_up
    make_linux_ilp32_svr4_solib_ops ()
    {
      return std::make_unique<linux_ilp32_svr4_solib_ops> ();
    }

The previous code is full of cases of tdep files copying some base
solib_ops implementation, and overriding one or more function pointer
(see ppc_linux_init_abi, for instance).  I tried to convert all of this
is a class hierarchy.  I like that it's now possible to get a good
static view of all the existing solib_ops variants.  The hierarchy looks
like this:

    solib_ops
    ├── aix_solib_ops
    ├── darwin_solib_ops
    ├── dsbt_solib_ops
    ├── frv_solib_ops
    ├── rocm_solib_ops
    ├── svr4_solib_ops
    │   ├── ilp32_svr4_solib_ops
    │   ├── lp64_svr4_solib_ops
    │   ├── linux_ilp32_svr4_solib_ops
    │   │   ├── mips_linux_ilp32_svr4_solib_ops
    │   │   └── ppc_linux_ilp32_svr4_solib_ops
    │   ├── linux_lp64_svr4_solib_ops
    │   │   └── mips_linux_lp64_svr4_solib_ops
    │   ├── mips_nbsd_ilp32_svr4_solib_ops
    │   ├── mips_nbsd_lp64_svr4_solib_ops
    │   ├── mips_fbsd_ilp32_svr4_solib_ops
    │   └── mips_fbsd_lp64_svr4_solib_ops
    └── target_solib_ops
        └── windows_solib_ops

The solib-svr4 code has per-arch specialization to provide a
link_map_offsets, containing the offsets of the interesting fields in
`struct link_map` on that particular architecture.  Prior to this patch,
arches would set a callback returning the appropriate link_map_offsets
by calling `set_solib_svr4_fetch_link_map_offsets`, which also happened
to set the gdbarch's so_ops to `&svr_so_ops`.  I converted this to an
abstract virtual method of `struct svr4_solib_ops`, meaning that all
classes deriving from svr4_solib_ops must provide a method returning the
appropriate link_map_offsets for the architecture.  I renamed
`set_solib_svr4_fetch_link_map_offsets` to `set_solib_svr4_ops`.  This
function is still necessary because it also calls
set_gdbarch_iterate_over_objfiles_in_search_order, but if it was not for
that, we could get rid of it.

There is an instance of CRTP in mips-linux-tdep.c, because both
mips_linux_ilp32_svr4_solib_ops and mips_linux_lp64_svr4_solib_ops need
to derive from different SVR4 base classes (linux_ilp32_svr4_solib_ops
and linux_lp64_svr4_solib_ops), but they both want to override the
in_dynsym_resolve_code method with the same implementation.

The solib_ops::supports_namespaces method is new: the support for
namespaces was previously predicated by the presence or absence of a
find_solib_ns method.  It now needs to be explicit.

There is a new progspace::release_solib_ops method, which is only needed
for rocm_solib_ops.  For the moment, rocm_solib_ops replaces and wraps
the existing svr4_solib_ops instance, in order to combine the results of
the two.  The plan is to have a subsequent patch to allow program spaces to have
multiple solib_ops, removing the need for release_solib_ops.

Speaking of rocm_solib_ops: it previously overrode only a few methods by
copying svr4_solib_ops and overwriting some function pointers.  Now, it
needs to implement all the methods that svr4_solib_ops implements, in
order to forward the call.  Otherwise, the default solib_ops method
would be called, hiding the svr4_solib_ops implementation.  Again, this
can be removed once we have support for multiple solib_ops in a
program_space.

There is also a small change in how rocm_solib_ops is activated.  Prior
to this patch, it's done at the end of rocm_update_solib_list.  Since it
overrides the function pointer in the static svr4_solib_ops, and then
overwrites the host gdbarch, so_ops field, it's something that happens
only once.  After the patch though, we need to set rocm_solib_ops in all
the program spaces that appear.  We do this in
rocm_solib_target_inferior_created and in the new
rocm_solib_target_inferior_execd.  After this, I will explore doing a
change where rocm_solib_ops is only set when we detect the ROCm runtime
is loaded.

Change-Id: I5896b5bcbf8bdb024d67980380feba1ffefaa4c9
Approved-By: Pedro Alves <pedro@palves.net>
2025-06-26 14:08:31 -04:00

211 lines
6.9 KiB
C

/* GNU/Linux on TI C6x target support.
Copyright (C) 2011-2025 Free Software Foundation, Inc.
Contributed by Yao Qi <yao@codesourcery.com>
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "solib.h"
#include "osabi.h"
#include "linux-tdep.h"
#include "tic6x-tdep.h"
#include "trad-frame.h"
#include "tramp-frame.h"
#include "elf-bfd.h"
#include "elf/tic6x.h"
#include "gdbarch.h"
#include "solib-dsbt.h"
/* The offset from rt_sigframe pointer to SP register. */
#define TIC6X_SP_RT_SIGFRAME 8
/* Size of struct siginfo info. */
#define TIC6X_SIGINFO_SIZE 128
/* Size of type stack_t, which contains three fields of type void*, int, and
size_t respectively. */
#define TIC6X_STACK_T_SIZE (3 * 4)
static const gdb_byte tic6x_bkpt_bnop_be[] = { 0x00, 0x00, 0xa1, 0x22 };
static const gdb_byte tic6x_bkpt_bnop_le[] = { 0x22, 0xa1, 0x00, 0x00 };
/* Return the offset of register REGNUM in struct sigcontext. Return 0 if no
such register in sigcontext. */
static unsigned int
tic6x_register_sigcontext_offset (unsigned int regnum, struct gdbarch *gdbarch)
{
tic6x_gdbarch_tdep *tdep = gdbarch_tdep<tic6x_gdbarch_tdep> (gdbarch);
if (regnum == TIC6X_A4_REGNUM || regnum == TIC6X_A4_REGNUM + 2
|| regnum == TIC6X_A4_REGNUM + 4)
return 4 * (regnum - TIC6X_A4_REGNUM + 2); /* A4, A6, A8 */
else if (regnum == TIC6X_A5_REGNUM || regnum == TIC6X_A5_REGNUM + 2
|| regnum == TIC6X_A5_REGNUM + 4)
return 4 * (regnum - TIC6X_A5_REGNUM + 12); /* A5, A7, A9 */
else if (regnum == TIC6X_B4_REGNUM || regnum == TIC6X_B4_REGNUM + 2
|| regnum == TIC6X_B4_REGNUM + 4)
return 4 * (regnum - TIC6X_B4_REGNUM + 3); /* B4, B6, B8 */
else if (regnum == TIC6X_B5_REGNUM || regnum == TIC6X_B5_REGNUM + 2
|| regnum == TIC6X_B5_REGNUM + 4)
return 4 * (regnum - TIC6X_B5_REGNUM + 19); /* B5, B7, B9 */
else if (regnum < TIC6X_A4_REGNUM)
return 4 * (regnum - 0 + 8); /* A0 - A3 */
else if (regnum >= TIC6X_B0_REGNUM && regnum < TIC6X_B4_REGNUM)
return 4 * (regnum - TIC6X_B0_REGNUM + 15); /* B0 - B3 */
else if (regnum >= 34 && regnum < 34 + 32)
return 4 * (regnum - 34 + 23); /* A16 - A31, B16 - B31 */
else if (regnum == TIC6X_PC_REGNUM)
return 4 * (tdep->has_gp ? 55 : 23);
else if (regnum == TIC6X_SP_REGNUM)
return 4;
return 0;
}
/* Support unwinding frame in signal trampoline. We don't check sigreturn,
since it is not used in kernel. */
static void
tic6x_linux_rt_sigreturn_init (const struct tramp_frame *self,
const frame_info_ptr &this_frame,
struct trad_frame_cache *this_cache,
CORE_ADDR func)
{
struct gdbarch *gdbarch = get_frame_arch (this_frame);
CORE_ADDR sp = get_frame_register_unsigned (this_frame, TIC6X_SP_REGNUM);
/* The base of struct sigcontext is computed by examining the definition of
struct rt_sigframe in linux kernel source arch/c6x/kernel/signal.c. */
CORE_ADDR base = (sp + TIC6X_SP_RT_SIGFRAME
/* Pointer type *pinfo and *puc in struct rt_sigframe. */
+ 4 + 4
+ TIC6X_SIGINFO_SIZE
+ 4 + 4 /* uc_flags and *uc_link in struct ucontext. */
+ TIC6X_STACK_T_SIZE);
tic6x_gdbarch_tdep *tdep = gdbarch_tdep<tic6x_gdbarch_tdep> (gdbarch);
unsigned int reg_offset;
unsigned int i;
for (i = 0; i < 10; i++) /* A0 - A9 */
{
reg_offset = tic6x_register_sigcontext_offset (i, gdbarch);
gdb_assert (reg_offset != 0);
trad_frame_set_reg_addr (this_cache, i, base + reg_offset);
}
for (i = TIC6X_B0_REGNUM; i < TIC6X_B0_REGNUM + 10; i++) /* B0 - B9 */
{
reg_offset = tic6x_register_sigcontext_offset (i, gdbarch);
gdb_assert (reg_offset != 0);
trad_frame_set_reg_addr (this_cache, i, base + reg_offset);
}
if (tdep->has_gp)
for (i = 34; i < 34 + 32; i++) /* A16 - A31, B16 - B31 */
{
reg_offset = tic6x_register_sigcontext_offset (i, gdbarch);
gdb_assert (reg_offset != 0);
trad_frame_set_reg_addr (this_cache, i, base + reg_offset);
}
trad_frame_set_reg_addr (this_cache, TIC6X_PC_REGNUM,
base + tic6x_register_sigcontext_offset (TIC6X_PC_REGNUM,
gdbarch));
trad_frame_set_reg_addr (this_cache, TIC6X_SP_REGNUM,
base + tic6x_register_sigcontext_offset (TIC6X_SP_REGNUM,
gdbarch));
/* Save a frame ID. */
trad_frame_set_id (this_cache, frame_id_build (sp, func));
}
static struct tramp_frame tic6x_linux_rt_sigreturn_tramp_frame =
{
SIGTRAMP_FRAME,
4,
{
{0x000045aa, 0x0fffffff}, /* mvk .S2 139,b0 */
{0x10000000, ULONGEST_MAX}, /* swe */
{TRAMP_SENTINEL_INSN}
},
tic6x_linux_rt_sigreturn_init
};
/* When FRAME is at a syscall instruction, return the PC of the next
instruction to be executed. */
static CORE_ADDR
tic6x_linux_syscall_next_pc (const frame_info_ptr &frame)
{
ULONGEST syscall_number = get_frame_register_unsigned (frame,
TIC6X_B0_REGNUM);
CORE_ADDR pc = get_frame_pc (frame);
if (syscall_number == 139 /* rt_sigreturn */)
return frame_unwind_caller_pc (frame);
return pc + 4;
}
static void
tic6x_uclinux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
tic6x_gdbarch_tdep *tdep = gdbarch_tdep<tic6x_gdbarch_tdep> (gdbarch);
linux_init_abi (info, gdbarch, 0);
/* Shared library handling. */
set_gdbarch_make_solib_ops (gdbarch, make_dsbt_solib_ops);
tdep->syscall_next_pc = tic6x_linux_syscall_next_pc;
#ifdef HAVE_ELF
/* In tic6x Linux kernel, breakpoint instructions varies on different archs.
On C64x+ and C67x+, breakpoint instruction is 0x56454314, which is an
illegal opcode. On other arch, breakpoint instruction is 0x0000a122
(BNOP .S2 0,5). */
if (info.abfd)
switch (bfd_elf_get_obj_attr_int (info.abfd, OBJ_ATTR_PROC, Tag_ISA))
{
case C6XABI_Tag_ISA_C64XP:
case C6XABI_Tag_ISA_C67XP:
if (info.byte_order == BFD_ENDIAN_BIG)
tdep->breakpoint = tic6x_bkpt_illegal_opcode_be;
else
tdep->breakpoint = tic6x_bkpt_illegal_opcode_le;
break;
default:
{
if (info.byte_order == BFD_ENDIAN_BIG)
tdep->breakpoint = tic6x_bkpt_bnop_be;
else
tdep->breakpoint = tic6x_bkpt_bnop_le;
}
}
#endif
/* Signal trampoline support. */
tramp_frame_prepend_unwinder (gdbarch,
&tic6x_linux_rt_sigreturn_tramp_frame);
}
INIT_GDB_FILE (tic6x_linux_tdep)
{
gdbarch_register_osabi (bfd_arch_tic6x, 0, GDB_OSABI_LINUX,
tic6x_uclinux_init_abi);
}