mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-28 10:00:51 +00:00
25902bd0ba
Commits: commitaaad5a3254Author: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 3 commit2e61486fceAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 2 commit202beb3feeAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 1 were made to work around the changes to clean_restart in commit: commitcba778b944Date: Sun Sep 7 11:53:30 2025 +0200 [gdb/testsuite] Error out on clean_restart <absolute filename> These commits added a lot of calls to gdb_load which can be removed in many cases by passing $testfile to clean_restart, or by switching to use prepare_for_testing to compile the test executable. In this commit I've gone through the gdb.base/ directory and removed as many of the gdb_load calls as possible. I was only looking for places where the gdb_load call immediately follows the call to clean_restart. And I did skip a few where it was not as simple as just passing $testfile. Where possible I've updated tests to use calls to prepare_for_testing, and simply removed the clean_restart call altogether (this is done as part of prepare_for_testing). This is, I think, the best solution. In other cases I've removed the gdb_load call, and passed $testfile to clean_restart. I've preferred $::testfile to adding a 'global' declaration, and in some cases switching to testfile has allowed me to remove the 'global binfile' as an additional cleanup. I ran the complete set of tests that I touched and I didn't see any regressions, so I don't believe I broke anything. I know that there are probably gdb_load calls that can be cleaned up in other testsuite sub-directories, if/when this patch is merged I'll take a look at those too. Reviewed-By: Tom de Vries <tdevries@suse.de>
58 lines
2.0 KiB
Plaintext
58 lines
2.0 KiB
Plaintext
# Copyright 2023-2025 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test corner case of printing solib name when unwinding.
|
|
# https://sourceware.org/bugzilla/show_bug.cgi?id=29074
|
|
|
|
require allow_shlib_tests
|
|
|
|
# Library file.
|
|
set libname "solib-abort-lib"
|
|
set srcfile_lib ${srcdir}/${subdir}/${libname}.c
|
|
set binfile_lib [standard_output_file ${libname}.so]
|
|
# Note: no debugging info here, since this will assure that the solib
|
|
# name is printed in the stack trace.
|
|
set lib_flags {shlib}
|
|
|
|
# Binary file.
|
|
set testfile "solib-abort"
|
|
set srcfile ${srcdir}/${subdir}/${testfile}.c
|
|
set binfile [standard_output_file ${testfile}]
|
|
set bin_flags [list debug shlib=${binfile_lib}]
|
|
|
|
if { [build_executable "build solib" $binfile_lib $srcfile_lib \
|
|
$lib_flags] != 0 } {
|
|
return
|
|
}
|
|
|
|
if { [prepare_for_testing "prepare" $testfile $srcfile $bin_flags] != 0 } {
|
|
return
|
|
}
|
|
|
|
if {![runto_main]} {
|
|
return 0
|
|
}
|
|
|
|
# Run until the program dies.
|
|
gdb_test "cont" "Program received signal SIGABRT,.*"
|
|
|
|
# The solib name should show up in the stack trace. The bug here was
|
|
# that if the function calling abort appeared last in the text
|
|
# section, and if GCC didn't emit an epilogue after the call, then gdb
|
|
# would use the wrong PC to find the solib name. This test doesn't
|
|
# exactly test this in all situations, but with the correct
|
|
# environment it is sufficient.
|
|
gdb_test "bt" "#$decimal .* in callee .* from .*${libname}\\.so.*"
|