mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-26 17:18:55 +00:00
25902bd0ba
Commits: commitaaad5a3254Author: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 3 commit2e61486fceAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 2 commit202beb3feeAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 1 were made to work around the changes to clean_restart in commit: commitcba778b944Date: Sun Sep 7 11:53:30 2025 +0200 [gdb/testsuite] Error out on clean_restart <absolute filename> These commits added a lot of calls to gdb_load which can be removed in many cases by passing $testfile to clean_restart, or by switching to use prepare_for_testing to compile the test executable. In this commit I've gone through the gdb.base/ directory and removed as many of the gdb_load calls as possible. I was only looking for places where the gdb_load call immediately follows the call to clean_restart. And I did skip a few where it was not as simple as just passing $testfile. Where possible I've updated tests to use calls to prepare_for_testing, and simply removed the clean_restart call altogether (this is done as part of prepare_for_testing). This is, I think, the best solution. In other cases I've removed the gdb_load call, and passed $testfile to clean_restart. I've preferred $::testfile to adding a 'global' declaration, and in some cases switching to testfile has allowed me to remove the 'global binfile' as an additional cleanup. I ran the complete set of tests that I touched and I didn't see any regressions, so I don't believe I broke anything. I know that there are probably gdb_load calls that can be cleaned up in other testsuite sub-directories, if/when this patch is merged I'll take a look at those too. Reviewed-By: Tom de Vries <tdevries@suse.de>
53 lines
1.7 KiB
Plaintext
53 lines
1.7 KiB
Plaintext
# Copyright 2016-2025 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test an inferior function call which execs a new program.
|
|
# This is a test for breakpoints/19546.
|
|
|
|
standard_testfile
|
|
|
|
set testfile2 "infcall-exec2"
|
|
set srcfile2 "${testfile2}.c"
|
|
set binfile2 [standard_output_file $testfile2]
|
|
|
|
# Build the two executables for the test.
|
|
if {[build_executable "build exec'd file" $testfile2 $srcfile2] != 0} {
|
|
return -1
|
|
}
|
|
|
|
if {[prepare_for_testing "prepare" $testfile $srcfile] != 0} {
|
|
return -1
|
|
}
|
|
|
|
if { [is_remote target] } {
|
|
set binfile2 [gdb_remote_download target $binfile2]
|
|
}
|
|
|
|
if {![runto_main]} {
|
|
return -1
|
|
}
|
|
|
|
set linenr [gdb_get_line_number "break here"]
|
|
gdb_breakpoint $linenr
|
|
gdb_continue_to_breakpoint "Ensure PATH is set" ".* break here .*"
|
|
|
|
set expected_result "process $decimal is executing new program: \[^\r\n\]*$binfile2"
|
|
append expected_result "\[\r\n\]+.*"
|
|
append expected_result "Breakpoint 1, main .*at .*$srcfile2:$decimal"
|
|
append expected_result ".*"
|
|
|
|
gdb_test "call (int) execlp \(\"$binfile2\", \"$binfile2\", \(char \*\)0\)" \
|
|
$expected_result "call execlp"
|