mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-27 01:28:46 +00:00
25902bd0ba
Commits: commitaaad5a3254Author: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 3 commit2e61486fceAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 2 commit202beb3feeAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 1 were made to work around the changes to clean_restart in commit: commitcba778b944Date: Sun Sep 7 11:53:30 2025 +0200 [gdb/testsuite] Error out on clean_restart <absolute filename> These commits added a lot of calls to gdb_load which can be removed in many cases by passing $testfile to clean_restart, or by switching to use prepare_for_testing to compile the test executable. In this commit I've gone through the gdb.base/ directory and removed as many of the gdb_load calls as possible. I was only looking for places where the gdb_load call immediately follows the call to clean_restart. And I did skip a few where it was not as simple as just passing $testfile. Where possible I've updated tests to use calls to prepare_for_testing, and simply removed the clean_restart call altogether (this is done as part of prepare_for_testing). This is, I think, the best solution. In other cases I've removed the gdb_load call, and passed $testfile to clean_restart. I've preferred $::testfile to adding a 'global' declaration, and in some cases switching to testfile has allowed me to remove the 'global binfile' as an additional cleanup. I ran the complete set of tests that I touched and I didn't see any regressions, so I don't believe I broke anything. I know that there are probably gdb_load calls that can be cleaned up in other testsuite sub-directories, if/when this patch is merged I'll take a look at those too. Reviewed-By: Tom de Vries <tdevries@suse.de>
148 lines
5.1 KiB
Plaintext
148 lines
5.1 KiB
Plaintext
# Copyright 2002-2025 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file was written by Michael Snyder (msnyder@redhat.com)
|
|
# This is a test for the gdb command "generate-core-file".
|
|
|
|
require gcore_cmd_available
|
|
|
|
standard_testfile
|
|
|
|
if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
|
|
return -1
|
|
}
|
|
|
|
if {![runto_main]} {
|
|
return -1
|
|
}
|
|
|
|
gdb_test "break terminal_func" "Breakpoint .* at .*${srcfile}, line .*" \
|
|
"set breakpoint at terminal_func"
|
|
|
|
gdb_test "continue" "Breakpoint .* terminal_func.*" \
|
|
"continue to terminal_func"
|
|
|
|
set print_prefix ".\[0123456789\]* = "
|
|
|
|
set pre_corefile_backtrace [capture_command_output "backtrace" ""]
|
|
set pre_corefile_regs [capture_command_output "info registers" ""]
|
|
set pre_corefile_allregs [capture_command_output "info all-reg" ""]
|
|
set pre_corefile_sysregs [capture_command_output "info reg system" ""]
|
|
set pre_corefile_static_array \
|
|
[capture_command_output "print static_array" "$print_prefix"]
|
|
set pre_corefile_uninit_array \
|
|
[capture_command_output "print un_initialized_array" "$print_prefix"]
|
|
set pre_corefile_heap_string \
|
|
[capture_command_output "print heap_string" "$print_prefix"]
|
|
set pre_corefile_local_array \
|
|
[capture_command_output "print array_func::local_array" "$print_prefix"]
|
|
set pre_corefile_extern_array \
|
|
[capture_command_output "print extern_array" "$print_prefix"]
|
|
|
|
set corefile [standard_output_file gcore.test]
|
|
set core_supported [gdb_gcore_cmd "$corefile" "save a corefile"]
|
|
if {!$core_supported} {
|
|
return -1
|
|
}
|
|
|
|
# Now restart gdb and load the corefile.
|
|
clean_restart $testfile
|
|
|
|
set core_loaded [gdb_core_cmd "$corefile" "re-load generated corefile"]
|
|
if { $core_loaded == -1 } {
|
|
# No use proceeding from here.
|
|
return
|
|
}
|
|
|
|
gdb_test_sequence "where" "where in corefile" {
|
|
"\[\r\n\]+#0 .* terminal_func \\(\\) at "
|
|
"\[\r\n\]+#1 .* array_func \\(\\) at "
|
|
"\[\r\n\]+#2 .* factorial_func \\(value=1\\) at "
|
|
"\[\r\n\]+#3 .* factorial_func \\(value=2\\) at "
|
|
"\[\r\n\]+#4 .* factorial_func \\(value=3\\) at "
|
|
"\[\r\n\]+#5 .* factorial_func \\(value=4\\) at "
|
|
"\[\r\n\]+#6 .* factorial_func \\(value=5\\) at "
|
|
"\[\r\n\]+#7 .* factorial_func \\(value=6\\) at "
|
|
"\[\r\n\]+#8 .* main \\(.*\\) at "
|
|
}
|
|
|
|
set post_corefile_regs [capture_command_output "info registers" ""]
|
|
if {![string compare $pre_corefile_regs $post_corefile_regs]} {
|
|
pass "corefile restored general registers"
|
|
} else {
|
|
fail "corefile restored general registers"
|
|
}
|
|
|
|
set post_corefile_allregs [capture_command_output "info all-reg" ""]
|
|
if {![string compare $pre_corefile_allregs $post_corefile_allregs]} {
|
|
pass "corefile restored all registers"
|
|
} else {
|
|
fail "corefile restored all registers"
|
|
}
|
|
|
|
set post_corefile_sysregs [capture_command_output "info reg system" ""]
|
|
if {![string compare $pre_corefile_sysregs $post_corefile_sysregs]} {
|
|
pass "corefile restored system registers"
|
|
} else {
|
|
fail "corefile restored system registers"
|
|
}
|
|
|
|
set post_corefile_extern_array \
|
|
[capture_command_output "print extern_array" "$print_prefix"]
|
|
if {![string compare $pre_corefile_extern_array $post_corefile_extern_array]} {
|
|
pass "corefile restored extern array"
|
|
} else {
|
|
fail "corefile restored extern array"
|
|
}
|
|
|
|
set post_corefile_static_array \
|
|
[capture_command_output "print static_array" "$print_prefix"]
|
|
if {![string compare $pre_corefile_static_array $post_corefile_static_array]} {
|
|
pass "corefile restored static array"
|
|
} else {
|
|
fail "corefile restored static array"
|
|
}
|
|
|
|
set post_corefile_uninit_array \
|
|
[capture_command_output "print un_initialized_array" "$print_prefix"]
|
|
if {![string compare $pre_corefile_uninit_array $post_corefile_uninit_array]} {
|
|
pass "corefile restored un-initialized array"
|
|
} else {
|
|
fail "corefile restored un-initialized array"
|
|
}
|
|
|
|
set post_corefile_heap_string \
|
|
[capture_command_output "print heap_string" "$print_prefix"]
|
|
if {![string compare $pre_corefile_heap_string $post_corefile_heap_string]} {
|
|
pass "corefile restored heap array"
|
|
} else {
|
|
fail "corefile restored heap array"
|
|
}
|
|
|
|
set post_corefile_local_array \
|
|
[capture_command_output "print array_func::local_array" "$print_prefix"]
|
|
if {![string compare $pre_corefile_local_array $post_corefile_local_array]} {
|
|
pass "corefile restored stack array"
|
|
} else {
|
|
fail "corefile restored stack array"
|
|
}
|
|
|
|
set post_corefile_backtrace [capture_command_output "backtrace" ""]
|
|
if {![string compare $pre_corefile_backtrace $post_corefile_backtrace]} {
|
|
pass "corefile restored backtrace"
|
|
} else {
|
|
fail "corefile restored backtrace"
|
|
}
|