mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-27 09:38:57 +00:00
25902bd0ba
Commits: commitaaad5a3254Author: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 3 commit2e61486fceAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 2 commit202beb3feeAuthor: Tom de Vries <tdevries@suse.de> Date: Fri Sep 5 15:36:23 2025 +0200 [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 1 were made to work around the changes to clean_restart in commit: commitcba778b944Date: Sun Sep 7 11:53:30 2025 +0200 [gdb/testsuite] Error out on clean_restart <absolute filename> These commits added a lot of calls to gdb_load which can be removed in many cases by passing $testfile to clean_restart, or by switching to use prepare_for_testing to compile the test executable. In this commit I've gone through the gdb.base/ directory and removed as many of the gdb_load calls as possible. I was only looking for places where the gdb_load call immediately follows the call to clean_restart. And I did skip a few where it was not as simple as just passing $testfile. Where possible I've updated tests to use calls to prepare_for_testing, and simply removed the clean_restart call altogether (this is done as part of prepare_for_testing). This is, I think, the best solution. In other cases I've removed the gdb_load call, and passed $testfile to clean_restart. I've preferred $::testfile to adding a 'global' declaration, and in some cases switching to testfile has allowed me to remove the 'global binfile' as an additional cleanup. I ran the complete set of tests that I touched and I didn't see any regressions, so I don't believe I broke anything. I know that there are probably gdb_load calls that can be cleaned up in other testsuite sub-directories, if/when this patch is merged I'll take a look at those too. Reviewed-By: Tom de Vries <tdevries@suse.de>
68 lines
2.1 KiB
Plaintext
68 lines
2.1 KiB
Plaintext
# Copyright 2013-2025 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# PR 11786 (Gold and strip differ on memsz field of PT_TLS).
|
|
# Generate a core file from the stripped version of the program,
|
|
# and then try to debug the core with the unstripped version.
|
|
|
|
standard_testfile
|
|
|
|
if { [have_fuse_ld_gold] == 0} {
|
|
return -1
|
|
}
|
|
|
|
if {[build_executable "failed to prepare" $testfile $srcfile \
|
|
{debug pie "ldflags=-fuse-ld=gold"}]} {
|
|
return -1
|
|
}
|
|
|
|
set stripped_binfile ${binfile}.stripped
|
|
set gcorefile ${binfile}.gcore
|
|
|
|
set strip_program [transform strip]
|
|
remote_file host delete ${stripped_binfile}
|
|
if {[run_on_host "strip" "$strip_program" "-g -o ${stripped_binfile} $binfile"]} {
|
|
return -1
|
|
}
|
|
|
|
# Workaround PR binutils/10802:
|
|
# Preserve the 'x' bit also for PIEs (Position Independent Executables).
|
|
set perm [file attributes ${binfile} -permissions]
|
|
file attributes ${stripped_binfile} -permissions $perm
|
|
|
|
clean_restart
|
|
gdb_load $stripped_binfile
|
|
|
|
# The binary is stripped of debug info, but not minsyms.
|
|
if {![runto break_here]} {
|
|
return -1
|
|
}
|
|
|
|
if {![gdb_gcore_cmd $gcorefile "save a corefile"]} {
|
|
return -1
|
|
}
|
|
|
|
# Now restart gdb with the unstripped binary and load the corefile.
|
|
|
|
clean_restart $testfile
|
|
|
|
gdb_test "core ${gcorefile}" \
|
|
"Core was generated by .*" "re-load generated corefile"
|
|
|
|
# Put $pc in gdb.log for debug purposes for comparison with stripped case.
|
|
gdb_test "x/i \$pc" "break_here.*"
|
|
|
|
gdb_test "frame" "#0 \[^\r\n\]* break_here .*" "unstripped + core ok"
|