Files
binutils-gdb/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp
Andrew Burgess 25902bd0ba gdb/testsuite: make more use of clean_restart's argument
Commits:

  commit aaad5a3254
  Author: Tom de Vries <tdevries@suse.de>
  Date:   Fri Sep 5 15:36:23 2025 +0200

      [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 3

  commit 2e61486fce
  Author: Tom de Vries <tdevries@suse.de>
  Date:   Fri Sep 5 15:36:23 2025 +0200

      [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 2

  commit 202beb3fee
  Author: Tom de Vries <tdevries@suse.de>
  Date:   Fri Sep 5 15:36:23 2025 +0200

      [gdb/testsuite] Fix clean_restart <absolute filename> in gdb.base, part 1

were made to work around the changes to clean_restart in commit:

  commit cba778b944
  Date:   Sun Sep 7 11:53:30 2025 +0200

      [gdb/testsuite] Error out on clean_restart <absolute filename>

These commits added a lot of calls to gdb_load which can be removed in
many cases by passing $testfile to clean_restart, or by switching to
use prepare_for_testing to compile the test executable.

In this commit I've gone through the gdb.base/ directory and removed
as many of the gdb_load calls as possible.  I was only looking for
places where the gdb_load call immediately follows the call to
clean_restart.  And I did skip a few where it was not as simple as
just passing $testfile.

Where possible I've updated tests to use calls to prepare_for_testing,
and simply removed the clean_restart call altogether (this is done as
part of prepare_for_testing).  This is, I think, the best solution.

In other cases I've removed the gdb_load call, and passed $testfile to
clean_restart.  I've preferred $::testfile to adding a 'global'
declaration, and in some cases switching to testfile has allowed me to
remove the 'global binfile' as an additional cleanup.

I ran the complete set of tests that I touched and I didn't see any
regressions, so I don't believe I broke anything.

I know that there are probably gdb_load calls that can be cleaned up
in other testsuite sub-directories, if/when this patch is merged I'll
take a look at those too.

Reviewed-By: Tom de Vries <tdevries@suse.de>
2025-12-01 14:00:47 +00:00

128 lines
3.7 KiB
Plaintext

# Copyright 2010-2025 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Test that GDB can generate accurate backtraces even if some of the stack
# trace goes through a function with no debug information.
standard_testfile -caller.c -main.c
set objmainfile [standard_output_file ${testfile}-main.o]
set objcallerfile [standard_output_file ${testfile}-caller.o]
# Recompile the inferior with or without CFI information, then run the
# inferior until the point where the important test starts.
# Returns FALSE on an ERROR.
proc prepare_test {has_cfi} {
global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile
if {$has_cfi} {
set extension "cfi"
if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \
"${objcallerfile}" \
object [list {additional_flags=-fomit-frame-pointer \
-funwind-tables -fasynchronous-unwind-tables}]] != "" } {
untested "couldn't compile"
return false
}
} else {
set extension "no-cfi"
if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \
"${objcallerfile}" \
object [list {additional_flags=-fomit-frame-pointer \
-fno-unwind-tables \
-fno-asynchronous-unwind-tables}]] != "" } {
untested "couldn't compile"
return false
}
}
if {[gdb_compile [list "${objmainfile}" \
"${objcallerfile}"] \
"${binfile}-${extension}" binfile {}] != ""} {
untested "couldn't link object files"
return false
}
clean_restart $::testfile-$extension
if { ![runto callback] } {
fail "has_cfi=$has_cfi: Can't run to callback"
return false
}
gdb_test_no_output "maint frame-unwinder disable ARCH"
return true
}
if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" \
"${objmainfile}" \
object {debug}] != "" } {
untested "couldn't compile main file"
return
}
proc_with_prefix no-cfi {} {
if { ![prepare_test false] } {
return
}
set re_msg \
[string_list_to_regexp \
"Required frame unwinder may have been disabled," \
" see 'maint info frame-unwinders'"]
set hs {[^\r\n]}
set re_bt_line "#0\\s+[string_to_regexp {callback ()}] $hs+"
set re_bt_no_filters \
[multi_line \
$re_bt_line \
$re_msg]
gdb_test "bt -no-filters" \
$re_bt_no_filters \
"verify no-filters unwind fail"
# Flush frame cache to retrigger the message.
gdb_test "maint flush register-cache" \
[string_to_regexp "Register cache flushed."]
# This output may occur when we run into the message while applying the
# frame filters.
set re_bt \
[multi_line \
$hs+$re_msg \
$re_bt_line]
gdb_test "bt" \
"($re_bt|$re_bt_no_filters)" \
"verify unwind fail"
}
proc_with_prefix cfi {} {
if { ![prepare_test true] } {
return
}
if { [istarget "arm*-*-*"] } {
setup_kfail backtrace/31950 *-*-*
}
set text {[^\r\n]+}
# #0 callback () at ...
# #1 0x00000000004004e9 in caller ()
# #2 0x00000000004004cd in main () at ...
gdb_test "bt" \
[multi_line \
"#0 +callback $text" \
"#1 $text in caller $text" \
"#2 $text in main $text"] \
"Verify unwinding works"
}
no-cfi
cfi