Files
binutils-gdb/gdb/terminal.h
Pedro Alves 6ac9f56543 New '--binary-output' command line option, fix gdb.mi/ testing on Windows
MI testcases currently all fail on native Windows with:

 Running /c/gdb/src/gdb/testsuite/gdb.mi/mi-simplerun.exp ...
 ERROR: (timeout) GDB never initialized after 10 seconds.

This is because when GDB is started in MI mode, it prints info to the
terminal before -iex options are processed.  I.e., before the "maint
set console-translation-mode binary" command in

 gdb -nw -nx -q -iex "set height 0" -iex "set width 0" \
    -iex "set interactive-mode on" \
    -iex "maint set console-translation-mode binary" \
    -i=mi

... is processed.  This results in GDB printing early output with
\r\r\n, like can be easily seen by passing --debug to runtest:

  expect: does "=thread-group-added,id="i1"\r\r\n=cmd-param-changed,param="width",value="4294967295"\r\r\n=cmd-param-changed,param="interactive-mode",value="on"\r\r\n(gdb) \r\n" (spawn_id exp10) match regular expression "~"GNU.*\r\n~".*[(]gdb[)] \r\n$"? Gate "~"GNU*\r\n~"*gdb? \r\n"? gate=no

Fix this by adding a new Windows-only --binary-output command line
option to GDB, which is processed much earlier than -iex, and making
the testsuite pass that instead of "maint set console-translation-mode
binary".

Remove "maint set console-translation-mode" completely, since the only
reason it existed was for the testsuite, and it was never included in
any release.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Reviewed-By: Tom de Vries <tdevries@suse.de>
Change-Id: I4632707bb7c8ca573cffff9641ddeb33a0e150af
2025-09-19 19:54:13 +01:00

68 lines
2.0 KiB
C++

/* Terminal interface definitions for GDB, the GNU Debugger.
Copyright (C) 1986-2025 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef GDB_TERMINAL_H
#define GDB_TERMINAL_H
#include "serial.h"
struct inferior;
extern void new_tty_prefork (std::string ttyname);
extern void new_tty (void);
extern void new_tty_postfork (void);
extern void copy_terminal_info (struct inferior *to, struct inferior *from);
/* Exchange the terminal info and state between inferiors A and B. */
extern void swap_terminal_info (inferior *a, inferior *b);
extern pid_t create_tty_session (void);
/* Set up a serial structure describing standard input. In inflow.c. */
extern void initialize_stdin_serial (void);
extern void gdb_save_tty_state (void);
/* Take a snapshot of our initial tty state before readline/ncurses
have had a chance to alter it. */
extern void set_initial_gdb_ttystate (void);
/* Restore initial tty state. */
extern void restore_initial_gdb_ttystate (void);
/* An RAII-based object that saves the tty state, and then restores it again
when this object is destroyed. */
class scoped_gdb_ttystate
{
public:
scoped_gdb_ttystate ();
~scoped_gdb_ttystate ();
private:
serial_ttystate m_ttystate;
};
#ifdef USE_WIN32API
/* Set translation mode of stdout/stderr to binary. */
extern void set_output_translation_mode_binary ();
#endif
#endif /* GDB_TERMINAL_H */