mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-11-16 04:24:43 +00:00
Convert solib_ops into an abstract base class (with abstract methods,
some of them with default implementations) and convert all the existing
solib_ops instances to solib_ops derived classes / implementations.
Prior to this patch, solib_ops is a structure holding function pointers,
of which there are only a handful of global instances (in the
`solib-*.c` files). When passing an `solib_ops *` around, it's a
pointer to one of these instances. After this patch, there are no more
global solib_ops instances. Instances are created as needed and stored
in struct program_space. These instances could eventually be made to
contain the program space-specific data, which is currently kept in
per-program space registries (I have some pending patches for that).
Prior to this patch, `gdbarch_so_ops` is a gdbarch method that returns a
pointer to the appropriate solib_ops implementation for the gdbarch.
This is replaced with the `gdbarch_make_solib_ops` method, which returns
a new instance of the appropriate solib_ops implementation for this
gdbarch. This requires introducing some factory functions for the
various solib_ops implementation, to be used as `gdbarch_make_solib_ops`
callbacks. For instance:
solib_ops_up
make_linux_ilp32_svr4_solib_ops ()
{
return std::make_unique<linux_ilp32_svr4_solib_ops> ();
}
The previous code is full of cases of tdep files copying some base
solib_ops implementation, and overriding one or more function pointer
(see ppc_linux_init_abi, for instance). I tried to convert all of this
is a class hierarchy. I like that it's now possible to get a good
static view of all the existing solib_ops variants. The hierarchy looks
like this:
solib_ops
├── aix_solib_ops
├── darwin_solib_ops
├── dsbt_solib_ops
├── frv_solib_ops
├── rocm_solib_ops
├── svr4_solib_ops
│ ├── ilp32_svr4_solib_ops
│ ├── lp64_svr4_solib_ops
│ ├── linux_ilp32_svr4_solib_ops
│ │ ├── mips_linux_ilp32_svr4_solib_ops
│ │ └── ppc_linux_ilp32_svr4_solib_ops
│ ├── linux_lp64_svr4_solib_ops
│ │ └── mips_linux_lp64_svr4_solib_ops
│ ├── mips_nbsd_ilp32_svr4_solib_ops
│ ├── mips_nbsd_lp64_svr4_solib_ops
│ ├── mips_fbsd_ilp32_svr4_solib_ops
│ └── mips_fbsd_lp64_svr4_solib_ops
└── target_solib_ops
└── windows_solib_ops
The solib-svr4 code has per-arch specialization to provide a
link_map_offsets, containing the offsets of the interesting fields in
`struct link_map` on that particular architecture. Prior to this patch,
arches would set a callback returning the appropriate link_map_offsets
by calling `set_solib_svr4_fetch_link_map_offsets`, which also happened
to set the gdbarch's so_ops to `&svr_so_ops`. I converted this to an
abstract virtual method of `struct svr4_solib_ops`, meaning that all
classes deriving from svr4_solib_ops must provide a method returning the
appropriate link_map_offsets for the architecture. I renamed
`set_solib_svr4_fetch_link_map_offsets` to `set_solib_svr4_ops`. This
function is still necessary because it also calls
set_gdbarch_iterate_over_objfiles_in_search_order, but if it was not for
that, we could get rid of it.
There is an instance of CRTP in mips-linux-tdep.c, because both
mips_linux_ilp32_svr4_solib_ops and mips_linux_lp64_svr4_solib_ops need
to derive from different SVR4 base classes (linux_ilp32_svr4_solib_ops
and linux_lp64_svr4_solib_ops), but they both want to override the
in_dynsym_resolve_code method with the same implementation.
The solib_ops::supports_namespaces method is new: the support for
namespaces was previously predicated by the presence or absence of a
find_solib_ns method. It now needs to be explicit.
There is a new progspace::release_solib_ops method, which is only needed
for rocm_solib_ops. For the moment, rocm_solib_ops replaces and wraps
the existing svr4_solib_ops instance, in order to combine the results of
the two. The plan is to have a subsequent patch to allow program spaces to have
multiple solib_ops, removing the need for release_solib_ops.
Speaking of rocm_solib_ops: it previously overrode only a few methods by
copying svr4_solib_ops and overwriting some function pointers. Now, it
needs to implement all the methods that svr4_solib_ops implements, in
order to forward the call. Otherwise, the default solib_ops method
would be called, hiding the svr4_solib_ops implementation. Again, this
can be removed once we have support for multiple solib_ops in a
program_space.
There is also a small change in how rocm_solib_ops is activated. Prior
to this patch, it's done at the end of rocm_update_solib_list. Since it
overrides the function pointer in the static svr4_solib_ops, and then
overwrites the host gdbarch, so_ops field, it's something that happens
only once. After the patch though, we need to set rocm_solib_ops in all
the program spaces that appear. We do this in
rocm_solib_target_inferior_created and in the new
rocm_solib_target_inferior_execd. After this, I will explore doing a
change where rocm_solib_ops is only set when we detect the ROCm runtime
is loaded.
Change-Id: I5896b5bcbf8bdb024d67980380feba1ffefaa4c9
Approved-By: Pedro Alves <pedro@palves.net>
302 lines
9.1 KiB
C
302 lines
9.1 KiB
C
/* Target-dependent code for OpenBSD/powerpc.
|
||
|
||
Copyright (C) 2004-2025 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "arch-utils.h"
|
||
#include "extract-store-integer.h"
|
||
#include "frame.h"
|
||
#include "frame-unwind.h"
|
||
#include "gdbtypes.h"
|
||
#include "osabi.h"
|
||
#include "regcache.h"
|
||
#include "regset.h"
|
||
#include "symtab.h"
|
||
#include "trad-frame.h"
|
||
|
||
#include "ppc-tdep.h"
|
||
#include "ppc-obsd-tdep.h"
|
||
#include "solib-svr4.h"
|
||
|
||
/* Register offsets from <machine/reg.h>. */
|
||
struct ppc_reg_offsets ppcobsd_reg_offsets;
|
||
struct ppc_reg_offsets ppcobsd_fpreg_offsets;
|
||
|
||
|
||
/* Core file support. */
|
||
|
||
/* Supply register REGNUM in the general-purpose register set REGSET
|
||
from the buffer specified by GREGS and LEN to register cache
|
||
REGCACHE. If REGNUM is -1, do this for all registers in REGSET. */
|
||
|
||
void
|
||
ppcobsd_supply_gregset (const struct regset *regset,
|
||
struct regcache *regcache, int regnum,
|
||
const void *gregs, size_t len)
|
||
{
|
||
ppc_supply_gregset (regset, regcache, regnum, gregs, len);
|
||
ppc_supply_fpregset (regset, regcache, regnum, gregs, len);
|
||
}
|
||
|
||
/* Collect register REGNUM in the general-purpose register set
|
||
REGSET, from register cache REGCACHE into the buffer specified by
|
||
GREGS and LEN. If REGNUM is -1, do this for all registers in
|
||
REGSET. */
|
||
|
||
void
|
||
ppcobsd_collect_gregset (const struct regset *regset,
|
||
const struct regcache *regcache, int regnum,
|
||
void *gregs, size_t len)
|
||
{
|
||
ppc_collect_gregset (regset, regcache, regnum, gregs, len);
|
||
ppc_collect_fpregset (regset, regcache, regnum, gregs, len);
|
||
}
|
||
|
||
/* OpenBSD/powerpc register set. */
|
||
|
||
const struct regset ppcobsd_gregset =
|
||
{
|
||
&ppcobsd_reg_offsets,
|
||
ppcobsd_supply_gregset
|
||
};
|
||
|
||
const struct regset ppcobsd_fpregset =
|
||
{
|
||
&ppcobsd_fpreg_offsets,
|
||
ppc_supply_fpregset
|
||
};
|
||
|
||
/* Iterate over core file register note sections. */
|
||
|
||
static void
|
||
ppcobsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
||
iterate_over_regset_sections_cb *cb,
|
||
void *cb_data,
|
||
const struct regcache *regcache)
|
||
{
|
||
cb (".reg", 412, 412, &ppcobsd_gregset, NULL, cb_data);
|
||
}
|
||
|
||
|
||
/* Signal trampolines. */
|
||
|
||
/* Since OpenBSD 3.2, the sigtramp routine is mapped at a random page
|
||
in virtual memory. The randomness makes it somewhat tricky to
|
||
detect it, but fortunately we can rely on the fact that the start
|
||
of the sigtramp routine is page-aligned. We recognize the
|
||
trampoline by looking for the code that invokes the sigreturn
|
||
system call. The offset where we can find that code varies from
|
||
release to release.
|
||
|
||
By the way, the mapping mentioned above is read-only, so you cannot
|
||
place a breakpoint in the signal trampoline. */
|
||
|
||
/* Default page size. */
|
||
static const int ppcobsd_page_size = 4096;
|
||
|
||
/* Offset for sigreturn(2). */
|
||
static const int ppcobsd_sigreturn_offset[] = {
|
||
0x98, /* OpenBSD 3.8 */
|
||
0x0c, /* OpenBSD 3.2 */
|
||
-1
|
||
};
|
||
|
||
static int
|
||
ppcobsd_sigtramp_frame_sniffer (const struct frame_unwind *self,
|
||
const frame_info_ptr &this_frame,
|
||
void **this_cache)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
CORE_ADDR pc = get_frame_pc (this_frame);
|
||
CORE_ADDR start_pc = (pc & ~(ppcobsd_page_size - 1));
|
||
const int *offset;
|
||
const char *name;
|
||
|
||
find_pc_partial_function (pc, &name, NULL, NULL);
|
||
if (name)
|
||
return 0;
|
||
|
||
for (offset = ppcobsd_sigreturn_offset; *offset != -1; offset++)
|
||
{
|
||
gdb_byte buf[2 * PPC_INSN_SIZE];
|
||
unsigned long insn;
|
||
|
||
if (!safe_frame_unwind_memory (this_frame, start_pc + *offset,
|
||
{buf, sizeof buf}))
|
||
continue;
|
||
|
||
/* Check for "li r0,SYS_sigreturn". */
|
||
insn = extract_unsigned_integer (buf, PPC_INSN_SIZE, byte_order);
|
||
if (insn != 0x38000067)
|
||
continue;
|
||
|
||
/* Check for "sc". */
|
||
insn = extract_unsigned_integer (buf + PPC_INSN_SIZE,
|
||
PPC_INSN_SIZE, byte_order);
|
||
if (insn != 0x44000002)
|
||
continue;
|
||
|
||
return 1;
|
||
}
|
||
|
||
return 0;
|
||
}
|
||
|
||
static struct trad_frame_cache *
|
||
ppcobsd_sigtramp_frame_cache (const frame_info_ptr &this_frame, void **this_cache)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
||
ppc_gdbarch_tdep *tdep = gdbarch_tdep<ppc_gdbarch_tdep> (gdbarch);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
struct trad_frame_cache *cache;
|
||
CORE_ADDR addr, base, func;
|
||
gdb_byte buf[PPC_INSN_SIZE];
|
||
unsigned long insn, sigcontext_offset;
|
||
int i;
|
||
|
||
if (*this_cache)
|
||
return (struct trad_frame_cache *) *this_cache;
|
||
|
||
cache = trad_frame_cache_zalloc (this_frame);
|
||
*this_cache = cache;
|
||
|
||
func = get_frame_pc (this_frame);
|
||
func &= ~(ppcobsd_page_size - 1);
|
||
if (!safe_frame_unwind_memory (this_frame, func, {buf, sizeof buf}))
|
||
return cache;
|
||
|
||
/* Calculate the offset where we can find `struct sigcontext'. We
|
||
base our calculation on the amount of stack space reserved by the
|
||
first instruction of the signal trampoline. */
|
||
insn = extract_unsigned_integer (buf, PPC_INSN_SIZE, byte_order);
|
||
sigcontext_offset = (0x10000 - (insn & 0x0000ffff)) + 8;
|
||
|
||
base = get_frame_register_unsigned (this_frame, gdbarch_sp_regnum (gdbarch));
|
||
addr = base + sigcontext_offset + 2 * tdep->wordsize;
|
||
for (i = 0; i < ppc_num_gprs; i++, addr += tdep->wordsize)
|
||
{
|
||
int regnum = i + tdep->ppc_gp0_regnum;
|
||
trad_frame_set_reg_addr (cache, regnum, addr);
|
||
}
|
||
trad_frame_set_reg_addr (cache, tdep->ppc_lr_regnum, addr);
|
||
addr += tdep->wordsize;
|
||
trad_frame_set_reg_addr (cache, tdep->ppc_cr_regnum, addr);
|
||
addr += tdep->wordsize;
|
||
trad_frame_set_reg_addr (cache, tdep->ppc_xer_regnum, addr);
|
||
addr += tdep->wordsize;
|
||
trad_frame_set_reg_addr (cache, tdep->ppc_ctr_regnum, addr);
|
||
addr += tdep->wordsize;
|
||
trad_frame_set_reg_addr (cache, gdbarch_pc_regnum (gdbarch), addr);
|
||
/* SRR0? */
|
||
addr += tdep->wordsize;
|
||
|
||
/* Construct the frame ID using the function start. */
|
||
trad_frame_set_id (cache, frame_id_build (base, func));
|
||
|
||
return cache;
|
||
}
|
||
|
||
static void
|
||
ppcobsd_sigtramp_frame_this_id (const frame_info_ptr &this_frame,
|
||
void **this_cache, struct frame_id *this_id)
|
||
{
|
||
struct trad_frame_cache *cache =
|
||
ppcobsd_sigtramp_frame_cache (this_frame, this_cache);
|
||
|
||
trad_frame_get_id (cache, this_id);
|
||
}
|
||
|
||
static struct value *
|
||
ppcobsd_sigtramp_frame_prev_register (const frame_info_ptr &this_frame,
|
||
void **this_cache, int regnum)
|
||
{
|
||
struct trad_frame_cache *cache =
|
||
ppcobsd_sigtramp_frame_cache (this_frame, this_cache);
|
||
|
||
return trad_frame_get_register (cache, this_frame, regnum);
|
||
}
|
||
|
||
static const struct frame_unwind_legacy ppcobsd_sigtramp_frame_unwind (
|
||
"ppc openbsd sigtramp",
|
||
SIGTRAMP_FRAME,
|
||
FRAME_UNWIND_ARCH,
|
||
default_frame_unwind_stop_reason,
|
||
ppcobsd_sigtramp_frame_this_id,
|
||
ppcobsd_sigtramp_frame_prev_register,
|
||
NULL,
|
||
ppcobsd_sigtramp_frame_sniffer
|
||
);
|
||
|
||
|
||
static void
|
||
ppcobsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
/* OpenBSD doesn't support the 128-bit `long double' from the psABI. */
|
||
set_gdbarch_long_double_bit (gdbarch, 64);
|
||
set_gdbarch_long_double_format (gdbarch, floatformats_ieee_double);
|
||
|
||
/* OpenBSD currently uses a broken GCC. */
|
||
set_gdbarch_return_value (gdbarch, ppc_sysv_abi_broken_return_value);
|
||
|
||
/* OpenBSD uses SVR4-style shared libraries. */
|
||
set_solib_svr4_ops (gdbarch, make_svr4_ilp32_solib_ops);
|
||
|
||
set_gdbarch_iterate_over_regset_sections
|
||
(gdbarch, ppcobsd_iterate_over_regset_sections);
|
||
|
||
frame_unwind_append_unwinder (gdbarch, &ppcobsd_sigtramp_frame_unwind);
|
||
}
|
||
|
||
INIT_GDB_FILE (ppcobsd_tdep)
|
||
{
|
||
gdbarch_register_osabi (bfd_arch_rs6000, 0, GDB_OSABI_OPENBSD,
|
||
ppcobsd_init_abi);
|
||
gdbarch_register_osabi (bfd_arch_powerpc, 0, GDB_OSABI_OPENBSD,
|
||
ppcobsd_init_abi);
|
||
|
||
/* Avoid initializing the register offsets again if they were
|
||
already initialized by ppcobsd-nat.c. */
|
||
if (ppcobsd_reg_offsets.pc_offset == 0)
|
||
{
|
||
/* General-purpose registers. */
|
||
ppcobsd_reg_offsets.r0_offset = 0;
|
||
ppcobsd_reg_offsets.gpr_size = 4;
|
||
ppcobsd_reg_offsets.xr_size = 4;
|
||
ppcobsd_reg_offsets.pc_offset = 384;
|
||
ppcobsd_reg_offsets.ps_offset = 388;
|
||
ppcobsd_reg_offsets.cr_offset = 392;
|
||
ppcobsd_reg_offsets.lr_offset = 396;
|
||
ppcobsd_reg_offsets.ctr_offset = 400;
|
||
ppcobsd_reg_offsets.xer_offset = 404;
|
||
ppcobsd_reg_offsets.mq_offset = 408;
|
||
|
||
/* Floating-point registers. */
|
||
ppcobsd_reg_offsets.f0_offset = 128;
|
||
ppcobsd_reg_offsets.fpscr_offset = -1;
|
||
|
||
}
|
||
|
||
if (ppcobsd_fpreg_offsets.fpscr_offset == 0)
|
||
{
|
||
/* Floating-point registers. */
|
||
ppcobsd_reg_offsets.f0_offset = 0;
|
||
ppcobsd_reg_offsets.fpscr_offset = 256;
|
||
ppcobsd_reg_offsets.fpscr_size = 4;
|
||
}
|
||
}
|