mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-11-16 12:34:43 +00:00
a2e3cce344
Convert solib_ops into an abstract base class (with abstract methods,
some of them with default implementations) and convert all the existing
solib_ops instances to solib_ops derived classes / implementations.
Prior to this patch, solib_ops is a structure holding function pointers,
of which there are only a handful of global instances (in the
`solib-*.c` files). When passing an `solib_ops *` around, it's a
pointer to one of these instances. After this patch, there are no more
global solib_ops instances. Instances are created as needed and stored
in struct program_space. These instances could eventually be made to
contain the program space-specific data, which is currently kept in
per-program space registries (I have some pending patches for that).
Prior to this patch, `gdbarch_so_ops` is a gdbarch method that returns a
pointer to the appropriate solib_ops implementation for the gdbarch.
This is replaced with the `gdbarch_make_solib_ops` method, which returns
a new instance of the appropriate solib_ops implementation for this
gdbarch. This requires introducing some factory functions for the
various solib_ops implementation, to be used as `gdbarch_make_solib_ops`
callbacks. For instance:
solib_ops_up
make_linux_ilp32_svr4_solib_ops ()
{
return std::make_unique<linux_ilp32_svr4_solib_ops> ();
}
The previous code is full of cases of tdep files copying some base
solib_ops implementation, and overriding one or more function pointer
(see ppc_linux_init_abi, for instance). I tried to convert all of this
is a class hierarchy. I like that it's now possible to get a good
static view of all the existing solib_ops variants. The hierarchy looks
like this:
solib_ops
├── aix_solib_ops
├── darwin_solib_ops
├── dsbt_solib_ops
├── frv_solib_ops
├── rocm_solib_ops
├── svr4_solib_ops
│ ├── ilp32_svr4_solib_ops
│ ├── lp64_svr4_solib_ops
│ ├── linux_ilp32_svr4_solib_ops
│ │ ├── mips_linux_ilp32_svr4_solib_ops
│ │ └── ppc_linux_ilp32_svr4_solib_ops
│ ├── linux_lp64_svr4_solib_ops
│ │ └── mips_linux_lp64_svr4_solib_ops
│ ├── mips_nbsd_ilp32_svr4_solib_ops
│ ├── mips_nbsd_lp64_svr4_solib_ops
│ ├── mips_fbsd_ilp32_svr4_solib_ops
│ └── mips_fbsd_lp64_svr4_solib_ops
└── target_solib_ops
└── windows_solib_ops
The solib-svr4 code has per-arch specialization to provide a
link_map_offsets, containing the offsets of the interesting fields in
`struct link_map` on that particular architecture. Prior to this patch,
arches would set a callback returning the appropriate link_map_offsets
by calling `set_solib_svr4_fetch_link_map_offsets`, which also happened
to set the gdbarch's so_ops to `&svr_so_ops`. I converted this to an
abstract virtual method of `struct svr4_solib_ops`, meaning that all
classes deriving from svr4_solib_ops must provide a method returning the
appropriate link_map_offsets for the architecture. I renamed
`set_solib_svr4_fetch_link_map_offsets` to `set_solib_svr4_ops`. This
function is still necessary because it also calls
set_gdbarch_iterate_over_objfiles_in_search_order, but if it was not for
that, we could get rid of it.
There is an instance of CRTP in mips-linux-tdep.c, because both
mips_linux_ilp32_svr4_solib_ops and mips_linux_lp64_svr4_solib_ops need
to derive from different SVR4 base classes (linux_ilp32_svr4_solib_ops
and linux_lp64_svr4_solib_ops), but they both want to override the
in_dynsym_resolve_code method with the same implementation.
The solib_ops::supports_namespaces method is new: the support for
namespaces was previously predicated by the presence or absence of a
find_solib_ns method. It now needs to be explicit.
There is a new progspace::release_solib_ops method, which is only needed
for rocm_solib_ops. For the moment, rocm_solib_ops replaces and wraps
the existing svr4_solib_ops instance, in order to combine the results of
the two. The plan is to have a subsequent patch to allow program spaces to have
multiple solib_ops, removing the need for release_solib_ops.
Speaking of rocm_solib_ops: it previously overrode only a few methods by
copying svr4_solib_ops and overwriting some function pointers. Now, it
needs to implement all the methods that svr4_solib_ops implements, in
order to forward the call. Otherwise, the default solib_ops method
would be called, hiding the svr4_solib_ops implementation. Again, this
can be removed once we have support for multiple solib_ops in a
program_space.
There is also a small change in how rocm_solib_ops is activated. Prior
to this patch, it's done at the end of rocm_update_solib_list. Since it
overrides the function pointer in the static svr4_solib_ops, and then
overwrites the host gdbarch, so_ops field, it's something that happens
only once. After the patch though, we need to set rocm_solib_ops in all
the program spaces that appear. We do this in
rocm_solib_target_inferior_created and in the new
rocm_solib_target_inferior_execd. After this, I will explore doing a
change where rocm_solib_ops is only set when we detect the ROCm runtime
is loaded.
Change-Id: I5896b5bcbf8bdb024d67980380feba1ffefaa4c9
Approved-By: Pedro Alves <pedro@palves.net>
92 lines
2.8 KiB
C
92 lines
2.8 KiB
C
/* Target-dependent, architecture-independent code for DICOS, for GDB.
|
|
|
|
Copyright (C) 2009-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "osabi.h"
|
|
#include "solib.h"
|
|
#include "solib-target.h"
|
|
#include "inferior.h"
|
|
#include "dicos-tdep.h"
|
|
#include "gdbarch.h"
|
|
|
|
void
|
|
dicos_init_abi (struct gdbarch *gdbarch)
|
|
{
|
|
set_gdbarch_make_solib_ops (gdbarch, make_target_solib_ops);
|
|
|
|
/* Every process, although has its own address space, sees the same
|
|
list of shared libraries. There's no "main executable" in DICOS,
|
|
so this accounts for all code. */
|
|
set_gdbarch_has_global_solist (gdbarch, 1);
|
|
|
|
/* The DICOS breakpoint API takes care of magically making
|
|
breakpoints visible to all inferiors. */
|
|
set_gdbarch_has_global_breakpoints (gdbarch, 1);
|
|
|
|
/* There's no (standard definition of) entry point or a guaranteed
|
|
text location with a symbol where to place the call dummy, so we
|
|
need it on the stack. Rely on i386_gdbarch_init used also for
|
|
amd64 to set up ON_STACK inferior calls. */
|
|
|
|
/* DICOS rewinds the PC itself. */
|
|
set_gdbarch_decr_pc_after_break (gdbarch, 0);
|
|
}
|
|
|
|
/* Return true if ABFD is a dicos load module. HEADER_SIZE is the
|
|
expected size of the "header" section in bytes. */
|
|
|
|
int
|
|
dicos_load_module_p (bfd *abfd, int header_size)
|
|
{
|
|
int ret = 0;
|
|
const char *symname = "Dicos_loadModuleInfo";
|
|
asection *section;
|
|
|
|
/* DICOS files don't have a .note.ABI-tag marker or something
|
|
similar. We do know there's always a "header" section of
|
|
HEADER_SIZE bytes (size depends on architecture), and there's
|
|
always a "Dicos_loadModuleInfo" symbol defined. Look for the
|
|
section first, as that should be cheaper. */
|
|
|
|
section = bfd_get_section_by_name (abfd, "header");
|
|
if (!section)
|
|
return 0;
|
|
|
|
if (bfd_section_size (section) != header_size)
|
|
return 0;
|
|
|
|
/* Dicos LMs always have a "Dicos_loadModuleInfo" symbol
|
|
defined. Look for it. */
|
|
|
|
gdb::array_view<asymbol *> symbol_table
|
|
= gdb_bfd_canonicalize_symtab (abfd, false);
|
|
|
|
for (asymbol *sym : symbol_table)
|
|
{
|
|
if (sym->name != NULL
|
|
&& symname[0] == sym->name[0]
|
|
&& strcmp (symname + 1, sym->name + 1) == 0)
|
|
{
|
|
ret = 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return ret;
|
|
}
|