mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-11-16 04:24:43 +00:00
338796db76
Loading a library containing a lot (> 100k) sections proved very slow
with whenever the support for ROCm was built into gdb. The culprit is
the gdbarch_from_bfd call in rocm_solib_relocate_section_addresses:
if (!is_amdgpu_arch (gdbarch_from_bfd (so.abfd.get ())))
This function gets called for every section, and gdbarch_from_bfd is
somewhat slow. It turns out that we can skip the gdbarch_from_bfd call,
since all is_amdgpu_arch needs is the bfd_architecture value, which we
can directly extract from the `bfd *`, without going through the
gdbarch.
Add an overload of is_amdgpu_arch that takes a `bfd *`, and use it in
rocm_solib_relocate_section_addresses.
Update a call site in rocm_solib_bfd_open to use the new overload as
well. That call site is not as much in a hot path, but there is no
point in paying the extra cost of looking up the gdbarch there. I
removed the other assert that checked that gdbarch_from_bfd returned a
non-nullptr value. If that was the case, something would be very wrong
with ROCgdb, and the problem would manifest very soon after anyway.
Change-Id: I55e9e68af59903b1b9727ff57388f9469d0e0002
Approved-by: Lancelot Six <lancelot.six@amd.com> (AMDGPU)
99 lines
3.2 KiB
C++
99 lines
3.2 KiB
C++
/* Target-dependent code for the AMDGPU architectures.
|
|
|
|
Copyright (C) 2019-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDB_AMDGPU_TDEP_H
|
|
#define GDB_AMDGPU_TDEP_H
|
|
|
|
#include "gdbarch.h"
|
|
|
|
#include <amd-dbgapi/amd-dbgapi.h>
|
|
#include <unordered_map>
|
|
|
|
/* Provide std::unordered_map::Hash for amd_dbgapi_register_id_t. */
|
|
struct register_id_hash
|
|
{
|
|
size_t
|
|
operator() (const amd_dbgapi_register_id_t ®ister_id) const
|
|
{
|
|
return std::hash<decltype (register_id.handle)> () (register_id.handle);
|
|
}
|
|
};
|
|
|
|
/* Provide std::unordered_map::Equal for amd_dbgapi_register_id_t. */
|
|
struct register_id_equal_to
|
|
{
|
|
bool
|
|
operator() (const amd_dbgapi_register_id_t &lhs,
|
|
const amd_dbgapi_register_id_t &rhs) const
|
|
{
|
|
return std::equal_to<decltype (lhs.handle)> () (lhs.handle, rhs.handle);
|
|
}
|
|
};
|
|
|
|
/* AMDGPU architecture specific information. */
|
|
struct amdgpu_gdbarch_tdep : gdbarch_tdep_base
|
|
{
|
|
/* This architecture's breakpoint instruction. */
|
|
gdb::unique_xmalloc_ptr<gdb_byte> breakpoint_instruction_bytes;
|
|
size_t breakpoint_instruction_size;
|
|
|
|
/* A vector of register_ids indexed by their equivalent gdb regnum. */
|
|
std::vector<amd_dbgapi_register_id_t> register_ids;
|
|
|
|
/* A vector of register_properties indexed by their equivalent gdb regnum. */
|
|
std::vector<amd_dbgapi_register_properties_t> register_properties;
|
|
|
|
/* A vector of register names indexed by their equivalent gdb regnum. */
|
|
std::vector<std::string> register_names;
|
|
|
|
/* A vector of register types created from the amd-dbgapi type strings,
|
|
indexed by their equivalent gdb regnum. These are computed lazily by
|
|
amdgpu_register_type, entries that haven't been computed yet are
|
|
nullptr. */
|
|
std::vector<type *> register_types;
|
|
|
|
/* A vector of GDB register numbers indexed by DWARF register number.
|
|
|
|
Unused DWARF register numbers map to value -1. */
|
|
std::vector<int> dwarf_regnum_to_gdb_regnum;
|
|
|
|
/* A map of gdb regnums keyed by they equivalent register_id. */
|
|
std::unordered_map<amd_dbgapi_register_id_t, int, register_id_hash,
|
|
register_id_equal_to>
|
|
regnum_map;
|
|
|
|
/* A map of register_class_ids keyed by their name. */
|
|
std::unordered_map<std::string, amd_dbgapi_register_class_id_t>
|
|
register_class_map;
|
|
};
|
|
|
|
/* Return true if GDBARCH is of an AMDGPU architecture. */
|
|
|
|
bool is_amdgpu_arch (struct gdbarch *gdbarch);
|
|
|
|
/* Return true if ABFD is of an AMDGPU architecture. */
|
|
|
|
bool is_amdgpu_arch (bfd *abfd);
|
|
|
|
/* Return the amdgpu-specific data associated to ARCH. */
|
|
|
|
amdgpu_gdbarch_tdep *get_amdgpu_gdbarch_tdep (gdbarch *arch);
|
|
|
|
#endif /* GDB_AMDGPU_TDEP_H */
|