mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-11-16 12:34:43 +00:00
Convert solib_ops into an abstract base class (with abstract methods,
some of them with default implementations) and convert all the existing
solib_ops instances to solib_ops derived classes / implementations.
Prior to this patch, solib_ops is a structure holding function pointers,
of which there are only a handful of global instances (in the
`solib-*.c` files). When passing an `solib_ops *` around, it's a
pointer to one of these instances. After this patch, there are no more
global solib_ops instances. Instances are created as needed and stored
in struct program_space. These instances could eventually be made to
contain the program space-specific data, which is currently kept in
per-program space registries (I have some pending patches for that).
Prior to this patch, `gdbarch_so_ops` is a gdbarch method that returns a
pointer to the appropriate solib_ops implementation for the gdbarch.
This is replaced with the `gdbarch_make_solib_ops` method, which returns
a new instance of the appropriate solib_ops implementation for this
gdbarch. This requires introducing some factory functions for the
various solib_ops implementation, to be used as `gdbarch_make_solib_ops`
callbacks. For instance:
solib_ops_up
make_linux_ilp32_svr4_solib_ops ()
{
return std::make_unique<linux_ilp32_svr4_solib_ops> ();
}
The previous code is full of cases of tdep files copying some base
solib_ops implementation, and overriding one or more function pointer
(see ppc_linux_init_abi, for instance). I tried to convert all of this
is a class hierarchy. I like that it's now possible to get a good
static view of all the existing solib_ops variants. The hierarchy looks
like this:
solib_ops
├── aix_solib_ops
├── darwin_solib_ops
├── dsbt_solib_ops
├── frv_solib_ops
├── rocm_solib_ops
├── svr4_solib_ops
│ ├── ilp32_svr4_solib_ops
│ ├── lp64_svr4_solib_ops
│ ├── linux_ilp32_svr4_solib_ops
│ │ ├── mips_linux_ilp32_svr4_solib_ops
│ │ └── ppc_linux_ilp32_svr4_solib_ops
│ ├── linux_lp64_svr4_solib_ops
│ │ └── mips_linux_lp64_svr4_solib_ops
│ ├── mips_nbsd_ilp32_svr4_solib_ops
│ ├── mips_nbsd_lp64_svr4_solib_ops
│ ├── mips_fbsd_ilp32_svr4_solib_ops
│ └── mips_fbsd_lp64_svr4_solib_ops
└── target_solib_ops
└── windows_solib_ops
The solib-svr4 code has per-arch specialization to provide a
link_map_offsets, containing the offsets of the interesting fields in
`struct link_map` on that particular architecture. Prior to this patch,
arches would set a callback returning the appropriate link_map_offsets
by calling `set_solib_svr4_fetch_link_map_offsets`, which also happened
to set the gdbarch's so_ops to `&svr_so_ops`. I converted this to an
abstract virtual method of `struct svr4_solib_ops`, meaning that all
classes deriving from svr4_solib_ops must provide a method returning the
appropriate link_map_offsets for the architecture. I renamed
`set_solib_svr4_fetch_link_map_offsets` to `set_solib_svr4_ops`. This
function is still necessary because it also calls
set_gdbarch_iterate_over_objfiles_in_search_order, but if it was not for
that, we could get rid of it.
There is an instance of CRTP in mips-linux-tdep.c, because both
mips_linux_ilp32_svr4_solib_ops and mips_linux_lp64_svr4_solib_ops need
to derive from different SVR4 base classes (linux_ilp32_svr4_solib_ops
and linux_lp64_svr4_solib_ops), but they both want to override the
in_dynsym_resolve_code method with the same implementation.
The solib_ops::supports_namespaces method is new: the support for
namespaces was previously predicated by the presence or absence of a
find_solib_ns method. It now needs to be explicit.
There is a new progspace::release_solib_ops method, which is only needed
for rocm_solib_ops. For the moment, rocm_solib_ops replaces and wraps
the existing svr4_solib_ops instance, in order to combine the results of
the two. The plan is to have a subsequent patch to allow program spaces to have
multiple solib_ops, removing the need for release_solib_ops.
Speaking of rocm_solib_ops: it previously overrode only a few methods by
copying svr4_solib_ops and overwriting some function pointers. Now, it
needs to implement all the methods that svr4_solib_ops implements, in
order to forward the call. Otherwise, the default solib_ops method
would be called, hiding the svr4_solib_ops implementation. Again, this
can be removed once we have support for multiple solib_ops in a
program_space.
There is also a small change in how rocm_solib_ops is activated. Prior
to this patch, it's done at the end of rocm_update_solib_list. Since it
overrides the function pointer in the static svr4_solib_ops, and then
overwrites the host gdbarch, so_ops field, it's something that happens
only once. After the patch though, we need to set rocm_solib_ops in all
the program spaces that appear. We do this in
rocm_solib_target_inferior_created and in the new
rocm_solib_target_inferior_execd. After this, I will explore doing a
change where rocm_solib_ops is only set when we detect the ROCm runtime
is loaded.
Change-Id: I5896b5bcbf8bdb024d67980380feba1ffefaa4c9
Approved-By: Pedro Alves <pedro@palves.net>
268 lines
7.9 KiB
C
268 lines
7.9 KiB
C
/* Target-dependent code for FreeBSD/aarch64.
|
|
|
|
Copyright (C) 2017-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
#include "extract-store-integer.h"
|
|
#include "gdbarch.h"
|
|
#include "fbsd-tdep.h"
|
|
#include "aarch64-tdep.h"
|
|
#include "aarch64-fbsd-tdep.h"
|
|
#include "inferior.h"
|
|
#include "osabi.h"
|
|
#include "solib-svr4.h"
|
|
#include "target.h"
|
|
#include "tramp-frame.h"
|
|
#include "trad-frame.h"
|
|
|
|
/* Register maps. */
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_gregmap[] =
|
|
{
|
|
{ 30, AARCH64_X0_REGNUM, 8 }, /* x0 ... x29 */
|
|
{ 1, AARCH64_LR_REGNUM, 8 },
|
|
{ 1, AARCH64_SP_REGNUM, 8 },
|
|
{ 1, AARCH64_PC_REGNUM, 8 },
|
|
{ 1, AARCH64_CPSR_REGNUM, 4 },
|
|
{ 0 }
|
|
};
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_fpregmap[] =
|
|
{
|
|
{ 32, AARCH64_V0_REGNUM, 16 }, /* v0 ... v31 */
|
|
{ 1, AARCH64_FPSR_REGNUM, 4 },
|
|
{ 1, AARCH64_FPCR_REGNUM, 4 },
|
|
{ 0 }
|
|
};
|
|
|
|
/* Register numbers are relative to tdep->tls_regnum_base. */
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_tls_regmap[] =
|
|
{
|
|
{ 1, 0, 8 }, /* tpidr */
|
|
{ 0 }
|
|
};
|
|
|
|
/* In a signal frame, sp points to a 'struct sigframe' which is
|
|
defined as:
|
|
|
|
struct sigframe {
|
|
siginfo_t sf_si;
|
|
ucontext_t sf_uc;
|
|
};
|
|
|
|
ucontext_t is defined as:
|
|
|
|
struct __ucontext {
|
|
sigset_t uc_sigmask;
|
|
mcontext_t uc_mcontext;
|
|
...
|
|
};
|
|
|
|
The mcontext_t contains the general purpose register set followed
|
|
by the floating point register set. The floating point register
|
|
set is only valid if the _MC_FP_VALID flag is set in mc_flags. */
|
|
|
|
#define AARCH64_SIGFRAME_UCONTEXT_OFFSET 80
|
|
#define AARCH64_UCONTEXT_MCONTEXT_OFFSET 16
|
|
#define AARCH64_MCONTEXT_FPREGS_OFFSET 272
|
|
#define AARCH64_MCONTEXT_FLAGS_OFFSET 800
|
|
#define AARCH64_MCONTEXT_FLAG_FP_VALID 0x1
|
|
|
|
/* Implement the "init" method of struct tramp_frame. */
|
|
|
|
static void
|
|
aarch64_fbsd_sigframe_init (const struct tramp_frame *self,
|
|
const frame_info_ptr &this_frame,
|
|
struct trad_frame_cache *this_cache,
|
|
CORE_ADDR func)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
CORE_ADDR sp = get_frame_register_unsigned (this_frame, AARCH64_SP_REGNUM);
|
|
CORE_ADDR mcontext_addr
|
|
= (sp
|
|
+ AARCH64_SIGFRAME_UCONTEXT_OFFSET
|
|
+ AARCH64_UCONTEXT_MCONTEXT_OFFSET);
|
|
gdb_byte buf[4];
|
|
|
|
trad_frame_set_reg_regmap (this_cache, aarch64_fbsd_gregmap, mcontext_addr,
|
|
regcache_map_entry_size (aarch64_fbsd_gregmap));
|
|
|
|
if (target_read_memory (mcontext_addr + AARCH64_MCONTEXT_FLAGS_OFFSET, buf,
|
|
4) == 0
|
|
&& (extract_unsigned_integer (buf, 4, byte_order)
|
|
& AARCH64_MCONTEXT_FLAG_FP_VALID))
|
|
trad_frame_set_reg_regmap (this_cache, aarch64_fbsd_fpregmap,
|
|
mcontext_addr + AARCH64_MCONTEXT_FPREGS_OFFSET,
|
|
regcache_map_entry_size (aarch64_fbsd_fpregmap));
|
|
|
|
trad_frame_set_id (this_cache, frame_id_build (sp, func));
|
|
}
|
|
|
|
static const struct tramp_frame aarch64_fbsd_sigframe =
|
|
{
|
|
SIGTRAMP_FRAME,
|
|
4,
|
|
{
|
|
{0x910003e0, ULONGEST_MAX}, /* mov x0, sp */
|
|
{0x91014000, ULONGEST_MAX}, /* add x0, x0, #SF_UC */
|
|
{0xd2803428, ULONGEST_MAX}, /* mov x8, #SYS_sigreturn */
|
|
{0xd4000001, ULONGEST_MAX}, /* svc 0x0 */
|
|
{TRAMP_SENTINEL_INSN, ULONGEST_MAX}
|
|
},
|
|
aarch64_fbsd_sigframe_init
|
|
};
|
|
|
|
/* Register set definitions. */
|
|
|
|
const struct regset aarch64_fbsd_gregset =
|
|
{
|
|
aarch64_fbsd_gregmap,
|
|
regcache_supply_regset, regcache_collect_regset
|
|
};
|
|
|
|
const struct regset aarch64_fbsd_fpregset =
|
|
{
|
|
aarch64_fbsd_fpregmap,
|
|
regcache_supply_regset, regcache_collect_regset
|
|
};
|
|
|
|
static void
|
|
aarch64_fbsd_supply_tls_regset (const struct regset *regset,
|
|
struct regcache *regcache,
|
|
int regnum, const void *buf, size_t size)
|
|
{
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
regcache->supply_regset (regset, tdep->tls_regnum_base, regnum, buf, size);
|
|
}
|
|
|
|
static void
|
|
aarch64_fbsd_collect_tls_regset (const struct regset *regset,
|
|
const struct regcache *regcache,
|
|
int regnum, void *buf, size_t size)
|
|
{
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
regcache->collect_regset (regset, tdep->tls_regnum_base, regnum, buf, size);
|
|
}
|
|
|
|
const struct regset aarch64_fbsd_tls_regset =
|
|
{
|
|
aarch64_fbsd_tls_regmap,
|
|
aarch64_fbsd_supply_tls_regset, aarch64_fbsd_collect_tls_regset
|
|
};
|
|
|
|
/* Implement the "iterate_over_regset_sections" gdbarch method. */
|
|
|
|
static void
|
|
aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
|
iterate_over_regset_sections_cb *cb,
|
|
void *cb_data,
|
|
const struct regcache *regcache)
|
|
{
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
cb (".reg", AARCH64_FBSD_SIZEOF_GREGSET, AARCH64_FBSD_SIZEOF_GREGSET,
|
|
&aarch64_fbsd_gregset, NULL, cb_data);
|
|
cb (".reg2", AARCH64_FBSD_SIZEOF_FPREGSET, AARCH64_FBSD_SIZEOF_FPREGSET,
|
|
&aarch64_fbsd_fpregset, NULL, cb_data);
|
|
|
|
if (tdep->has_tls ())
|
|
cb (".reg-aarch-tls", AARCH64_FBSD_SIZEOF_TLSREGSET,
|
|
AARCH64_FBSD_SIZEOF_TLSREGSET, &aarch64_fbsd_tls_regset,
|
|
"TLS register", cb_data);
|
|
}
|
|
|
|
/* Implement the "core_read_description" gdbarch method. */
|
|
|
|
static const struct target_desc *
|
|
aarch64_fbsd_core_read_description (struct gdbarch *gdbarch,
|
|
struct target_ops *target, bfd *abfd)
|
|
{
|
|
asection *tls = bfd_get_section_by_name (abfd, ".reg-aarch-tls");
|
|
|
|
aarch64_features features;
|
|
features.tls = tls != nullptr? 1 : 0;
|
|
|
|
return aarch64_read_description (features);
|
|
}
|
|
|
|
/* Implement the get_thread_local_address gdbarch method. */
|
|
|
|
static CORE_ADDR
|
|
aarch64_fbsd_get_thread_local_address (struct gdbarch *gdbarch, ptid_t ptid,
|
|
CORE_ADDR lm_addr, CORE_ADDR offset)
|
|
{
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
struct regcache *regcache;
|
|
|
|
regcache = get_thread_arch_regcache (current_inferior (), ptid, gdbarch);
|
|
|
|
target_fetch_registers (regcache, tdep->tls_regnum_base);
|
|
|
|
ULONGEST tpidr;
|
|
if (regcache->cooked_read (tdep->tls_regnum_base, &tpidr) != REG_VALID)
|
|
error (_("Unable to fetch %%tpidr"));
|
|
|
|
/* %tpidr points to the TCB whose first member is the dtv
|
|
pointer. */
|
|
CORE_ADDR dtv_addr = tpidr;
|
|
return fbsd_get_thread_local_address (gdbarch, dtv_addr, lm_addr, offset);
|
|
}
|
|
|
|
/* Implement the 'init_osabi' method of struct gdb_osabi_handler. */
|
|
|
|
static void
|
|
aarch64_fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
/* Generic FreeBSD support. */
|
|
fbsd_init_abi (info, gdbarch);
|
|
|
|
set_solib_svr4_ops (gdbarch, make_svr4_lp64_solib_ops);
|
|
|
|
tramp_frame_prepend_unwinder (gdbarch, &aarch64_fbsd_sigframe);
|
|
|
|
/* Enable longjmp. */
|
|
tdep->jb_pc = 13;
|
|
|
|
set_gdbarch_iterate_over_regset_sections
|
|
(gdbarch, aarch64_fbsd_iterate_over_regset_sections);
|
|
set_gdbarch_core_read_description (gdbarch,
|
|
aarch64_fbsd_core_read_description);
|
|
|
|
if (tdep->has_tls ())
|
|
{
|
|
set_gdbarch_fetch_tls_load_module_address (gdbarch,
|
|
svr4_fetch_objfile_link_map);
|
|
set_gdbarch_get_thread_local_address
|
|
(gdbarch, aarch64_fbsd_get_thread_local_address);
|
|
}
|
|
}
|
|
|
|
INIT_GDB_FILE (aarch64_fbsd_tdep)
|
|
{
|
|
gdbarch_register_osabi (bfd_arch_aarch64, 0, GDB_OSABI_FREEBSD,
|
|
aarch64_fbsd_init_abi);
|
|
}
|