Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-05 15:15:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug in matching notifications.

Browse Source 
Due to copy-n-paste, the problem caused PR remote/15974 also exists
in gdbserver.  This patch fixes it in the same way.  Patch to fix
remote/15974 can be found:

  https://sourceware.org/ml/gdb-patches/2013-12/msg00014.html

gdb/gdbserver:

2013-12-11  Yao Qi  <yao@codesourcery.com>

	* notif.c (handle_notif_ack): Return 0 if no notification
	matches.
This commit is contained in:
Yao Qi
2013-12-10 21:59:20 +08:00
parent 7b3fd68b73
commit e7f0d979dd
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/gdbserver/ChangeLog
View File

@@ -1,3 +1,8 @@
2013-12-11 Yao Qi <yao@codesourcery.com>
* notif.c (handle_notif_ack): Return 0 if no notification
matches.
2013-11-20 Doug Evans <dje@google.com> 2013-11-20 Doug Evans <dje@google.com>
* linux-low.c (linux_set_resume_request): Fix comment. * linux-low.c (linux_set_resume_request): Fix comment.

15
gdb/gdbserver/notif.c
View File

@@ -78,20 +78,23 @@ notif_write_event (struct notif_server *notif, char *own_buf)
int int
handle_notif_ack (char *own_buf, int packet_len) handle_notif_ack (char *own_buf, int packet_len)
{ {
int i = 0; size_t i;
struct notif_server *np = NULL; struct notif_server *np;
for (i = 0; i < ARRAY_SIZE (notifs); i++) for (i = 0; i < ARRAY_SIZE (notifs); i++)
{ {
np = notifs[i]; const char *ack_name = notifs[i]->ack_name;
if (strncmp (own_buf, np->ack_name, strlen (np->ack_name)) == 0
&& packet_len == strlen (np->ack_name)) if (strncmp (own_buf, ack_name, strlen (ack_name)) == 0
&& packet_len == strlen (ack_name))
break; break;
} }
if (np == NULL) if (i == ARRAY_SIZE (notifs))
return 0; return 0;
np = notifs[i];
/* If we're waiting for GDB to acknowledge a pending event, /* If we're waiting for GDB to acknowledge a pending event,
consider that done. */ consider that done. */
if (!QUEUE_is_empty (notif_event_p, np->queue)) if (!QUEUE_is_empty (notif_event_p, np->queue))