Put bcache inside "namespace gdb"

This avoids a conflict with a system "struct bcache" on
Solaris (see e.g.
https://www.isi.edu/nsnam/archive/ns-users/webarch/2001/msg05393.html)

Note that the Solaris conflict for now only surfaces with
--enable-targets=all (which the build bot doesn't use).

gdb/ChangeLog:

2019-12-06  Christian Biesinger  <cbiesinger@google.com>

	* bcache.c: Put in namespace gdb.
	* bcache.h: Likewise.
	* gdbtypes.c (check_types_worklist): Update.
	(types_deeply_equal): Update.
	* macrotab.c (struct macro_table) <bcache>: Update.
	(new_macro_table): Update.
	* macrotab.h (struct bcache): Put this forward declaration
	inside namespace gdb.
	(new_macro_table): Update.
	* objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
	Update.
	<macro_cache>: Update.
	* psymtab.h: (psymtab_storage) <psymbol_cache>: Update.

Change-Id: I843d5e91f7ccb3db6d1099a8214c15a74510256f
This commit is contained in:
Christian Biesinger
2019-12-02 15:05:54 -06:00
parent 93e55f0a03
commit dfb65191d8
8 changed files with 36 additions and 9 deletions

View File

@@ -3813,7 +3813,7 @@ check_types_equal (struct type *type1, struct type *type2,
static bool
check_types_worklist (std::vector<type_equality_entry> *worklist,
struct bcache *cache)
gdb::bcache *cache)
{
while (!worklist->empty ())
{
@@ -3849,7 +3849,7 @@ types_deeply_equal (struct type *type1, struct type *type2)
if (type1 == type2)
return true;
struct bcache cache (nullptr, nullptr);
gdb::bcache cache (nullptr, nullptr);
worklist.emplace_back (type1, type2);
return check_types_worklist (&worklist, &cache);
}