Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-25 16:57:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

bfdtest1 loop check

Browse Source 
Add a check that next_archived_file doesn't return the same element.
Seen with the following, which I think shows a bug with "ar r" and
thin archives as you get two copies of artest.a in artest2.a.

$ rm tmpdir/artest*
$ ./ar rc tmpdir/artest.a tmpdir/bintest.o
$ ./ar rcT tmpdir/artest2.a tmpdir/artest.a
$ ./bfdtest1 tmpdir/artest.a
$ ./bfdtest1 tmpdir/artest2.a
$ ./ar rcT tmpdir/artest2.a tmpdir/artest.a
$ ./bfdtest1 tmpdir/artest2.a
oops: next_archived_file
This commit is contained in:
Alan Modra
2025-01-01 22:51:44 +10:30
parent bc67f5df70
commit c5e10fb2eb
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
binutils/bfdtest1.c
View File

@@ -53,6 +53,8 @@ main (int argc, char **argv)
last = next) last = next)
{ {
next = bfd_openr_next_archived_file (archive, last); next = bfd_openr_next_archived_file (archive, last);
if (next == last)
die ("next_archived_file");
bfd_close (last); bfd_close (last);
count++; count++;
} }
@@ -62,6 +64,8 @@ main (int argc, char **argv)
last = next) last = next)
{ {
next = bfd_openr_next_archived_file (archive, last); next = bfd_openr_next_archived_file (archive, last);
if (next == last)
die ("next_archived_file");
bfd_close (last); bfd_close (last);
count--; count--;
} }