Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-06 07:33:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated.

Browse Source 
PR 23056
	* aoutx.h (aout_get_external_symbols): Allocate an extra byte at
	the end of the string table, and zero it.
This commit is contained in:
Nick Clifton
2018-04-23 12:52:42 +01:00
parent 5a6312e8c0
commit bf82069dce
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
bfd/ChangeLog
View File

@@ -1,3 +1,9 @@
2018-04-23 Nick Clifton <nickc@redhat.com>
PR 23056
* aoutx.h (aout_get_external_symbols): Allocate an extra byte at
the end of the string table, and zero it.
2018-04-23 Alan Modra <amodra@gmail.com> 2018-04-23 Alan Modra <amodra@gmail.com>
* elf-linux-core.h (swap_linux_prpsinfo32_ugid32_out): Disable * elf-linux-core.h (swap_linux_prpsinfo32_ugid32_out): Disable
@@ -7,6 +13,12 @@
(swap_linux_prpsinfo64_ugid16_out): Likewise. (swap_linux_prpsinfo64_ugid16_out): Likewise.
* elf.c (elfcore_write_prpsinfo): Likewise. * elf.c (elfcore_write_prpsinfo): Likewise.
2018-04-23 Nick Clifton <nickc@redhat.com>
PR 23056
* aoutx.h (aout_get_external_symbols): Allocate an extra byte at
the end of the string table, and zero it.
2018-04-20 Alan Modra <amodra@gmail.com> 2018-04-20 Alan Modra <amodra@gmail.com>
PR 22978 PR 22978

7
bfd/aoutx.h
View File

@@ -1343,7 +1343,7 @@ aout_get_external_symbols (bfd *abfd)
#ifdef USE_MMAP #ifdef USE_MMAP
if (stringsize >= BYTES_IN_WORD) if (stringsize >= BYTES_IN_WORD)
{ {
if (! bfd_get_file_window (abfd, obj_str_filepos (abfd), stringsize, if (! bfd_get_file_window (abfd, obj_str_filepos (abfd), stringsize + 1,
&obj_aout_string_window (abfd), TRUE)) &obj_aout_string_window (abfd), TRUE))
return FALSE; return FALSE;
strings = (char *) obj_aout_string_window (abfd).data; strings = (char *) obj_aout_string_window (abfd).data;
@@ -1351,7 +1351,7 @@ aout_get_external_symbols (bfd *abfd)
else else
#endif #endif
{ {
strings = (char *) bfd_malloc (stringsize); strings = (char *) bfd_malloc (stringsize + 1);
if (strings == NULL) if (strings == NULL)
return FALSE; return FALSE;
@@ -1370,7 +1370,8 @@ aout_get_external_symbols (bfd *abfd)
/* Ensure that a zero index yields an empty string. */ /* Ensure that a zero index yields an empty string. */
strings[0] = '\0'; strings[0] = '\0';
strings[stringsize - 1] = 0; /* Ensure that the string buffer is NUL terminated. */
strings[stringsize] = 0;
obj_aout_external_strings (abfd) = strings; obj_aout_external_strings (abfd) = strings;
obj_aout_external_string_size (abfd) = stringsize; obj_aout_external_string_size (abfd) = stringsize;