Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 04:24:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdbserver: Update require_int function to parse offset for pread packet

Browse Source 
Currently gdbserver uses the require_int() function to parse the
requested offset (in vFile::pread packet and the like).  This function
allows integers up to 0x7fffffff (to fit in 32-bit int), however the
offset (for the pread system call) has an off_t type which can be
larger than 32-bit.

This patch allows require_int() function to parse offset up to the
maximum value implied by the off_t type.

Approved-By: Pedro Alves <pedro@palves.net>
Change-Id: I3691bcc1ab1838c0db7f8b82d297d276a5419c8c
This commit is contained in:
Kirill Radkin
2025-06-03 16:48:23 +03:00
committed by Pedro Alves
parent 959a00dc23
commit ba4bedeafa
3 changed files with 91 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
gdbserver/hostio.cc
View File

@@ -89,12 +89,18 @@ require_filename (char **pp, char *filename)
return 0;
}
template <typename T>
static int
require_int (char **pp, int *value)
require_int (char **pp, T *value)
{
constexpr bool is_signed = std::is_signed<T>::value;
char *p;
int count, firstdigit;
/* Max count of hexadecimal digits in T (1 hex digit is 4 bits). */
int max_count = sizeof (T) * CHAR_BIT / 4;
p = *pp;
*value = 0;
count = 0;
@@ -111,7 +117,8 @@ require_int (char **pp, int *value)
firstdigit = nib;
/* Don't allow overflow. */
if (count >= 8 || (count == 7 && firstdigit >= 0x8))
if (count >= max_count
|| (is_signed && count == (max_count - 1) && firstdigit >= 0x8))
return -1;
*value = *value * 16 + nib;
@@ -343,7 +350,8 @@ handle_open (char *own_buf)
static void
handle_pread (char *own_buf, int *new_packet_len)
{
int fd, ret, len, offset, bytes_sent;
int fd, ret, len, bytes_sent;
off_t offset;
char *p, *data;
static int max_reply_size = -1;
@@ -410,7 +418,8 @@ handle_pread (char *own_buf, int *new_packet_len)
static void
handle_pwrite (char *own_buf, int packet_len)
{
int fd, ret, len, offset;
int fd, ret, len;
off_t offset;
char *p, *data;
p = own_buf + strlen ("vFile:pwrite:");