Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

2002-12-01 Andrew Cagney <ac131313@redhat.com>

Browse Source 
* gdbarch.sh (DEPRECATED_PC_IN_CALL_DUMMY): Rename
	PC_IN_CALL_DUMMY.  Change to predicate.  Always allow call.
	* gdbarch.h, gdbarch.c: Re-generate.
	* config/sparc/tm-sparc.h, config/sparc/tm-sp64.h: Update.
	* config/mn10200/tm-mn10200.h, config/h8500/tm-h8500.h: Update.
	* config/pa/tm-hppa.h, frame.h: Update.
	* x86-64-tdep.c, vax-tdep.c, sparc-tdep.c: Update.
	* s390-tdep.c, ns32k-tdep.c, mn10300-tdep.c: Update.
	* m68k-tdep.c, i386-tdep.c, frv-tdep.c: Update.
	* cris-tdep.c, alpha-tdep.c: Update.
	* frame.c (set_unwind_by_pc, create_new_frame): Use either
	DEPRECATED_PC_IN_CALL_DUMMY or pc_in_dummy_frame.
	(get_prev_frame): Ditto.

Index: doc/ChangeLog
2002-12-01  Andrew Cagney  <ac131313@redhat.com>

	* gdbint.texinfo (Target Architecture Definition): Delete
	PC_IN_CALL_DUMMY.
This commit is contained in:
Andrew Cagney
2002-12-01 19:07:16 +00:00
parent 27bdea3da4
commit ae45cd1682
44 changed files with 262 additions and 201 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
gdb/frame.h
View File

@@ -135,13 +135,13 @@ extern void find_frame_sal (struct frame_info *frame,
*FRAME* macros, a frame address has no defined meaning other than
as a magic cookie which identifies a frame over calls to the
inferior (um, SEE NOTE BELOW). The only known exception is
inferior.h (PC_IN_CALL_DUMMY) [ON_STACK]; see comments there. You
cannot assume that a frame address contains enough information to
reconstruct the frame; if you want more than just to identify the
frame (e.g. be able to fetch variables relative to that frame),
then save the whole struct frame_info (and the next struct
frame_info, since the latter is used for fetching variables on some
machines) (um, again SEE NOTE BELOW).
inferior.h (DEPRECATED_PC_IN_CALL_DUMMY) [ON_STACK]; see comments
there. You cannot assume that a frame address contains enough
information to reconstruct the frame; if you want more than just to
identify the frame (e.g. be able to fetch variables relative to
that frame), then save the whole struct frame_info (and the next
struct frame_info, since the latter is used for fetching variables
on some machines) (um, again SEE NOTE BELOW).
NOTE: cagney/2002-11-18: Actually, the frame address isn't
sufficient for identifying a frame, and the counter examples are
@@ -156,12 +156,13 @@ extern void find_frame_sal (struct frame_info *frame,
comparing both the frame's base and the frame's enclosing function
(frame_find_by_id() is going to be modified to perform this test).
The generic dummy frame version of PC_IN_CALL_DUMMY() is able to
identify a dummy frame using only the PC value. So the frame
address is not needed. In fact, most PC_IN_CALL_DUMMY() calls now
pass zero as the frame/sp values as the caller knows that those
values won't be used. Once all architectures are using generic
dummy frames, PC_IN_CALL_DUMMY() can drop the sp/frame parameters.
The generic dummy frame version of DEPRECATED_PC_IN_CALL_DUMMY() is
able to identify a dummy frame using only the PC value. So the
frame address is not needed. In fact, most
DEPRECATED_PC_IN_CALL_DUMMY() calls now pass zero as the frame/sp
values as the caller knows that those values won't be used. Once
all architectures are using generic dummy frames,
DEPRECATED_PC_IN_CALL_DUMMY() can drop the sp/frame parameters.
When it comes to finding a dummy frame, the next frame's frame ID
(with out duing an unwind) can be used (ok, could if it wasn't for
the need to change the way the PPC defined frame base in a strange
@@ -201,13 +202,14 @@ extern enum frame_type get_frame_type (struct frame_info *);
/* FIXME: cagney/2002-11-10: Some targets want to directly mark a
frame as being of a specific type. This shouldn't be necessary.
PC_IN_SIGTRAMP() indicates a SIGTRAMP_FRAME and PC_IN_CALL_DUMMY()
indicates a DUMMY_FRAME. I suspect the real problem here is that
get_prev_frame() only sets initialized after INIT_EXTRA_FRAME_INFO
as been called. Consequently, some targets found that the frame's
type was wrong and tried to fix it. The correct fix is to modify
get_prev_frame() so that it initializes the frame's type before
calling any other functions. */
PC_IN_SIGTRAMP() indicates a SIGTRAMP_FRAME and
DEPRECATED_PC_IN_CALL_DUMMY() indicates a DUMMY_FRAME. I suspect
the real problem here is that get_prev_frame() only sets
initialized after INIT_EXTRA_FRAME_INFO as been called.
Consequently, some targets found that the frame's type was wrong
and tried to fix it. The correct fix is to modify get_prev_frame()
so that it initializes the frame's type before calling any other
functions. */
extern void deprecated_set_frame_type (struct frame_info *,
enum frame_type type);