Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-06 07:33:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/contrib] Add two rules in common-misspellings.txt

Browse Source 
Eli mentioned [1] that given that we use US English spelling in our
documentation, we should use "behavior" instead of "behaviour".

In wikipedia-common-misspellings.txt there's a rule:
...
behavour->behavior, behaviour
...
which leaves this as a choice.

Add an overriding rule to hardcode the choice to common-misspellings.txt:
...
behavour->behavior
...
and add a rule to rewrite behaviour into behavior:
...
behaviour->behavior
...
and re-run spellcheck.sh on gdb*.

Tested on x86_64-linux.

[1] https://sourceware.org/pipermail/gdb-patches/2024-November/213371.html
This commit is contained in:
Tom de Vries
2024-11-23 12:20:34 +01:00
parent 63eedf3b09
commit ac51afb51c
84 changed files with 135 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/c-lang.c
View File

@@ -337,17 +337,17 @@ c_get_string (struct value *value, gdb::unique_xmalloc_ptr<gdb_byte> *buffer,
addr = value_as_address (value);
/* Prior to the fix for PR 16196 read_string would ignore fetchlimit
if length > 0. The old "broken" behaviour is the behaviour we want:
if length > 0. The old "broken" behavior is the behavior we want:
The caller may want to fetch 100 bytes from a variable length array
implemented using the common idiom of having an array of length 1 at
the end of a struct. In this case we want to ignore the declared
size of the array. However, it's counterintuitive to implement that
behaviour in read_string: what does fetchlimit otherwise mean if
length > 0. Therefore we implement the behaviour we want here:
behavior in read_string: what does fetchlimit otherwise mean if
length > 0. Therefore we implement the behavior we want here:
If *length > 0, don't specify a fetchlimit. This preserves the
previous behaviour. We could move this check above where we know
previous behavior. We could move this check above where we know
whether the array is declared with a fixed size, but we only want
to apply this behaviour when calling read_string. PR 16286. */
to apply this behavior when calling read_string. PR 16286. */
if (*length > 0)
fetchlimit = UINT_MAX;