Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix completing an empty string

Browse Source 
Earlier while working on the big completer rework series, I managed to
break

 (gdb) [TAB]

locally, and make GDB crash, but only notice a few weeks down the
road, because we have no test for that...

I also noticed that:

 (gdb)     [TAB]

didn't work (didn't show all commands as matches), even though
entering a command with leading whitespace works:

 (gdb)     help

This commit fixes the latter and adds a testcase that covers both
issues.

The gdb.base/completion.exp change is necessary because the new test
has a file name that also starts with "gdb.base/complet", making that
particular test ambiguous.  Adding another letter disambiguates.

gdb/ChangeLog:
2017-11-25   Pedro Alves  <palves@redhat.com>

	* completer.c (complete_line_internal_1): Skip spaces until the
	start of the command.

gdb/testsuite/ChangeLog:
2017-11-25   Pedro Alves  <palves@redhat.com>

	* gdb.base/complete-empty.exp: New file.
	* gdb.base/completion.exp: Adjust.
This commit is contained in:
Pedro Alves
2017-11-25 00:20:31 +00:00
parent 6a3c6ee418
commit a81aaca057
5 changed files with 63 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/completer.c
View File

@@ -1270,10 +1270,13 @@ complete_line_internal_1 (completion_tracker &tracker,
word = tmp_command + point - strlen (text);
}
if (point == 0)
/* Move P up to the start of the command. */
p = skip_spaces (p);
if (*p == '\0')
{
/* An empty line we want to consider ambiguous; that is, it
could be any command. */
/* An empty line is ambiguous; that is, it could be any
command. */
c = CMD_LIST_AMBIGUOUS;
result_list = 0;
}