Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-08 00:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix "finish" for vector types on ARM

Browse Source 
On a big-endian ARM system, "finish" printed the wrong value when
finishing from a function that returned a vector type.  Similarly,
calls to a function also resulted in the wrong value being passed.  I
think both the read- and write-functions here should ignore the
endian-ness.

I tested this using the AdaCore internal test suite; the test case
that caught this is identical to gdb.base/gnu_vector.exp.

Approved-By: Luis Machado <luis.machado@arm.com>
This commit is contained in:
Tom Tromey
2023-09-20 09:16:19 -06:00
parent b4b9074dc0
commit a0bfd1bfa6
1 changed files with 6 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gdb/arm-tdep.c
View File

@@ -9777,29 +9777,22 @@ arm_neon_quad_read (struct gdbarch *gdbarch, readable_regcache *regcache,
{ {
char name_buf[4]; char name_buf[4];
gdb_byte reg_buf[8]; gdb_byte reg_buf[8];
int offset, double_regnum; int double_regnum;
enum register_status status; enum register_status status;
xsnprintf (name_buf, sizeof (name_buf), "d%d", regnum << 1); xsnprintf (name_buf, sizeof (name_buf), "d%d", regnum << 1);
double_regnum = user_reg_map_name_to_regnum (gdbarch, name_buf, double_regnum = user_reg_map_name_to_regnum (gdbarch, name_buf,
strlen (name_buf)); strlen (name_buf));
/* d0 is always the least significant half of q0. */
if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG)
offset = 8;
else
offset = 0;
status = regcache->raw_read (double_regnum, reg_buf); status = regcache->raw_read (double_regnum, reg_buf);
if (status != REG_VALID) if (status != REG_VALID)
return status; return status;
memcpy (buf + offset, reg_buf, 8); memcpy (buf, reg_buf, 8);
offset = 8 - offset;
status = regcache->raw_read (double_regnum + 1, reg_buf); status = regcache->raw_read (double_regnum + 1, reg_buf);
if (status != REG_VALID) if (status != REG_VALID)
return status; return status;
memcpy (buf + offset, reg_buf, 8); memcpy (buf + 8, reg_buf, 8);
return REG_VALID; return REG_VALID;
} }
@@ -9874,21 +9867,14 @@ arm_neon_quad_write (struct gdbarch *gdbarch, struct regcache *regcache,
int regnum, const gdb_byte *buf) int regnum, const gdb_byte *buf)
{ {
char name_buf[4]; char name_buf[4];
int offset, double_regnum; int double_regnum;
xsnprintf (name_buf, sizeof (name_buf), "d%d", regnum << 1); xsnprintf (name_buf, sizeof (name_buf), "d%d", regnum << 1);
double_regnum = user_reg_map_name_to_regnum (gdbarch, name_buf, double_regnum = user_reg_map_name_to_regnum (gdbarch, name_buf,
strlen (name_buf)); strlen (name_buf));
/* d0 is always the least significant half of q0. */ regcache->raw_write (double_regnum, buf);
if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG) regcache->raw_write (double_regnum + 1, buf + 8);
offset = 8;
else
offset = 0;
regcache->raw_write (double_regnum, buf + offset);
offset = 8 - offset;
regcache->raw_write (double_regnum + 1, buf + offset);
} }
/* Store the contents of BUF to the MVE pseudo register REGNUM. */ /* Store the contents of BUF to the MVE pseudo register REGNUM. */