Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 09:08:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove call to reset from compile_to_object

Browse Source 
compile_to_object declares 'error_message' and then immediately calls
reset on it.  It seemed better to change it to use initialization
instead; and then I noticed that set_arguments could return a
unique_xmalloc_ptr<char> itself.

2021-01-23  Tom Tromey  <tom@tromey.com>

	* compile/compile-internal.h (class compile_instance)
	<set_arguments>: Change return type.
	* compile/compile.c (compile_to_object): Remove call to reset.
	(compile_instance::set_arguments): Change return type.
This commit is contained in:
Tom Tromey
2021-01-23 17:48:32 -07:00
parent c99d72de18
commit 9f7f6cb8d2
3 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/compile/compile.c
View File

@@ -714,9 +714,8 @@ compile_to_object (struct command_line *cmd, const char *cmd_string,
int argc = argv_holder.count ();
char **argv = argv_holder.get ();
gdb::unique_xmalloc_ptr<char> error_message;
error_message.reset (compiler->set_arguments (argc, argv,
triplet_rx.c_str ()));
gdb::unique_xmalloc_ptr<char> error_message
= compiler->set_arguments (argc, argv, triplet_rx.c_str ());
if (error_message != NULL)
error ("%s", error_message.get ());
@@ -882,13 +881,14 @@ compile_instance::set_triplet_regexp (const char *regexp)
/* See compile-internal.h. */
char *
gdb::unique_xmalloc_ptr<char>
compile_instance::set_arguments (int argc, char **argv, const char *regexp)
{
if (version () >= GCC_FE_VERSION_1)
return FORWARD (set_arguments, argc, argv);
return gdb::unique_xmalloc_ptr<char> (FORWARD (set_arguments, argc, argv));
else
return FORWARD (set_arguments_v0, regexp, argc, argv);
return gdb::unique_xmalloc_ptr<char> (FORWARD (set_arguments_v0, regexp,
argc, argv));
}
/* See compile-internal.h. */