Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check OBJF_NOT_FILENAME in DWARF index code

Browse Source 
The DWARF index code currently uses 'stat' to see if an objfile
represents a real file.  However, I think it's more correct to check
OBJF_NOT_FILENAME instead.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey
2022-04-26 12:45:07 -06:00
parent 0d1703b8fb
commit 9dd9f9ce1e
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/dwarf2/index-write.c
View File

@@ -1411,9 +1411,8 @@ write_dwarf_index (dwarf2_per_objfile *per_objfile, const char *dir,
if (per_objfile->per_bfd->types.size () > 1)
error (_("Cannot make an index when the file has multiple .debug_types sections"));
struct stat st;
if (stat (objfile_name (objfile), &st) < 0)
perror_with_name (objfile_name (objfile));
gdb_assert ((objfile->flags & OBJF_NOT_FILENAME) == 0);
const char *index_suffix = (index_kind == dw_index_kind::DEBUG_NAMES
? INDEX5_SUFFIX : INDEX4_SUFFIX);
@@ -1472,10 +1471,8 @@ save_gdb_index_command (const char *arg, int from_tty)
for (objfile *objfile : current_program_space->objfiles ())
{
struct stat st;
/* If the objfile does not correspond to an actual file, skip it. */
if (stat (objfile_name (objfile), &st) < 0)
if ((objfile->flags & OBJF_NOT_FILENAME) != 0)
continue;
dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile);