Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-06 07:33:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent an attempt to allocate an excessive amount of memory when dumping the symbols in a malformed file.

Browse Source 
PR 24707
	* objdump.c (slurp_symtab): Fail with a helpful error message if
	the symbol table is too large.
This commit is contained in:
Nick Clifton
2019-06-28 13:30:00 +01:00
parent 999d6dff80
commit 781152ec18
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
binutils/ChangeLog
View File

@@ -1,3 +1,9 @@
2019-06-28 Nick Clifton <nickc@redhat.com>
PR 24707
* objdump.c (slurp_symtab): Fail with a helpful error message if
the symbol table is too large.
2019-06-26 Nick Clifton <nickc@redhat.com> 2019-06-26 Nick Clifton <nickc@redhat.com>
PR 24703 PR 24703

17
binutils/objdump.c
View File

@@ -704,7 +704,22 @@ slurp_symtab (bfd *abfd)
bfd_fatal (_("error message was")); bfd_fatal (_("error message was"));
} }
if (storage) if (storage)
sy = (asymbol **) xmalloc (storage); {
off_t filesize = bfd_get_file_size (abfd);
/* qv PR 24707. */
if (filesize > 0 && filesize < storage)
{
bfd_nonfatal_message (bfd_get_filename (abfd), abfd, NULL,
_("error: symbol table size (%#lx) is larger than filesize (%#lx)"),
storage, (long) filesize);
exit_status = 1;
symcount = 0;
return NULL;
}
sy = (asymbol **) xmalloc (storage);
}
symcount = bfd_canonicalize_symtab (abfd, sy); symcount = bfd_canonicalize_symtab (abfd, sy);
if (symcount < 0) if (symcount < 0)