mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-27 01:28:46 +00:00
change probes to be program-space-independent
This changes the probes to be independent of the program space. After this, when a probe's address is needed, it is determined by applying offsets at the point of use. This introduces a bound_probe object, similar to bound minimal symbols. Objects of this type are used when it's necessary to pass a probe and its corresponding objfile. This removes the backlink from probe to objfile, which was primarily used to fetch the architecture to use. This adds a get_probe_address function which calls a probe method to compute the probe's relocated address. Similarly, it adds an objfile parameter to the semaphore methods so they can do the relocation properly as well. 2014-03-03 Tom Tromey <tromey@redhat.com> * break-catch-throw.c (fetch_probe_arguments): Use bound probes. * breakpoint.c (create_longjmp_master_breakpoint): Use get_probe_address. (add_location_to_breakpoint, bkpt_probe_insert_location) (bkpt_probe_remove_location): Update. * breakpoint.h (struct bp_location) <probe>: Now a bound_probe. * elfread.c (elf_symfile_relocate_probe): Remove. (elf_probe_fns): Update. (insert_exception_resume_breakpoint): Change type of "probe" parameter to bound_probe. (check_exception_resume): Update. * objfiles.c (objfile_relocate1): Don't relocate probes. * probe.c (bound_probe_s): New typedef. (parse_probes): Use get_probe_address. Set sal's objfile. (find_probe_by_pc): Return a bound_probe. (collect_probes): Return a VEC(bound_probe_s). (compare_probes): Update. (gen_ui_out_table_header_info): Change type of "probes" parameter. Update. (info_probes_for_ops): Update. (get_probe_address): New function. (probe_safe_evaluate_at_pc): Update. * probe.h (struct probe_ops) <get_probe_address>: New field. <set_semaphore, clear_semaphore>: Add objfile parameter. (struct probe) <objfile>: Remove field. <arch>: New field. <address>: Update comment. (struct bound_probe): New. (find_probe_by_pc): Return a bound_probe. (get_probe_address): Declare. * solib-svr4.c (struct probe_and_action) <address>: New field. (hash_probe_and_action, equal_probe_and_action): Update. (register_solib_event_probe): Add address parameter. (solib_event_probe_at): Update. (svr4_create_probe_breakpoints): Add objfile parameter. Use get_probe_address. * stap-probe.c (struct stap_probe) <sem_addr>: Update comment. (stap_get_probe_address): New function. (stap_can_evaluate_probe_arguments, compute_probe_arg) (compile_probe_arg): Update. (stap_set_semaphore, stap_clear_semaphore): Compute semaphore's address. (handle_stap_probe): Don't relocate the probe. (stap_relocate): Remove. (stap_gen_info_probes_table_values): Update. (stap_probe_ops): Remove stap_relocate. * symfile-debug.c (debug_sym_relocate_probe): Remove. (debug_sym_probe_fns): Update. * symfile.h (struct sym_probe_fns) <sym_relocate_probe>: Remove. * symtab.c (init_sal): Use memset. * symtab.h (struct symtab_and_line) <objfile>: New field. * tracepoint.c (start_tracing, stop_tracing): Update.
This commit is contained in:
@@ -3323,7 +3323,9 @@ create_longjmp_master_breakpoint (void)
|
||||
{
|
||||
struct breakpoint *b;
|
||||
|
||||
b = create_internal_breakpoint (gdbarch, probe->address,
|
||||
b = create_internal_breakpoint (gdbarch,
|
||||
get_probe_address (probe,
|
||||
objfile),
|
||||
bp_longjmp_master,
|
||||
&internal_breakpoint_ops);
|
||||
b->addr_string = xstrdup ("-probe-stap libc:longjmp");
|
||||
@@ -3484,7 +3486,9 @@ create_exception_master_breakpoint (void)
|
||||
{
|
||||
struct breakpoint *b;
|
||||
|
||||
b = create_internal_breakpoint (gdbarch, probe->address,
|
||||
b = create_internal_breakpoint (gdbarch,
|
||||
get_probe_address (probe,
|
||||
objfile),
|
||||
bp_exception_master,
|
||||
&internal_breakpoint_ops);
|
||||
b->addr_string = xstrdup ("-probe-stap libgcc:unwind");
|
||||
@@ -9023,7 +9027,8 @@ add_location_to_breakpoint (struct breakpoint *b,
|
||||
loc->requested_address = sal->pc;
|
||||
loc->address = adjusted_address;
|
||||
loc->pspace = sal->pspace;
|
||||
loc->probe = sal->probe;
|
||||
loc->probe.probe = sal->probe;
|
||||
loc->probe.objfile = sal->objfile;
|
||||
gdb_assert (loc->pspace != NULL);
|
||||
loc->section = sal->section;
|
||||
loc->gdbarch = loc_gdbarch;
|
||||
@@ -13340,7 +13345,9 @@ bkpt_probe_insert_location (struct bp_location *bl)
|
||||
{
|
||||
/* The insertion was successful, now let's set the probe's semaphore
|
||||
if needed. */
|
||||
bl->probe->pops->set_semaphore (bl->probe, bl->gdbarch);
|
||||
bl->probe.probe->pops->set_semaphore (bl->probe.probe,
|
||||
bl->probe.objfile,
|
||||
bl->gdbarch);
|
||||
}
|
||||
|
||||
return v;
|
||||
@@ -13350,7 +13357,9 @@ static int
|
||||
bkpt_probe_remove_location (struct bp_location *bl)
|
||||
{
|
||||
/* Let's clear the semaphore before removing the location. */
|
||||
bl->probe->pops->clear_semaphore (bl->probe, bl->gdbarch);
|
||||
bl->probe.probe->pops->clear_semaphore (bl->probe.probe,
|
||||
bl->probe.objfile,
|
||||
bl->gdbarch);
|
||||
|
||||
return bkpt_remove_location (bl);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user