Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 01:07:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

MI: extract command completion logic from complete_command()

Browse Source 
Extract completion logic from CLI complete_command() into a new
helper function complete().

gdb/Changelog:

	* completer.h (complete): New function.
	* completer.c (complete): Likewise.
	* cli/cli-cmds.c: (complete_command): Update to use new complete()
	function defined in completer.h.
This commit is contained in:
Jan Vrany
2019-05-17 10:58:23 +01:00
parent 7d0e2ecede
commit 6e035501e1
4 changed files with 50 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
gdb/cli/cli-cmds.c
View File

@@ -243,40 +243,13 @@ complete_command (const char *arg, int from_tty)
if (arg == NULL)
arg = "";
completion_tracker tracker_handle_brkchars;
completion_tracker tracker_handle_completions;
completion_tracker *tracker;
int quote_char = '\0';
const char *word;
try
{
word = completion_find_completion_word (tracker_handle_brkchars,
arg, &quote_char);
/* Completers that provide a custom word point in the
handle_brkchars phase also compute their completions then.
Completers that leave the completion word handling to readline
must be called twice. */
if (tracker_handle_brkchars.use_custom_word_point ())
tracker = &tracker_handle_brkchars;
else
{
complete_line (tracker_handle_completions, word, arg, strlen (arg));
tracker = &tracker_handle_completions;
}
}
catch (const gdb_exception &ex)
{
return;
}
completion_result result = complete (arg, &word, &quote_char);
std::string arg_prefix (arg, word - arg);
completion_result result
= tracker->build_completion_result (word, word - arg, strlen (arg));
if (result.number_matches != 0)
{
if (result.number_matches == 1)