Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-05 15:15:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't require "Bss=" in qOffsets response

Browse Source 
The "Bss=" part of the qOffsets response is documented as being
optional, but gdb in fact requires it.  This patch fixes the bug.

I couldn't find a straightforward way to test this.  gdbserver does
send 'Bss=' -- but this code is only enabled for a fairly specific
setup:

    #if (defined(__UCLIBC__)		\
	 && defined(HAS_NOMMU)		\
	 && defined(PT_TEXT_ADDR)		\
	 && defined(PT_DATA_ADDR)		\
	 && defined(PT_TEXT_END_ADDR))
    #define SUPPORTS_READ_OFFSETS
    #endif

I also considered changing gdbserver to not send Bss=, but decided
against this, reasoning that we may as well not break compatibility
with older versions of gdb.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33319
Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Tom Tromey
2025-09-04 09:33:07 -06:00
parent e90c268b3e
commit 55fc9233a8
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/remote.c
View File

@@ -4669,8 +4669,6 @@ remote_target::get_offsets ()
if (bss_addr != data_addr) if (bss_addr != data_addr)
warning (_("Target reported unsupported offsets: %s"), buf); warning (_("Target reported unsupported offsets: %s"), buf);
} }
else
lose = 1;
} }
else if (startswith (ptr, "TextSeg=")) else if (startswith (ptr, "TextSeg="))
{ {