Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-08 08:33:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix seg-fault in the linker when examining a corrupt binary.

Browse Source 
PR ld/20909
	* aoutx.h (aout_link_add_symbols): Fix off-by-one error in check
	for an illegal string offset.
This commit is contained in:
Nick Clifton
2016-12-02 16:41:14 +00:00
parent 0c1b455e29
commit 531336e3a0
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@@ -1,3 +1,9 @@
2016-12-02 Nick Clifton <nickc@redhat.com>
PR ld/20909
* aoutx.h (aout_link_add_symbols): Fix off-by-one error in check
for an illegal string offset.
2016-12-02 Gary Benson <gbenson@redhat.com> 2016-12-02 Gary Benson <gbenson@redhat.com>
* elf.c (_bfd_elf_make_section_from_shdr): Pass offset to * elf.c (_bfd_elf_make_section_from_shdr): Pass offset to

3
bfd/aoutx.h
View File

@@ -3031,10 +3031,9 @@ aout_link_add_symbols (bfd *abfd, struct bfd_link_info *info)
continue; continue;
/* PR 19629: Corrupt binaries can contain illegal string offsets. */ /* PR 19629: Corrupt binaries can contain illegal string offsets. */
if (GET_WORD (abfd, p->e_strx) > obj_aout_external_string_size (abfd)) if (GET_WORD (abfd, p->e_strx) >= obj_aout_external_string_size (abfd))
return FALSE; return FALSE;
name = strings + GET_WORD (abfd, p->e_strx); name = strings + GET_WORD (abfd, p->e_strx);
value = GET_WORD (abfd, p->e_value); value = GET_WORD (abfd, p->e_value);
flags = BSF_GLOBAL; flags = BSF_GLOBAL;
string = NULL; string = NULL;