Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add new overload of gdbarch_return_value

Browse Source 
The gdbarch "return_value" can't correctly handle variably-sized
types.  The problem here is that the TYPE_LENGTH of such a type is 0,
until the type is resolved, which requires reading memory.  However,
gdbarch_return_value only accepts a buffer as an out parameter.

Fixing this requires letting the implementation of the gdbarch method
resolve the type and return a value -- that is, both the contents and
the new type.

After an attempt at this, I realized I wouldn't be able to correctly
update all implementations (there are ~80) of this method.  So,
instead, this patch adds a new method that falls back to the current
method, and it updates gdb to only call the new method.  This way it's
possible to incrementally convert the architectures that I am able to
test.
This commit is contained in:
Tom Tromey
2022-09-07 08:39:52 -06:00
parent 862ebb27bb
commit 4e1d2f5814
10 changed files with 121 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/infcall.c
View File

@@ -485,10 +485,9 @@ get_call_return_value (struct call_return_meta_info *ri)
}
else
{
retval = allocate_value (ri->value_type);
gdbarch_return_value (ri->gdbarch, ri->function, ri->value_type,
get_current_regcache (),
value_contents_raw (retval).data (), NULL);
gdbarch_return_value_as_value (ri->gdbarch, ri->function, ri->value_type,
get_current_regcache (),
&retval, NULL);
if (stack_temporaries && class_or_union_p (ri->value_type))
{
/* Values of class type returned in registers are copied onto