Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

ld: Lookup section in output with the same name

Browse Source 
When there are more than one input sections with the same section name,
SECNAME, linker picks the first one to define __start_SECNAME and
__stop_SECNAME symbols.  When the first input section is removed by
comdat group, we need to check if there is still an output section
with section name SECNAME.

	PR ld/23591
	* ldlang.c (undef_start_stop): Lookup section in output with
	the same name.
	* testsuite/ld-elf/pr23591.d: New file.
	* testsuite/ld-elf/pr23591a.s: Likewise.
	* testsuite/ld-elf/pr23591b.s: Likewise.
	* testsuite/ld-elf/pr23591c.s: Likewise.
This commit is contained in:
H.J. Lu
2018-08-31 09:25:31 -07:00
parent dab999b116
commit 4d1c633545
6 changed files with 88 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
ld/ldlang.c
View File

@@ -6097,6 +6097,24 @@ undef_start_stop (struct bfd_link_hash_entry *h)
|| strcmp (h->u.def.section->name,
h->u.def.section->output_section->name) != 0)
{
asection *sec = bfd_get_section_by_name (link_info.output_bfd,
h->u.def.section->name);
if (sec != NULL)
{
/* When there are more than one input sections with the same
section name, SECNAME, linker picks the first one to define
__start_SECNAME and __stop_SECNAME symbols. When the first
input section is removed by comdat group, we need to check
if there is still an output section with section name
SECNAME. */
asection *i;
for (i = sec->map_head.s; i != NULL; i = i->map_head.s)
if (strcmp (h->u.def.section->name, i->name) == 0)
{
h->u.def.section = i;
return;
}
}
h->type = bfd_link_hash_undefined;
h->u.undef.abfd = NULL;
}