Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-28 01:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always free matching vector from bfd_check_format_matches

Browse Source 
At least one place calling list_matching_formats failed to free the
"matching" vector from bfd_check_format_matches afterwards.  Fix that
by calling free inside list_matching_formats.

binutils/
	* bucomm.c (list_matching_formats): Free arg.
	* addr2line.c (process_file): Adjust to suit.
	* ar.c (open_inarch, ranlib_touch): Likewise.
	* coffdump.c (main): Likewise.
	* nm.c (display_archive, display_file): Likewise.
	* objcopy.c (copy_file): Likewise.
	* objdump.c (display_object_bfd): Likewise.
	* size.c (display_bfd): Likewise.
	* srconv.c (main): Likewise.
ld/
	* ldlang.c (load_symbols): Free "matching".
This commit is contained in:
Alan Modra
2022-06-16 14:48:13 +09:30
parent 8ad7c8be4b
commit 370426d0da
10 changed files with 21 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ld/ldlang.c
View File

@@ -3056,7 +3056,11 @@ load_symbols (lang_input_statement_type *entry,
/* See if the emulation has some special knowledge. */
if (ldemul_unrecognized_file (entry))
return true;
{
if (err == bfd_error_file_ambiguously_recognized)
free (matching);
return true;
}
if (err == bfd_error_file_ambiguously_recognized)
{
@@ -3066,6 +3070,7 @@ load_symbols (lang_input_statement_type *entry,
" matching formats:"), entry->the_bfd);
for (p = matching; *p != NULL; p++)
einfo (" %s", *p);
free (matching);
einfo ("%F\n");
}
else if (err != bfd_error_file_not_recognized