From 35e1c33162bf61a6d2e2da1128e8a841bd829e84 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Fri, 14 Nov 2025 11:50:59 +1030 Subject: [PATCH] objcopy binary symbol type check This exposes an error on alpha-linux-gnuecoff where the start and end syms are given the wrong storage class. * testsuite/binutils-all/objcopy.exp (binary_symbol): Tighten symbol type checking. --- binutils/testsuite/binutils-all/objcopy.exp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp index 43814ac5a70..5f1f7c6b49e 100644 --- a/binutils/testsuite/binutils-all/objcopy.exp +++ b/binutils/testsuite/binutils-all/objcopy.exp @@ -1631,8 +1631,11 @@ proc binary_symbol {name file args sym_prefix} { return } - foreach sym [list "start" "end" "size"] { - set exp "^\[0-9a-fA-F\]+ +\[TtDdA\] +${sym_prefix}_${sym}$" + set syms [list {D start} {D end} {A size}] + foreach e $syms { + set typ [lindex $e 0] + set sym [lindex $e 1] + set exp "^\[0-9a-fA-F\]+ +${typ} +${sym_prefix}_${sym}$" if ![regexp -line $exp $got] { send_log "failed to match: $exp\n" fail $test