Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Memory leak in process_abbrev_set

Browse Source 
We may have added some abbrevs to the list before hitting an error.
Free the list elements too.  free_abbrev_list returns list->next so we
need to init it earlier to avoid an uninitialised memory access.

	* dwarf.c (process_abbrev_set): Call free_abbrev_list on errors.
	Set list->next earlier.
This commit is contained in:
Alan Modra
2023-03-30 18:15:49 +10:30
parent c4e37fa8e5
commit 31991eaaee
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
binutils/dwarf.c
View File

@@ -990,6 +990,7 @@ process_abbrev_set (struct dwarf_section *section,
list->first_abbrev = NULL;
list->last_abbrev = NULL;
list->raw = start;
list->next = NULL;
while (start < end)
{
@@ -1005,17 +1006,13 @@ process_abbrev_set (struct dwarf_section *section,
the caller. */
if (start == end || entry == 0)
{
list->next = NULL;
list->start_of_next_abbrevs = start != end ? start : NULL;
return list;
}
READ_ULEB (tag, start, end);
if (start == end)
{
free (list);
return NULL;
}
return free_abbrev_list (list);
children = *start++;
@@ -1050,8 +1047,7 @@ process_abbrev_set (struct dwarf_section *section,
/* Report the missing single zero which ends the section. */
error (_("%s section not zero terminated\n"), section->name);
free (list);
return NULL;
return free_abbrev_list (list);
}
/* Return a sequence of abbrevs in SECTION starting at ABBREV_BASE