Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-27 01:28:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdb/completer: improve tab completion to consider the '-force-condition' flag

Browse Source 
The commit

  commit 733d554a46
  Author: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
  Date:   Tue Oct 27 10:56:03 2020 +0100

  gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition

introduced the '-force-condition' flag to the 'break' command.  This
flag was defined as a keyword like 'thread', 'task', and 'if'.
However, it starts with '-'.  This difference caused an uncovered case
when tab-completing a seemingly complete linespec.

Below, we see "-force-condition" in the completion list, where both
the options and the keywords are listed:

  (gdb) break -function main <TAB>
  -force-condition  -function  -label  -line  -qualified
  -source           if         task    thread

But tab-completing '-' lists only options:

  (gdb) break -function main -<TAB>
  -function   -label      -line       -qualified  -source

This patch fixes the problem by adding keywords to the completion
list, so that we see:

  (gdb) break -function main -<TAB>
  -force-condition  -function  -label  -line  -qualified  -source

gdb/ChangeLog:
2020-12-07  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

	* completer.c (complete_explicit_location): Also add keywords
	that start with '-' to the completion list.

gdb/testsuite/ChangeLog:
2020-12-07  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

	* gdb.linespec/explicit.exp: Extend with a test to check completing
	'-' after seemingly complete options.
This commit is contained in:
Tankut Baris Aktemur
2020-12-07 09:28:33 +01:00
parent 5759831a2d
commit 1f58f6c259
4 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/completer.c
View File

@@ -892,7 +892,11 @@ complete_explicit_location (completion_tracker &tracker,
int keyword = skip_keyword (tracker, explicit_options, &text);
if (keyword == -1)
complete_on_enum (tracker, explicit_options, text, text);
{
complete_on_enum (tracker, explicit_options, text, text);
/* There are keywords that start with "-". Include them, too. */
complete_on_enum (tracker, linespec_keywords, text, text);
}
else
{
/* Completing on value. */