Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 09:08:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

* gmalloc.c: Fix bug that causes malloc & free to

Browse Source 
fail on systems where pointers have the high bit set (0x800efcf0
for example).  The problem is that the difference between two
pointers is a signed integer, so the computation

	(char *) 0x800efcf0 - (char *) 0

yields a negative value.  The sign of the result of the modulus
operator is machine dependent for negative operands, thus it is
possible for it to end up negative.  From Fred Fish.
This commit is contained in:
John Gilmore
1991-12-07 12:16:13 +00:00
parent 0e0643c7a6
commit 1d0709e2a5
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/gmalloc.c
View File

@@ -559,7 +559,7 @@ DEFUN(__free, (ptr), PTR ptr)
prev = (struct list *) ptr;
_heapinfo[block].busy.info.frag.nfree = 1;
_heapinfo[block].busy.info.frag.first = (unsigned int)
(((char *) ptr - (char *) NULL) % BLOCKSIZE >> type);
(((unsigned int)((char *) ptr - (char *) NULL)) % BLOCKSIZE >> type);
prev->next = _fraghead[type].next;
prev->prev = &_fraghead[type];
prev->prev->next = prev;
@@ -656,7 +656,7 @@ DEFUN(align, (size), size_t size)
unsigned int adj;
result = (*__morecore)(size);
adj = (unsigned int) ((char *) result - (char *) NULL) % BLOCKSIZE;
adj = (unsigned int) ((unsigned int)((char *) result - (char *) NULL)) % BLOCKSIZE;
if (adj != 0)
{
adj = BLOCKSIZE - adj;
@@ -770,7 +770,7 @@ DEFUN(malloc, (size), size_t size)
block = BLOCK(result);
if (--_heapinfo[block].busy.info.frag.nfree != 0)
_heapinfo[block].busy.info.frag.first = (unsigned int)
(((char *) next->next - (char *) NULL) % BLOCKSIZE) >> log;
(((unsigned int)((char *) next->next - (char *) NULL)) % BLOCKSIZE) >> log;
/* Update the statistics. */
++_chunks_used;
@@ -1145,7 +1145,7 @@ DEFUN(valloc, (size), size_t size)
result = malloc(size + pagesize);
if (result == NULL)
return NULL;
adj = (unsigned int) ((char *) result - (char *) NULL) % pagesize;
adj = (unsigned int) ((unsigned int)((char *) result - (char *) NULL)) % pagesize;
if (adj != 0)
result = (char *) result + pagesize - adj;
return result;