mirror of
https://github.com/bminor/binutils-gdb.git
synced 2025-12-05 15:15:42 +00:00
libctf: improve handling of type dumping errors
When dumping a type fails with an error, we want to emit a warning noting this: a warning because it's not fatal and we can continue. But warnings don't automatically print out the ctf_errno (because not all cases causing warnings set the errno at all), so we must do it at warning-emission time or lose track of what's gone wrong. libctf/ * ctf-dump.c (ctf_dump_format_type): Dump the underlying error on type dump failure.
This commit is contained in:
@@ -239,7 +239,8 @@ ctf_dump_format_type (ctf_dict_t *fp, ctf_id_t id, int flag)
|
||||
oom:
|
||||
ctf_set_errno (fp, errno);
|
||||
err:
|
||||
ctf_err_warn (fp, 1, 0, _("cannot format name dumping type 0x%lx"), id);
|
||||
ctf_err_warn (fp, 1, ctf_errno (fp), _("cannot format name dumping type 0x%lx"),
|
||||
id);
|
||||
free (buf);
|
||||
free (str);
|
||||
free (bit);
|
||||
|
||||
Reference in New Issue
Block a user