Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-25 16:57:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

2004-08-02 Andrew Cagney <cagney@gnu.org>

Browse Source 
* regcache.h: Delete DEPRECATED_REGISTER_VIRTUAL_SIZE and
	DEPRECATED_REGISTER_RAW_SIZE from comments.
	* regcache.c (init_regcache_descr, regcache_dump): Do not check or
	use DEPRECATED_REGISTER_VIRTUAL_SIZE and
	DEPRECATED_REGISTER_RAW_SIZE.
	* findvar.c (value_of_register): Simplify by assuming that the
	registers raw and virtual sizes are identical.
	* regcache.h: Delete DEPRECATED_REGISTER_VIRTUAL_TYPE in
	comment.
	* arch-utils.c (generic_register_size): Simplify by assuming
	register_type.
This commit is contained in:
Andrew Cagney
2004-08-02 21:58:44 +00:00
parent 73f458fb31
commit 01e1877c5f
5 changed files with 21 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
gdb/regcache.h
View File

@@ -116,45 +116,13 @@ extern int register_offset_hack (struct gdbarch *gdbarch, int regnum);
/* The type of a register. This function is slightly more efficient
then its gdbarch vector counterpart since it returns a precomputed
value stored in a table.
NOTE: cagney/2002-08-17: The original macro was called
DEPRECATED_REGISTER_VIRTUAL_TYPE. This was because the register
could have different raw and cooked (nee virtual) representations.
The CONVERTABLE methods being used to convert between the two
representations. Current code does not do this. Instead, the
first [0..NUM_REGS) registers are 1:1 raw:cooked, and the type
exactly describes the register's representation. Consequently, the
``virtual'' has been dropped.
FIXME: cagney/2002-08-17: A number of architectures, including the
MIPS, are currently broken in this regard. */
value stored in a table. */
extern struct type *register_type (struct gdbarch *gdbarch, int regnum);
/* Return the size of register REGNUM. All registers should have only
one size.
FIXME: cagney/2003-02-28:
Unfortunately, thanks to some legacy architectures, this doesn't
hold. A register's cooked (nee virtual) and raw size can differ
(see MIPS). Such architectures should be using different register
numbers for the different sized views of identical registers.
Anyway, the up-shot is that, until that mess is fixed, core code
can end up being very confused - should the RAW or VIRTUAL size be
used? As a rule of thumb, use DEPRECATED_REGISTER_VIRTUAL_SIZE in
cooked code, but with the comment:
OK: REGISTER_VIRTUAL_SIZE
or just
OK
appended to the end of the line. */
one size. */
extern int register_size (struct gdbarch *gdbarch, int regnum);